Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Major
-
Resolution: Fixed
-
Affects Version/s: 2.0.4, 2.1.1, 2.2
-
Component/s: Web Services
-
Testing Instructions:
-
Workaround:
-
Difficulty:Easy
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
Web services attempt to send headers in instances where they've already been sent. Doesn't hurt functionally, but it does cause 4 warnings to goto the error_log each time a web service is called.
Moodle should make a headers_sent() check before sending off the headers.
Replication instructions:
1. Turn up debugging to include PHP warnings.
2. Make a webservice call
3. Notice the warnings that appear in apaches error log.
Gliffy Diagrams
Attachments
Activity
- All
- Comments
- Work Log
- History
- Activity
- Links Hierarchy
Thanks for reporting this and providing a solution.
I didn't test, but I know about this issue with SOAP server. The patch seems good to me, Mike, you can add to the next sprint and keep it assigned to me.
Thank you Adam.
Hello,
I do not like this change much because it only hides the fact that some code is doing something wrong. I looked at the code and it seems that the headers are sent only once in all cases. Could you get me a stack trace of the first and second sending of headers?
Petr
Thanks for the comment Petr, it got me to look in the right place.
I believe the issue is that the soap server is outputting content before the headers. Naturally as soon as you dump out content, headers are in effect sent.
In webservice/lib.php's run(), $response = $this->zend_server->handle(); is called before $this->send_headers();. handle() will call dump(), which just echoes out data.
I've changed my commit to what makes more sense given this. It moves the send_headers call before any output is possibly sent.
makes sense, thanks!
To integrators: please cherry pick to all 2.x branches
(fixing repository and branch)
Integrated, thanks! (backported to 20 and 21 stable)
Works Great 
Thanks for fixing this Adam and Petr.
Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.
Added link to github with a simple fix for this.