Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28484

We do not have a function to detect if we are being served on https

    XMLWordPrintable

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • 2.1, 2.5.2, 2.6.4, 2.7.1
    • 2.8
    • Libraries
    • MOODLE_21_STABLE, MOODLE_25_STABLE, MOODLE_26_STABLE, MOODLE_27_STABLE
    • MOODLE_28_STABLE
    • MDL-28484-master
    • Hide
      1. Check that behat tests passed on nightly

      For each of these scenarios

      1. http site with no loginhttps
      2. https site with no loginhttps
      3. http site with loginhttps

      Complete these steps

      1. Use a captcha in mod/feedback
      2. Attempt to login
      3. Logout
      4. Change user settings
      5. Upload a file
      6. Insert a file that has already been uploaded
      7. Ensure images and previews work as expected
      Show
      Check that behat tests passed on nightly For each of these scenarios http site with no loginhttps https site with no loginhttps http site with loginhttps Complete these steps Use a captcha in mod/feedback Attempt to login Logout Change user settings Upload a file Insert a file that has already been uploaded Ensure images and previews work as expected

    Description

      As we don't have a function, different places around Moodle are all doing a string comparison themselves.

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28486 youtube and vimeo embeding causes warnings on https sites

          • Major - Major loss of function, incorrect output
          • Closed
          caused a regression

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-48050 Existing scripts detecting https see a change in results

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          New Feature - A new Moodle feature which has yet to be developed. MDL-46269 Convert http embedded content to https on https sites where available

          • Major - Major loss of function, incorrect output
          • Closed
          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-38837 Check for http or https for include in openbadges backpack support.

          • Major - Major loss of function, incorrect output
          • Closed

          Improvement - An enhancement to an existing Moodle feature. MDL-45539 Support X-Forwarded-Proto and Forwarded headers in is_https

          • Minor - Minor loss of function where workaround is possible
          • Closed

          Activity

            People

              tonybutler Tony Butler
              poltawski Dan Poltawski
              John Okely John Okely
              Damyon Wiese Damyon Wiese
              Andrew Lyons Andrew Lyons
              David Woloszyn, Huong Nguyen, Jake Dallimore, Meirza, Michael Hawkins, Raquel Ortega, Safat Shahin, Stevani Andolo
              Votes:
              2 Vote for this issue
              Watchers:
              8 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved:
                10/Nov/14