Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28486

youtube and vimeo embeding causes warnings on https sites

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.3
    • Fix Version/s: 2.3.2
    • Component/s: Filters
    • Labels:
    • Environment:
      Internet Explorer
    • Testing Instructions:
      Hide

      General tests

      The following tests apply to MOODLE_23_STABLE and to master:

      • Navigate to Settings -> Site administration -> Appearance -> Media
        • Ensure that the YouTube and Vimeo options are ticked
      • Navigate to a course page
      • Turn editing on
      • Edit a section
      • Set the section Summary to: 

        <p><a href="http://www.youtube.com/v/1akyXgddyAY">Example YouTube</a></p>
        		 
        <p><a href="http://vimeo.com/1234567">Example Vimeo</a></p>
        		 
        <p><a href="http://www.youtube.com/playlist?list=PL9B6AC5E479B1B992">Example Playlist</a></p>

      • Save changes
        • Confirm that the Top video (YouTube) is displayed
        • Confirm that the Middle video (Vimeo) is displayed
        • Confirm that the Bottom video (YouTube Playlist) is displayed
        • View the source and confirm that each video is pointed at the correct (https) URL
      • Open the 'Activity Chooser'
        • Confirm that none of the videos sit in front of the activity chooser

      MOODLE_23_STABLE

      The following instructions are in addition to the tests above. Moodle 2.3 still has the XML Strict Headers setting which slightly changes the way that some videos are displayed:

      • Navigate to Site administration -> Development -> Debugging
      • Turn "XML strict headers" to on
      • View the course page again
        • Confirm that the Top video (YouTube) is displayed
        • Confirm that it is not in an iframe
        • Confirm that the Middle video (Vimeo) is displayed
        • Confirm that the Bottom video (YouTube Playlist) is displayed
      • Open the 'Activity Chooser'
        • Confirm that none of the videos sit in front of the activity chooser
      Show
      General tests The following tests apply to MOODLE_23_STABLE and to master: Navigate to Settings -> Site administration -> Appearance -> Media Ensure that the YouTube and Vimeo options are ticked Navigate to a course page Turn editing on Edit a section Set the section Summary to: <p><a href="http://www.youtube.com/v/1akyXgddyAY">Example YouTube</a></p> <p><a href="http://vimeo.com/1234567">Example Vimeo</a></p> <p><a href="http://www.youtube.com/playlist?list=PL9B6AC5E479B1B992">Example Playlist</a></p> Save changes Confirm that the Top video (YouTube) is displayed Confirm that the Middle video (Vimeo) is displayed Confirm that the Bottom video (YouTube Playlist) is displayed View the source and confirm that each video is pointed at the correct (https) URL Open the 'Activity Chooser' Confirm that none of the videos sit in front of the activity chooser MOODLE_23_STABLE The following instructions are in addition to the tests above. Moodle 2.3 still has the XML Strict Headers setting which slightly changes the way that some videos are displayed: Navigate to Site administration -> Development -> Debugging Turn "XML strict headers" to on View the course page again Confirm that the Top video (YouTube) is displayed Confirm that it is not in an iframe Confirm that the Middle video (Vimeo) is displayed Confirm that the Bottom video (YouTube Playlist) is displayed Open the 'Activity Chooser' Confirm that none of the videos sit in front of the activity chooser
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_23_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-28486-master-2
    • Pull Master Diff URL:

      Description

      IE will give insecure content warnings if youtube is used with http and the page is httpsed. Youtube support https embeding (see: http://apiblog.youtube.com/2011/02/https-support-for-youtube-embeds.html ), so we can support this.

      Other browsers also give similar warnings

        Attachments

          Issue Links

          is blocked by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28484 We do not have a function to detect if we are being served on https

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              dobedobedoh Andrew Nicols
              Reporter:
              poltawski Dan Poltawski
              Peer reviewer:
              Dan Poltawski
              Integrator:
              Sam Hemelryk
              Tester:
              Andrew Davis
              Participants:
              Component watchers:
              Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Sep/12