Patch to achieve this attached - but this depends on MDL-28484

Patch no longer works against 2.3 due to complete rewrite of multimedia filter.

Andrew: if you are interested in this patch, I was thinking we could change the youtube embeding to always use https. But I have not had time to look into if doing that gives IE 'mixed https' warnings and doesn't solve the problem. It seems like an integratable solution irrespective of linked issue.

I considered this too - it should be fine. Not sure whether vimeo does the same.

Following discussion in the developer chat, I'm going to convert both youtube and vimeo to be always https.
At present, it's not possible to reliably determine the current URL in a filter because the global $PAGE object shouldn't be accessed from a filter.

I've replaced all Vimeo and YouTube links with their SSL equivalents.

I've also replaced the YouTube playlist embedding with the iframe version as embed support for youtube playlists seems to be non-existent and I can't get the existing code to work under any circumstances.

I've also taken the opportunity to add a missing <span> around the iframe for youtube videos.

These fixes only affect 2.3 and master.

Thanks for taking this Andrew.

Some comments:

• Please could you put a brief mention of why we are forcing https in the commit message. I'm sure there will be some https haters, so worth putting the rationale in.
• The xml strict headers stuff is removed in master, so you'll need to correct the patch for that
• It'll be easier for us to integrate this if you state the range of browsers you've tested this change on.

cheers,
dan

Updated as per your request.

Tested with non-SSL moodle on:

• OS X Lion - Chrome 20
• OS X Lion - Opera 12
• OS X Lion - Safari 5.1
• OS X Lion - Safari 6
• OS X Lion - Firefox 13
• OS X Lion - Firefox 14
• Windows 7 - Chrome 20
• Windows 7 - IE9
• Windows 7 - Opera 11
• Windows 7 - Firefox 13

Tested with SSL moodle on:

• OS X Lion - Chrome 20
• OS X Lion - Opera 12
• OS X Lion - Safari 5.1
• OS X Lion - Safari 6
• OS X Lion - Firefox 13
• OS X Lion - Firefox 14
• Windows 7 - Chrome 20
• Windows 7 - IE9
• Windows 7 - Opera 11
• Windows 7 - Firefox 13

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Hi Andrew,

If possible could you please produce branches for the stable versions you'd like this to be backported to.
Looks to me like it would be well worth backporting, but I see there are conflicts when backporting.

Cheers
Sam

Hi Sam,

Apologies for that - the original change did cherry-pick cleanly into 2.3, but the xmlstrict change last week broke that and I forgot to create an appropriate branch.

This will revert back to the object embedding method rather than iframes if xmlstrictheaders is set for YouTube Videos only.

Sam Marshall: Adding you as a watcher to this issue as I know that you were interested in this.

The integration of this issue has been delayed to next week because the integration period is over (Monday, Tuesday) and testing must happen on Wednesday.

This change to a more rigid timeframe on each integration/testing cycle aims to produce a better and clear separation and organization of tasks for everybody. This is a bulk-automated message, so if you want to blame somebody/thing/where, don't do it here (use git instead) :-D :-P
Apologies for the inconvenience, this will be integrated next week. Thanks for your collaboration & ciao

Thanks Andrew, this has been integrated now

Failing, this has broken unit tests:

medialib_testcase::test_embed_url_other_formats
Failed asserting that false is true.

Have integrated a fix for that. I wonder if we could have a more intelligent test there, checking size etc.

Looks good on both 2.3 and master. Passing.

Fixed STOP Closed STOP Thanks STOP

Yay, imagination! Ciao