Moodle
  1. Moodle
  2. MDL-7068 META: SCORM 2004 compliance + issues
  3. MDL-28493

objectiveID in SCORM 2004 packages can be text/string type. Alter Database table prefix_scorm_seq_objective structure

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.2
    • Component/s: SCORM
    • Database:
      Any
    • Testing Instructions:
      Hide

      To reproduce this issue follow the steps(with debugging turned on) -
      1. Download the ADL SCORM Test packages CM-02a or CM-02b or CM-03a. You can download them from here - https://github.com/mayankgupta/moodle_scorm_test_harness/tree/master/ADL2004/LMSTestCourseZipPackages
      2. Add these SCORM package as activity inside a course.
      3. Fill in the instructions and save
      4. Check to make sure no debugging messages appear as mention in the description of this issue.

      NOTE: Many other errors are reported by this test package - this patch only addresses the issues mentioned.

      Show
      To reproduce this issue follow the steps(with debugging turned on) - 1. Download the ADL SCORM Test packages CM-02a or CM-02b or CM-03a. You can download them from here - https://github.com/mayankgupta/moodle_scorm_test_harness/tree/master/ADL2004/LMSTestCourseZipPackages 2. Add these SCORM package as activity inside a course. 3. Fill in the instructions and save 4. Check to make sure no debugging messages appear as mention in the description of this issue. NOTE: Many other errors are reported by this test package - this patch only addresses the issues mentioned.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-28493
    • Rank:
      1367

      Description

      SCORM 2004 Packages can have objectiveID's as text/string type and not necessary int.
      The ADL SCORM 2004 Test packages have objectiveID as a string value in the imsmanifest.xml file. The objectvieid field in prefix_scorm_seq_objective table has type bigint(10), due to which while adding objectiveid to the scorm_seq_objective table a dml_write_exception is thrown.
      The imsmanifest.xml file for test package CM-02a can be found here - https://github.com/mayankgupta/moodle_scorm_test_harness/blob/master/ADL2004/LMSTestCoursePackageSrc/LMSTestPackage_CM-02a/imsmanifest.xml

      To reproduce this issue follow the steps -
      1. Download the ADL SCORM Test packages CM-02a or CM-02b or CM-03a. You can download them from here - https://github.com/mayankgupta/moodle_scorm_test_harness/tree/master/ADL2004/LMSTestCourseZipPackages
      2. Add these SCORM package as activity inside a course.
      3. Fill in the instructions and save the
      4. You will come across the error - "Error writing to database"
      5. If you have debugging turned on you would get the following debug info

      Debug info: Incorrect integer value: 'obj1' for column 'objectiveid' at row 1
      INSERT INTO mdl_scorm_seq_objective (scoid,primaryobj,objectiveid,minnormalizedmeasure) VALUES(?,?,?,?)
      [array (
      0 => 88,
      1 => 0,
      2 => 'obj1',
      3 => 1,
      )]
      Stack trace:
      line 397 of \lib\dml\moodle_database.php: dml_write_exception thrown
      line 878 of \lib\dml\mysqli_native_moodle_database.php: call to moodle_database->query_end()
      line 920 of \lib\dml\mysqli_native_moodle_database.php: call to mysqli_native_moodle_database->insert_record_raw()
      line 590 of \mod\scorm\datamodels\scormlib.php: call to mysqli_native_moodle_database->insert_record()
      line 238 of \mod\scorm\locallib.php: call to scorm_parse_scorm()
      line 119 of \mod\scorm\lib.php: call to scorm_parse()
      line 410 of \course\modedit.php: call to scorm_add_instance()

        Issue Links

          Activity

          Mayank Gupta created issue -
          Mayank Gupta made changes -
          Field Original Value New Value
          Fix Version/s DEV backlog [ 10464 ]
          Dan Marsden made changes -
          Labels triaged
          Assignee Eloy Lafuente (stronk7) [ stronk7 ] Dan Marsden [ danmarsden ]
          Component/s Database SQL/XMLDB [ 10131 ]
          Dan Marsden made changes -
          Labels triaged SCORM_2004 triaged
          Dan Marsden made changes -
          Link This issue duplicates MDL-24475 [ MDL-24475 ]
          Dan Marsden made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/danmarsden/moodle/compare/master...master_MDL-28493
          Pull Master Branch master_MDL-28493
          Pull from Repository git://github.com/danmarsden/moodle.git
          Testing Instructions Create SCORM using one of the linked items in the description
          Dan Marsden made changes -
          Testing Instructions Create SCORM using one of the linked items in the description To reproduce this issue follow the steps(with debugging turned on) -
          1. Download the ADL SCORM Test packages CM-02a or CM-02b or CM-03a. You can download them from here - https://github.com/mayankgupta/moodle_scorm_test_harness/tree/master/ADL2004/LMSTestCourseZipPackages
          2. Add these SCORM package as activity inside a course.
          3. Fill in the instructions and save
          4. Check to make sure no debugging messages appear as mention in the description of this issue.
          Petr Škoda made changes -
          Currently in integration Yes
          Dan Marsden made changes -
          Link This issue blocks MDL-28295 [ MDL-28295 ]
          Sam Hemelryk made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator samhemelryk
          Sam Hemelryk made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Andrew Davis made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester andyjdavis
          Andrew Davis made changes -
          Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
          Petr Škoda made changes -
          Status Problem during testing [ 10007 ] Integration review in progress [ 10004 ]
          Petr Škoda made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Petr Škoda made changes -
          Fix Version/s 2.2 [ 10656 ]
          Fix Version/s DEV backlog [ 10464 ]
          David Mudrak made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester andyjdavis mudrd8mz
          David Mudrak made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Petr Škoda made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes
          Integration date 3/Aug/11
          Mayank Gupta made changes -
          Assignee Dan Marsden [ danmarsden ] Mayank Gupta [ mayank_gupta2005 ]
          Dan Marsden made changes -
          Assignee Mayank Gupta [ mayank_gupta2005 ] Dan Marsden [ danmarsden ]
          Dan Marsden made changes -
          Testing Instructions To reproduce this issue follow the steps(with debugging turned on) -
          1. Download the ADL SCORM Test packages CM-02a or CM-02b or CM-03a. You can download them from here - https://github.com/mayankgupta/moodle_scorm_test_harness/tree/master/ADL2004/LMSTestCourseZipPackages
          2. Add these SCORM package as activity inside a course.
          3. Fill in the instructions and save
          4. Check to make sure no debugging messages appear as mention in the description of this issue.
          To reproduce this issue follow the steps(with debugging turned on) -
          1. Download the ADL SCORM Test packages CM-02a or CM-02b or CM-03a. You can download them from here - https://github.com/mayankgupta/moodle_scorm_test_harness/tree/master/ADL2004/LMSTestCourseZipPackages
          2. Add these SCORM package as activity inside a course.
          3. Fill in the instructions and save
          4. Check to make sure no debugging messages appear as mention in the description of this issue.

          NOTE: Many other errors are reported by this test package - this patch only addresses the issues mentioned.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: