Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28497

Saving a comment in a review of a quiz attempt returns to the top of the page

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Reopened
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 1.9.12, 2.0.3
    • Fix Version/s: None
    • Component/s: Quiz
    • Labels:
    • Testing Instructions:
      Hide

      1) review a quiz attempt.
      2) click "Make a comment or override grade" for the last question of the quiz
      3) click save and allow the window to close

      Show
      1) review a quiz attempt. 2) click "Make a comment or override grade" for the last question of the quiz 3) click save and allow the window to close
    • Affected Branches:
      MOODLE_19_STABLE, MOODLE_20_STABLE

      Description

      When an instructor reviews a quiz attempt and makes a comment on one of the answers using the "Make a comment or override grade" link, saving the comment and returning to the quiz refreshes the review page, which repositions the scroll to the top of the page. It might be more user friendly if the page would return to the question being commented upon so that the reviewer could continue from that location. This could be accomplised by adding #question_id to the end of the url. In version 2.0, I thought it might be possible to pass an optional anchor to the lib/weblib.php close_window() function which could then first reposition the page by setting window.opener.location.hash = '#qid' before calling for the refresh. But I am not certain that this would be the cleanest solution.

      Steps to reproduce for people can can't be bothered to read the above paragraph:

      1. Go to https://qa.moodledemo.net/mod/quiz/review.php?attempt=1&cmid=30 logged in as teacher.
      2. In the navigation, click the '1' button to scroll down to the first question.
      3. Scroll down further, using the scroll-bar.
      4. On Q5, click 'Make comment or override grade'.
      5. Grade in the popup and click save.

      Expected result: when the page reloads, you can still see Q5.

      Acutal result: it scrolls up to Q1.

      Verified in Firefox.

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            acspike Aaron C Spike
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            2 Vote for this issue
            Watchers:
            6 Start watching this issue

              Dates

              Created:
              Updated: