Moodle

CSS typo in media filter stylesheet

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.0.5, 2.1.2
  • Component/s: Filters
  • Labels:

Description

In filter/mediaplugin/styles.css there is a semicolon outside the brace of this rule:

.mp3flowplayer_backgroundColor {color: #000000};

This affects the combined and minimised CSS when another file, in my case course/format/topics/styles.css, is concatenated, eg:

... margin-left:0.5em}.mp3flowplayer_backgroundColor{color:#000};.course-content
ul.topics{margin:0} ...

The effect is the ".course-content ul.topics

{margin:0}

" rule gets ignored by the browser. Removing the semicolon or moving it inside the brace solves the problem (after purging the caches).

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

Hi, Jonathon.

Thanks for reporting this and providing a solution.

We should be able to integrate this in forthcoming sprint.

Show
Michael de Raadt added a comment - Hi, Jonathon. Thanks for reporting this and providing a solution. We should be able to integrate this in forthcoming sprint.
Hide
Permalink
Rossiani Wijaya added a comment -

Patch looks great.

Thanks Raj.

Show
Rossiani Wijaya added a comment - Patch looks great. Thanks Raj.
Hide
Permalink
Rajesh Taneja added a comment -

Thanks for providing the patch Jonathon,
It's up for integration review

Show
Rajesh Taneja added a comment - Thanks for providing the patch Jonathon, It's up for integration review
Hide
Permalink
Sam Hemelryk added a comment -

Thanks guys this has been integrated now.

Show
Sam Hemelryk added a comment - Thanks guys this has been integrated now.
Hide
Permalink
Aparup Banerjee added a comment -

easy pass

Show
Aparup Banerjee added a comment - easy pass

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: