[MDL-28504] CSS typo in media filter stylesheet - Moodle Tracker

XML

Word

Printable

Details

Type: Bug
Status: Closed
Priority: Minor
Resolution: Fixed
Affects Version/s: 2.1
Fix Version/s: 2.0.5, 2.1.2
Component/s: Filters
Labels:
- patch
- triaged

Database:

Any
Testing Instructions:

Hide

Simple typo issue, no testing required.

Show
Simple typo issue, no testing required.
Difficulty:
Easy
Affected Branches:
MOODLE_21_STABLE
Fixed Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle.git
Pull Master Branch:
wip-mdl-28504
Pull Master Diff URL:
https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-28504

Description

In filter/mediaplugin/styles.css there is a semicolon outside the brace of this rule:

.mp3flowplayer_backgroundColor {color: #000000};

This affects the combined and minimised CSS when another file, in my case course/format/topics/styles.css, is concatenated, eg:

... margin-left:0.5em}.mp3flowplayer_backgroundColor{color:#000};.course-content

ul.topics{margin:0} ...

The effect is the ".course-content ul.topics

{margin:0}

" rule gets ignored by the browser. Removing the semicolon or moving it inside the brace solves the problem (after purging the caches).

Attachments

Activity

People

Assignee:: Rajesh Taneja

Reporter:: Jonathon Fowler

Peer reviewer:: Rossiani Wijaya

Integrator:: Sam Hemelryk

Tester:: Aparup Banerjee

Participants:: Aparup Banerjee, Jonathon Fowler, Michael de Raadt, Rajesh Taneja, Rossiani Wijaya, Sam Hemelryk

Component watchers:: Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)

Votes:: 0 Vote for this issue

Watchers:: 1 Start watching this issue

Dates

Created:: 28/Jul/11 9:33 PM

Updated:: 30/Sep/13 6:10 PM

Resolved:: 04/Aug/11 8:13 AM

Fix Release Date:: 10/Oct/11