Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28504

CSS typo in media filter stylesheet

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Filters
    • Labels:

      Description

      In filter/mediaplugin/styles.css there is a semicolon outside the brace of this rule:

      .mp3flowplayer_backgroundColor {color: #000000};

      This affects the combined and minimised CSS when another file, in my case course/format/topics/styles.css, is concatenated, eg:

      ... margin-left:0.5em}.mp3flowplayer_backgroundColor{color:#000};.course-content
      ul.topics{margin:0} ...

      The effect is the ".course-content ul.topics

      {margin:0}

      " rule gets ignored by the browser. Removing the semicolon or moving it inside the brace solves the problem (after purging the caches).

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Hi, Jonathon.

            Thanks for reporting this and providing a solution.

            We should be able to integrate this in forthcoming sprint.

            Show
            salvetore Michael de Raadt added a comment - Hi, Jonathon. Thanks for reporting this and providing a solution. We should be able to integrate this in forthcoming sprint.
            Hide
            rwijaya Rossiani Wijaya added a comment -

            Patch looks great.

            Thanks Raj.

            Show
            rwijaya Rossiani Wijaya added a comment - Patch looks great. Thanks Raj.
            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Thanks for providing the patch Jonathon,
            It's up for integration review

            Show
            rajeshtaneja Rajesh Taneja added a comment - Thanks for providing the patch Jonathon, It's up for integration review
            Hide
            samhemelryk Sam Hemelryk added a comment -

            Thanks guys this has been integrated now.

            Show
            samhemelryk Sam Hemelryk added a comment - Thanks guys this has been integrated now.
            Hide
            nebgor Aparup Banerjee added a comment -

            easy pass

            Show
            nebgor Aparup Banerjee added a comment - easy pass

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Oct/11