Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.0.4, 2.1.1, 2.2
-
Component/s: Repositories
-
Database:Any
-
Testing Instructions:
-
Difficulty:Easy
-
Affected Branches:MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_20_STABLE, MOODLE_21_STABLE
-
Pull from Repository:git@github.com:dongsheng/moodle.git
-
Pull Master Branch:s13_
MDL-28509_youtube_master -
Pull Master Diff URL:
-
Rank:18255
Description
When searching using the YouTube repository, the sorting is hard-coded to sort by Date Published. This is contrary to the default behaviour of YouTube which defaults to sorting by Relevance, and makes it harder to find relevant or particular videos when searching.
I appreciate that there is a use case for sorting by Date Published (e.g. if you've just uploaded a video yourself and want to find it), but I think the user should be able to specify the sort order, and that it should default to Relevance like YouTube does.
Issue Links
- has a non-specific relationship to
-
MDL-29345
Improve filepicker search dialog to support more options
-
- Closed
-
Activity
Looks good, Thanks Mark!
Submitting to integration.
Thanks! This has been integrated now!
While trying to search for another youtube video, I received 'ERROR: Invalid JSON string'.
To reproduce,
- with tinyMCE, select the YouTube repository.
- Perform search for a video, select any kind of filter and click search
- click 'search' button (pop up search should appear), search for a video, click submit
Invalid json string error appear.
Workaround for this is to click on refresh/youtube repository button then search for other video.
it's the youtube_sort parameter missing default value, I attached a patch to fix this.
Thanks for that DS. Rajesh has also seen that this is breaking file picker upload everywhere (no response after successful upload). so we'll either need to revert this or patch+test it quicky. (works fine after i reverted this commit (0638e55) on my local integration copy)
Thanks Ds for the patch. It fixed the 'invalid json error'.
However, the search result doesn't return the expected video.
To reproduce:
- with tinyMCE, select the YouTube repository.
- Perform search for a video, select any kind of filter and click search
- click 'search' button (pop up search should appear), search for a video, click submit
- click 'search' button again and type different keyword and submit (notice that the view list are similiar to the previous one)
I think this issue need more work to be done.
Test failed.
this has been reverted from integration. There seems to be issues related to sorting and the results obtained.
Change git repo to mine for fixing
Hi DS,
This gets my +1 on a peer-review.
The only thing I noted was that once I had run the first search if I then proceeded to click search at the top of the file manager again I could enter a new keyword to search but I could not change the sorting of the results like I could for the first search. Perhaps a new issue to fix that one, the workaround is of course to select a different repository and then select youtube again.
Cheers
Sam
Hi, Dongsheng.
I noticed this was hanging around in STABLE Sprint 12. It would be good to resolve this. It looks to be almost there.
new issue created to improve filepicker search dialog.
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao 
Thanks everyone! Fixes here have been integrated
This works great.
Test passed.
And this code has been spread to all Moodle git and cvs repositories. Many thanks! Closing.
Ciao
This fix adds a select box to the search form allowing selection of sorting by Relevance, Date Published, View Count or Rating, as allowed on the YouTube site.