Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28510

YouTube repository using wrong thumbnails

          Details

          • Testing Instructions:
            Hide

            With the YouTube repository enabled, in TinyMCE click the "Moodle Media" icon, then "Find or upload a sound, video or applet...". Search for a keyword, and verify that the thumbnails shown in the results are fully visible and a reasonable size for the layout of the page.

            Show
            With the YouTube repository enabled, in TinyMCE click the "Moodle Media" icon, then "Find or upload a sound, video or applet...". Search for a keyword, and verify that the thumbnails shown in the results are fully visible and a reasonable size for the layout of the page.
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE
          • Fixed Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE
          • Pull Master Branch:
          • Pull Master Diff URL:

            Description

            When displaying search results, the YouTube repository uses the first returned thumbnail, which is too large (240x320) for the search results listing and doesn't give a useful preview of the video. The YouTube.com search one of the other thumbnails, which is a smaller.

              Gliffy Diagrams

                Attachments

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  marxjohnson Mark Johnson added a comment -

                  This patch specifies the 3rd thumbnail be used, which is a smaller image that provides a better preview of the video and fits the layout of the search results.

                  Show
                  marxjohnson Mark Johnson added a comment - This patch specifies the 3rd thumbnail be used, which is a smaller image that provides a better preview of the video and fits the layout of the search results.
                  Hide
                  Permalink
                  dongsheng Dongsheng Cai added a comment -

                  Thanks Mark

                  We will integrate your patch next week

                  Regards,
                  Dongsheng

                  Show
                  dongsheng Dongsheng Cai added a comment - Thanks Mark We will integrate your patch next week Regards, Dongsheng
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks guys, this has been integrated now.
                  I merged 20, and 21 branches, however I cherry-picked master as there was an unusual merge on it.

                  Cheers
                  Sam

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated now. I merged 20, and 21 branches, however I cherry-picked master as there was an unusual merge on it. Cheers Sam
                  Hide
                  Permalink
                  rwijaya Rossiani Wijaya added a comment -

                  Tested and it works great.

                  Test passed.

                  Show
                  rwijaya Rossiani Wijaya added a comment - Tested and it works great. Test passed.

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      1 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        10/Oct/11