Moodle
  1. Moodle
  2. MDL-28517

hint header form elements have the wrong id in question type edit form.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Questions
    • Labels:
      None
    • Testing Instructions:
      Hide

      question types with hints where being output with html elements with id 'answerhdr'.
      use firebug to check the output ids in these elements are now 'hinthdr'

      Show
      question types with hints where being output with html elements with id 'answerhdr'. use firebug to check the output ids in these elements are now 'hinthdr'
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:
      mdl-28517
    • Rank:
      18266

      Description

      hint header form elements have the wrong id in question type edit form. Just a spelling change. from answer to hint.

        Activity

        Hide
        Colin Chambers added a comment -

        committed and pushed fix to https://github.com/colchambers/moodle. waiting for peer review.

        Show
        Colin Chambers added a comment - committed and pushed fix to https://github.com/colchambers/moodle . waiting for peer review.
        Hide
        Tim Hunt added a comment -

        Everything is great apart from two details that I did not explain yesterday:

        1. There is a standard for Moodle commit comments (that is not documented anywhere, grrr!). You need to change the commit comment to something like

        MDL-28517 question editing fixed duplicate id in hint header field

        (The rules are, start with the bug id, and try to make it clear from the first few words, which part of code this affects.)

        You can change the commit comment with git commit --amend.

        2. You need to add the branch name (mdl-28517), and the compare URL (https://github.com/colchambers/moodle/compare/master...mdl-28517) when you click the 'Submit for peer review' button.

        Thanks.

        Show
        Tim Hunt added a comment - Everything is great apart from two details that I did not explain yesterday: 1. There is a standard for Moodle commit comments (that is not documented anywhere, grrr!). You need to change the commit comment to something like MDL-28517 question editing fixed duplicate id in hint header field (The rules are, start with the bug id, and try to make it clear from the first few words, which part of code this affects.) You can change the commit comment with git commit --amend. 2. You need to add the branch name (mdl-28517), and the compare URL ( https://github.com/colchambers/moodle/compare/master...mdl-28517 ) when you click the 'Submit for peer review' button. Thanks.
        Hide
        Tim Hunt added a comment -

        Looks good to me. Thanks Colin.

        Show
        Tim Hunt added a comment - Looks good to me. Thanks Colin.
        Hide
        Sam Hemelryk added a comment -

        Thanks guys, this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks guys, this has been integrated now
        Hide
        Andrew Davis added a comment -

        test instructions are rather vague. I can find some elements called hinthdr. I'm guessing that is the desired behaviour...

        Show
        Andrew Davis added a comment - test instructions are rather vague. I can find some elements called hinthdr. I'm guessing that is the desired behaviour...
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Sent upstream and closing, many thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: