Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28520

repository_type_form missing validation method

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.2
    • Component/s: Repositories
    • Labels:
    • Testing Instructions:
      Hide

      Its not possible to test the functionality of this change as its adding something an API feature which is not used. However all repository plugins should be checked to ensure they continue to work without error.

      Show
      Its not possible to test the functionality of this change as its adding something an API feature which is not used. However all repository plugins should be checked to ensure they continue to work without error.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      Since there is no validation method in repository_type_form class, that could be used from the the plugin via designated method, there is no way to check the configuration form variables.

        Gliffy Diagrams

          Activity

          Hide
          kabalin Ruslan Kabalin added a comment -

          Using the patch, it is possible to define type_form_validation method in the repository plugin class and perform the required validation.

          Show
          kabalin Ruslan Kabalin added a comment - Using the patch, it is possible to define type_form_validation method in the repository plugin class and perform the required validation.
          Hide
          kabalin Ruslan Kabalin added a comment -
          Show
          kabalin Ruslan Kabalin added a comment - Once merged, http://docs.moodle.org/dev/Repository_plugins and http://docs.moodle.org/dev/Repository_API have to be updated accordingly.
          Hide
          poltawski Dan Poltawski added a comment -

          This can also be cherry-picked into 21_STABLE

          Show
          poltawski Dan Poltawski added a comment - This can also be cherry-picked into 21_STABLE
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Thanks guys, this has been integrated to master (only master as 21 is now truly stable).
          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - Thanks guys, this has been integrated to master (only master as 21 is now truly stable). Cheers Sam
          Hide
          nebgor Aparup Banerjee added a comment -

          tested with repository plugins.. enabling them @ admin/repository.php seems to work fine - no errors seen on that mform.

          Show
          nebgor Aparup Banerjee added a comment - tested with repository plugins.. enabling them @ admin/repository.php seems to work fine - no errors seen on that mform.
          Hide
          kabalin Ruslan Kabalin added a comment -

          Updated the wiki accordingly.

          Show
          kabalin Ruslan Kabalin added a comment - Updated the wiki accordingly.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/11