Moodle

repository_type_form missing validation method

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2
  • Component/s: Repositories
  • Labels:
  • Testing Instructions:
    Hide

    Its not possible to test the functionality of this change as its adding something an API feature which is not used. However all repository plugins should be checked to ensure they continue to work without error.

    Show
    Its not possible to test the functionality of this change as its adding something an API feature which is not used. However all repository plugins should be checked to ensure they continue to work without error.
  • Affected Branches:
    MOODLE_21_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

Since there is no validation method in repository_type_form class, that could be used from the the plugin via designated method, there is no way to check the configuration form variables.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Ruslan Kabalin added a comment -

Using the patch, it is possible to define type_form_validation method in the repository plugin class and perform the required validation.

Show
Ruslan Kabalin added a comment - Using the patch, it is possible to define type_form_validation method in the repository plugin class and perform the required validation.
Hide
Permalink
Ruslan Kabalin added a comment -

Once merged, http://docs.moodle.org/dev/Repository_plugins and http://docs.moodle.org/dev/Repository_API have to be updated accordingly.

Show
Ruslan Kabalin added a comment - Once merged, http://docs.moodle.org/dev/Repository_plugins and http://docs.moodle.org/dev/Repository_API have to be updated accordingly.
Hide
Permalink
Dan Poltawski added a comment -

This can also be cherry-picked into 21_STABLE

Show
Dan Poltawski added a comment - This can also be cherry-picked into 21_STABLE
Hide
Permalink
Sam Hemelryk added a comment -

Thanks guys, this has been integrated to master (only master as 21 is now truly stable).
Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks guys, this has been integrated to master (only master as 21 is now truly stable). Cheers Sam
Hide
Permalink
Aparup Banerjee added a comment -

tested with repository plugins.. enabling them @ admin/repository.php seems to work fine - no errors seen on that mform.

Show
Aparup Banerjee added a comment - tested with repository plugins.. enabling them @ admin/repository.php seems to work fine - no errors seen on that mform.
Hide
Permalink
Ruslan Kabalin added a comment -

Updated the wiki accordingly.

Show
Ruslan Kabalin added a comment - Updated the wiki accordingly.

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: