Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28533

verify where_clause() only in debug mode

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.3, 2.1
    • Fix Version/s: 2.1.2
    • Component/s: Database SQL/XMLDB
    • Labels:
    • Testing Instructions:
      Hide

      1/ enable perf info in page footer
      2/ compare queries per page with and without debugging enabled/disabled

      Expected result is 5-15 fewer read queries in most pages.

      Show
      1/ enable perf info in page footer 2/ compare queries per page with and without debugging enabled/disabled Expected result is 5-15 fewer read queries in most pages.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w31_MDL-28533_m22_columnperf
    • Pull Master Diff URL:

      Description

      The problem is that the current moodle_database->where_clase() does one extra DB query to fetch table columns. This is useful for developers only, for performance reasons it should be disabled on production sites...

        Attachments

          Issue Links

          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-24863 MS SQL DB driver casting string to int breaks a query that should work, which breaks qtype_multichoice upgrade

          • Blocker - Blocks development and/or testing, prevents Moodle from running (applicable to bugs only)
          • Closed

            Activity

              People

              Assignee:
              skodak Petr Skoda
              Reporter:
              skodak Petr Skoda
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Eloy Lafuente (stronk7)
              Participants:
              Component watchers:
              Andrew Nicols, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              2 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Oct/11