Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.2
    • Component/s: SCORM
    • Testing Instructions:
      Hide

      This is a pain to test - it must be done on a windows machine using the 2004 test harness. thanks to Mayank we should have a new automated Test harness that allows testing a bit easier very soon...

      but if you really want to test this despite the fact it's only going in head....

      download the CM-01 Test Package and ADL 2004 Test Suite
      run through the test and make sure this doesn't appear in the logs:
      ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: ""

      NOTE: there are still a range of other items causing the CM-01 to Fail - please see MDL-28740 for further detail.

      Show
      This is a pain to test - it must be done on a windows machine using the 2004 test harness. thanks to Mayank we should have a new automated Test harness that allows testing a bit easier very soon... but if you really want to test this despite the fact it's only going in head.... download the CM-01 Test Package and ADL 2004 Test Suite run through the test and make sure this doesn't appear in the logs: ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: "" NOTE: there are still a range of other items causing the CM-01 to Fail - please see MDL-28740 for further detail.
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-28541
    • Rank:
      1370

      Description

      The ADL SCORM 2004 CM-01 test failed for a range of issues including:

      • cmi.scaled_passing_score - In activity 2 the GetValue("cmi.scaled_passing_score") returned null, expected - 0.8

      If you want to execute test CM-01 you can download the CM-01 Test Package and ADL 2004 Test Suite

      =====DETAILED LOG======
      Start ADL LMS Test Content Package CM-01
      Testing Activity 1
      Activity 1 was launched as expected
      ERROR: Did the LMS provide a disabled UI device that corresponds to the Continue Navigation Event? - Expected: Yes - Answered: No
      ERROR: Did the LMS provide an enabled Table Of Contents that includes Activity 2 as selectable? - Expected: No - Answered: Yes
      Evaluating Initialize("") - Expected: "true" - LMS Returned: "true"
      Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
      ERROR: Evaluating GetValue("cmi.max_time_allowed") - Expected: "P5Y6M4DT12H30M58S" - LMS Returned: ""
      ERROR: Evaluating GetLastError("") - Expected: "0" - LMS Returned: "403"
      Evaluating SetValue("adl.nav.request", "continue") - Expected: "true" - LMS Returned: "true"
      Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
      Evaluating SetValue("cmi.exit", "normal") - Expected: "true" - LMS Returned: "true"
      Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
      Testing Activity 2
      Activity 2 was launched as expected
      Evaluating Initialize("") - Expected: "true" - LMS Returned: "true"
      Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
      ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: ""
      ERROR: Evaluating GetLastError("") - Expected: "0" - LMS Returned: "403"
      Evaluating SetValue("adl.nav.request", "continue") - Expected: "true" - LMS Returned: "true"
      Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
      Evaluating SetValue("cmi.exit", "normal") - Expected: "true" - LMS Returned: "true"
      Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
      Testing Activity 3
      ERROR: Expected Activity 3 - LMS Launched Activity 2

        Issue Links

          Activity

          Mayank Gupta created issue -
          Mayank Gupta made changes -
          Field Original Value New Value
          Fix Version/s DEV backlog [ 10464 ]
          Mayank Gupta made changes -
          Labels SCORM_2004
          Mayank Gupta made changes -
          Link This issue has been marked as being related by MDL-10707 [ MDL-10707 ]
          Hide
          Mayank Gupta added a comment - - edited

          [1] is a patch that fixes cmi.max_time_allowed - changing from $userdata->maxtimeallowed to $userdadta->attemptAbsoluteDurationLimit.
          This should fix - MDL-10707 as well.

          [1] - https://github.com/mayankgupta/moodle/commit/6a2b3cb

          I will be happy to modify it, if required.

          Thanks,
          Mayank.

          Show
          Mayank Gupta added a comment - - edited [1] is a patch that fixes cmi.max_time_allowed - changing from $userdata->maxtimeallowed to $userdadta->attemptAbsoluteDurationLimit. This should fix - MDL-10707 as well. [1] - https://github.com/mayankgupta/moodle/commit/6a2b3cb I will be happy to modify it, if required. Thanks, Mayank.
          Michael de Raadt made changes -
          Labels SCORM_2004 SCORM_2004 triaged
          Hide
          Dan Marsden added a comment -

          Hi Mayank - how are you going with the fix for cmi.scaled_passing_sco ?

          thanks,

          Dan

          Show
          Dan Marsden added a comment - Hi Mayank - how are you going with the fix for cmi.scaled_passing_sco ? thanks, Dan
          Hide
          Mayank Gupta added a comment -

          Hi Dan - I have added the code in mod/scorm/api.php to fetch the value of minnormalizedmeasure from the database table - scorm_seq_objective.
          Did not commit it, as thought of committing the fix for Activity 3 with this one.

          The patch [1] should fix cmi.scaled_passing_score

          [1] - https://github.com/mayankgupta/moodle/commit/2313993232a543802f534aed06d9d25a1e5e8384

          Thanks,
          Mayank

          Show
          Mayank Gupta added a comment - Hi Dan - I have added the code in mod/scorm/api.php to fetch the value of minnormalizedmeasure from the database table - scorm_seq_objective. Did not commit it, as thought of committing the fix for Activity 3 with this one. The patch [1] should fix cmi.scaled_passing_score [1] - https://github.com/mayankgupta/moodle/commit/2313993232a543802f534aed06d9d25a1e5e8384 Thanks, Mayank
          Dan Marsden made changes -
          Link This issue will help resolve MDL-28740 [ MDL-28740 ]
          Hide
          Dan Marsden added a comment -

          converting this bug to track only the patch for cmi.scaled_passing_score to get this patch in - all other CM-01 failures should be tracked on MDL-28740 - thanks!

          Show
          Dan Marsden added a comment - converting this bug to track only the patch for cmi.scaled_passing_score to get this patch in - all other CM-01 failures should be tracked on MDL-28740 - thanks!
          Dan Marsden made changes -
          Summary Test CM-01 failed due to UI Tests, cmi.max_time_allowed, cmi.scaled_passing_score and unable to launch Activity 3 cmi.scaled_passing_score not passed correctly
          Testing Instructions This is a pain to test - it must be done on a windows machine using the 2004 test harness. thanks to Mayank we should have a new automated Test harness that allows testing a bit easier very soon...

          but if you really want to test this despite the fact it's only going in head....

          download the [CM-01 Test Package|https://github.com/mayankgupta/moodle_scorm_test_harness/blob/master/ADL2004/LMSTestCourseZipPackages/LMSTestPackage_CM-01.zip?raw=true] and [ADL 2004 Test Suite|https://github.com/mayankgupta/moodle_scorm_test_harness/blob/master/ADL2004/TestSuite/SCORM.2004.4ED.TS.v1.1.1.zip?raw=true]
          run through the test and make sure this doesn't appear in the logs:
          ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: ""

          NOTE: there are still a range of other items causing the CM-01 to Fail - please see MDL-28740 for further detail.
          Description The ADL SCORM 2004 CM-01 test failed for following 4 issues -
          * UI Tests -
          ** In Activity 1 - the continue navigation event is not disabled.
          ** In Activity 1 - Activity 2 is selectable in Table of contents.
          * cmi.max_time_allowed - GetValue("cmi.max_time_allowed") returned null, expected - P5Y6M4DT12H30M58S
          * cmi.scaled_passing_score - In activity 2 the GetValue("cmi.scaled_passing_score") returned null, expected - 0.8
          * Activty 3 - Unable to launch activity 3.

          If you want to execute test CM-01 you can download the [CM-01 Test Package|https://github.com/mayankgupta/moodle_scorm_test_harness/blob/master/ADL2004/LMSTestCourseZipPackages/LMSTestPackage_CM-01.zip?raw=true] and [ADL 2004 Test Suite|https://github.com/mayankgupta/moodle_scorm_test_harness/blob/master/ADL2004/TestSuite/SCORM.2004.4ED.TS.v1.1.1.zip?raw=true]

          =====DETAILED LOG======
          Start ADL LMS Test Content Package CM-01
          Testing Activity 1
          Activity 1 was launched as expected
          ERROR: Did the LMS provide a disabled UI device that corresponds to the Continue Navigation Event? - Expected: Yes - Answered: No
          ERROR: Did the LMS provide an enabled Table Of Contents that includes Activity 2 as selectable? - Expected: No - Answered: Yes
          Evaluating Initialize("") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          ERROR: Evaluating GetValue("cmi.max_time_allowed") - Expected: "P5Y6M4DT12H30M58S" - LMS Returned: ""
          ERROR: Evaluating GetLastError("") - Expected: "0" - LMS Returned: "403"
          Evaluating SetValue("adl.nav.request", "continue") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          Evaluating SetValue("cmi.exit", "normal") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          Testing Activity 2
          Activity 2 was launched as expected
          Evaluating Initialize("") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: ""
          ERROR: Evaluating GetLastError("") - Expected: "0" - LMS Returned: "403"
          Evaluating SetValue("adl.nav.request", "continue") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          Evaluating SetValue("cmi.exit", "normal") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          Testing Activity 3
          ERROR: Expected Activity 3 - LMS Launched Activity 2
          The ADL SCORM 2004 CM-01 test failed for a range of issues including:

          * cmi.scaled_passing_score - In activity 2 the GetValue("cmi.scaled_passing_score") returned null, expected - 0.8

          If you want to execute test CM-01 you can download the [CM-01 Test Package|https://github.com/mayankgupta/moodle_scorm_test_harness/blob/master/ADL2004/LMSTestCourseZipPackages/LMSTestPackage_CM-01.zip?raw=true] and [ADL 2004 Test Suite|https://github.com/mayankgupta/moodle_scorm_test_harness/blob/master/ADL2004/TestSuite/SCORM.2004.4ED.TS.v1.1.1.zip?raw=true]

          =====DETAILED LOG======
          Start ADL LMS Test Content Package CM-01
          Testing Activity 1
          Activity 1 was launched as expected
          ERROR: Did the LMS provide a disabled UI device that corresponds to the Continue Navigation Event? - Expected: Yes - Answered: No
          ERROR: Did the LMS provide an enabled Table Of Contents that includes Activity 2 as selectable? - Expected: No - Answered: Yes
          Evaluating Initialize("") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          ERROR: Evaluating GetValue("cmi.max_time_allowed") - Expected: "P5Y6M4DT12H30M58S" - LMS Returned: ""
          ERROR: Evaluating GetLastError("") - Expected: "0" - LMS Returned: "403"
          Evaluating SetValue("adl.nav.request", "continue") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          Evaluating SetValue("cmi.exit", "normal") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          Testing Activity 2
          Activity 2 was launched as expected
          Evaluating Initialize("") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          ERROR: Evaluating GetValue("cmi.scaled_passing_score") - Expected: "0.8" - LMS Returned: ""
          ERROR: Evaluating GetLastError("") - Expected: "0" - LMS Returned: "403"
          Evaluating SetValue("adl.nav.request", "continue") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          Evaluating SetValue("cmi.exit", "normal") - Expected: "true" - LMS Returned: "true"
          Evaluating GetLastError("") - Expected: "0" - LMS Returned: "0"
          Testing Activity 3
          ERROR: Expected Activity 3 - LMS Launched Activity 2
          Dan Marsden made changes -
          Status Open [ 1 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/danmarsden/moodle/compare/master...master_MDL-28541
          Pull Master Branch master_MDL-28541
          Pull from Repository git://github.com/danmarsden/moodle.git
          Dan Marsden made changes -
          Link This issue blocks MDL-28933 [ MDL-28933 ]
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Currently in integration Yes
          Eloy Lafuente (stronk7) made changes -
          Fix Version/s 2.2 [ 10656 ]
          Fix Version/s DEV backlog [ 10464 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Aparup Banerjee made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester nebgor
          Eloy Lafuente (stronk7) made changes -
          Tester nebgor stronk7
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Passing this based in comments from Dan about it:

          [22:01:25] <dan.marsden> cool - I would pass MDL-28541 without bothering to test too much - it only affects SCORM 2004 (which we don't officially support anyway) and it's only going in master...and it only adds an extra param to be available to the scorm 2004 api. (as long as it meets coding guidelines etc)

          Show
          Eloy Lafuente (stronk7) added a comment - Passing this based in comments from Dan about it: [22:01:25] <dan.marsden> cool - I would pass MDL-28541 without bothering to test too much - it only affects SCORM 2004 (which we don't officially support anyway) and it's only going in master...and it only adds an extra param to be available to the scorm 2004 api. (as long as it meets coding guidelines etc)
          Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Eloy Lafuente (stronk7) made changes -
          Integration date 17/Aug/11
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Closing, this is now part of Moodle. Big thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Closing, this is now part of Moodle. Big thanks!
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes
          Mayank Gupta made changes -
          Assignee Dan Marsden [ danmarsden ] Mayank Gupta [ mayank_gupta2005 ]
          Dan Marsden made changes -
          Assignee Mayank Gupta [ mayank_gupta2005 ] Dan Marsden [ danmarsden ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: