Moodle
  1. Moodle
  2. MDL-28549

Add option to hide calendar from non-logged in users in Navigation block

        Details

        • Type: Improvement Improvement
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 2.1.2, 2.2
        • Fix Version/s: 2.1.3
        • Component/s: Calendar, Navigation
        • Labels:
        • Rank:
          18231

          Description

          It appears that entries in the calendar are not displayed to non-logged in users. For this class of user the Calendar link in the Navigation block is redundant.

          Suggestion: Remove calendar link from Navigation block for non-logged in users.

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Michael de Raadt added a comment -

            Agreed and I think this should be the default.

            Show
            Michael de Raadt added a comment - Agreed and I think this should be the default.
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Hi guys,

            After looking at this and having a think about I think that there is a missing isloggedin check here - it doesn't look like it needs a new setting, I'm confident that it is not meant to be there.

            I've put up a patch now to add the isloggedin check before adding the calendar link.

            Cheers
            Sam

            Show
            Sam Hemelryk added a comment - Hi guys, After looking at this and having a think about I think that there is a missing isloggedin check here - it doesn't look like it needs a new setting, I'm confident that it is not meant to be there. I've put up a patch now to add the isloggedin check before adding the calendar link. Cheers Sam
            Hide
            Permalink
            Sam Hemelryk added a comment -

            Just adding this patch isn't required to 20_STABLE.

            Show
            Sam Hemelryk added a comment - Just adding this patch isn't required to 20_STABLE.
            Hide
            Permalink
            Aparup Banerjee added a comment -

            Cool, this has been integrated.

            Show
            Aparup Banerjee added a comment - Cool, this has been integrated.
            Hide
            Permalink
            Rossiani Wijaya added a comment -

            This looks good.

            Thanks Sam for fixing it.

            Test passed.

            Show
            Rossiani Wijaya added a comment - This looks good. Thanks Sam for fixing it. Test passed.
            Hide
            Permalink
            Eloy Lafuente (stronk7) added a comment -

            Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

            Closing, ciao

            Show
            Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories. Closing, ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: