Details

    • Type: Task Task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.1
    • Fix Version/s: 2.2
    • Component/s: AJAX and JavaScript
    • Labels:
    • Rank:
      18238

      Description

      YUI 3.4.0 is to be released shortly.

        Issue Links

          Activity

          Martin Dougiamas created issue -
          Martin Dougiamas made changes -
          Field Original Value New Value
          Fix Version/s 2.2 [ 10656 ]
          Assignee Rajesh Taneja [ rajeshtaneja ] Petr Škoda (skodak) [ skodak ]
          Martin Dougiamas made changes -
          Link This issue blocks MDL-28553 [ MDL-28553 ]
          Martin Dougiamas made changes -
          Link This issue has a non-specific relationship to MDL-27225 [ MDL-27225 ]
          Martin Dougiamas made changes -
          Priority Minor [ 4 ] Critical [ 2 ]
          Michael de Raadt made changes -
          Labels triaged
          Hide
          Petr Škoda added a comment -

          The YUI 3.4.0 seems to be nearly ready for the release.

          Show
          Petr Škoda added a comment - The YUI 3.4.0 seems to be nearly ready for the release.
          Petr Škoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Petr Škoda made changes -
          Summary Upgrade to YUI 3.4.0 Upgrade to YUI 3.4.0 and 2.9.0
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w33_MDL-28554_m22_yui
          Pull Master Branch w33_MDL-28554_m22_yui
          Pull from Repository git://github.com/skodak/moodle.git
          Hide
          Petr Škoda added a comment -

          Some notes:
          1/ this seems to be surprisingly compatible with current code, so far I did not find any regression
          2/ I have spent a few hours studying the yui 2in3 today, I do not think we could start using that in the near future because it collides with our own yui2- prefix, we would hate to tweak all current yui2 code and remove the $PAGE->requires->yui2_lib; I personally think it might be best to continue with current yui2 hackery and drop the yui2 completely once we have the new treeview
          3/ I am going to work on more yui2->3 code conversion, ideally there should be no yui2_lib() PHP includes any more

          Show
          Petr Škoda added a comment - Some notes: 1/ this seems to be surprisingly compatible with current code, so far I did not find any regression 2/ I have spent a few hours studying the yui 2in3 today, I do not think we could start using that in the near future because it collides with our own yui2- prefix, we would hate to tweak all current yui2 code and remove the $PAGE->requires->yui2_lib; I personally think it might be best to continue with current yui2 hackery and drop the yui2 completely once we have the new treeview 3/ I am going to work on more yui2->3 code conversion, ideally there should be no yui2_lib() PHP includes any more
          Petr Škoda made changes -
          Priority Critical [ 2 ] Major [ 3 ]
          Petr Škoda made changes -
          Link This issue blocks MDL-28454 [ MDL-28454 ]
          Eloy Lafuente (stronk7) made changes -
          Currently in integration Yes
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Anything to test here? Some uses or so?

          Show
          Eloy Lafuente (stronk7) added a comment - Anything to test here? Some uses or so?
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Hide
          Petr Škoda added a comment -

          Everything needs to be tested, that is why I do not think we should put this into stable yet.

          Show
          Petr Škoda added a comment - Everything needs to be tested, that is why I do not think we should put this into stable yet.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Hide
          Rossiani Wijaya added a comment -

          The YUI upgrade breaks file upload in filepicker.

          I notice this error while testing MDL-27624 and I can't upload the scorm zip files or any other file types.

          Show
          Rossiani Wijaya added a comment - The YUI upgrade breaks file upload in filepicker. I notice this error while testing MDL-27624 and I can't upload the scorm zip files or any other file types.
          Hide
          Petr Škoda added a comment -

          filepicker should be fixed now

          Show
          Petr Škoda added a comment - filepicker should be fixed now
          Hide
          Rossiani Wijaya added a comment -

          Hi Petr,

          I updated my integration branch and purge all caches, and still can't upload a file through filepicker.

          To re-produce:

          1. create new scorm activity
          2. upload scorm file
          3. within filepicker, select "upload this file" button, filepicker stays on loading page.
          Show
          Rossiani Wijaya added a comment - Hi Petr, I updated my integration branch and purge all caches, and still can't upload a file through filepicker. To re-produce: create new scorm activity upload scorm file within filepicker, select "upload this file" button, filepicker stays on loading page.
          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          I can confirm this is still an issue as well.

          Although I am unsure as to the actual cause of the issue I can fix it by making a one line change within lib/yui/3.4.0/build/io-upload-frame/io-upload-frame-debug.js by adding the following before line 206 (of course you will need to force YUI into debug)

          o.c = o.c || {};
          

          The error being that o.c is undefined upon that function being called.

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, I can confirm this is still an issue as well. Although I am unsure as to the actual cause of the issue I can fix it by making a one line change within lib/yui/3.4.0/build/io-upload-frame/io-upload-frame-debug.js by adding the following before line 206 (of course you will need to force YUI into debug) o.c = o.c || {}; The error being that o.c is undefined upon that function being called. Cheers Sam
          Show
          Petr Škoda added a comment - http://yuilibrary.com/projects/yui3/ticket/2530999
          Hide
          Petr Škoda added a comment -

          workaround committed to integration, we do not use 'io' requirement any more in JS

          Show
          Petr Škoda added a comment - workaround committed to integration, we do not use 'io' requirement any more in JS
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Checking filepicker works here in order to pass this.

          Show
          Eloy Lafuente (stronk7) added a comment - Checking filepicker works here in order to pass this.
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tester stronk7
          Hide
          Eloy Lafuente (stronk7) added a comment -

          I've been playing a bit with editor, repo picker, upload file, enrolments UI, add attachments... and everything seems to continue working.

          Just 2 things to note:

          1) Seems that Safari now is less prone to unfinished uploads, it used to show the in progress icon forever a lot of times and now all the uploads I've performed had finished ok. Yay!
          2) While playing with the enrolments UI, I found some problems, but they don't seem to be related with new YUI version: MDL-29121

          So, passing this. Any new problems should go to new issues.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - I've been playing a bit with editor, repo picker, upload file, enrolments UI, add attachments... and everything seems to continue working. Just 2 things to note: 1) Seems that Safari now is less prone to unfinished uploads, it used to show the in progress icon forever a lot of times and now all the uploads I've performed had finished ok. Yay! 2) While playing with the enrolments UI, I found some problems, but they don't seem to be related with new YUI version: MDL-29121 So, passing this. Any new problems should go to new issues. Ciao
          Eloy Lafuente (stronk7) made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes
          Integration date 26/Aug/11
          Petr Škoda made changes -
          Link This issue has been marked as being related by MDL-29533 [ MDL-29533 ]
          Dan Marsden made changes -
          Link This issue caused a regression MDL-29159 [ MDL-29159 ]
          Martin Dougiamas made changes -
          Link This issue blocks MDL-28553 [ MDL-28553 ]
          Martin Dougiamas made changes -
          Link This issue blocks MDL-30160 [ MDL-30160 ]

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: