Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28561

Lines between RSS feed items are not showing in all themes

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.3.2, 2.4
    • Fix Version/s: 2.4.7, 2.5.3
    • Component/s: Themes
    • Labels:
    • Environment:
      CentOS, PHP 5.3.6, MySQL 5.1.57, Any Browser
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Note to Tester:
      Needs RSS Feeds setting up prior to testing.

      1. TEST that a line appears between feeds in all themes.
      Show
      Note to Tester: Needs RSS Feeds setting up prior to testing. TEST that a line appears between feeds in all themes.
    • Workaround:
      Hide

      Make sure every feed item is short so that they only take up one line each.

      Show
      Make sure every feed item is short so that they only take up one line each.
    • Affected Branches:
      MOODLE_23_STABLE, MOODLE_24_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE, MOODLE_25_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-28561_M26
    • Pull Master Diff URL:

      Description

      In the Standard Theme, lines show between the feed items in the RSS Feed Block. This is good.

      I want to use a different theme, in particular, Formal White. I have noticed that lines do not show between feed items, which makes this block's content difficult to read (see attached image.) I believe that lines between feed items should always show, unless they violate some important design aspect of the overall theme. I don't see this being the case for Formal White since lines are used to separate topics.

      Replication instructions:

      1. Add my feed (or any other) to the feed database. http://www.rjerz.com/c/opsmgt/Podcasts/OMU6K100.xml
      2. Add a RSS feed block, and pick the feed.
      3. Switch back and forth between Standard and Formal White. You should see the problem.

        Attachments

          Issue Links

          duplicates

          Improvement - An enhancement to an existing Moodle feature. MDL-41344 RSS block should clearly separate links in the clean theme.

          • Minor - Minor loss of function where workaround is possible
          • Closed
          has a non-specific relationship to

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-29367 Lines between RSS feed items are not showing in the Formal White, and other themes

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              lazydaisy Mary Evans
              Reporter:
              rjerz Rick Jerz
              Peer reviewer:
              Rossiani Wijaya Rossiani Wijaya
              Integrator:
              Dan Poltawski Dan Poltawski
              Tester:
              Rajesh Taneja Rajesh Taneja
              Participants:
              Component watchers:
              Huong Nguyen, Bas Brands, Mathew May
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                11/Nov/13