Moodle
  1. Moodle
  2. MDL-28566

Links in "user details" participant list appear inconsistently across themes

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Administration, Themes
    • Labels:
    • Environment:
      Win7, XAMPP, FF or Chrome
    • Testing Instructions:
      Hide

      1. Log in as admin
      2. Navigate to Site Administration -> Appearance -> Theme -> Theme selector.
      3. Click the button labelled "Select theme" in the default row
      4. Choose either Standard, Afterburner or Anomaly
      5. Navigate to Navigation -> Site pages -> Participants
      6. On the right, next to User list, choose User details

      The links on the right (to Blog, Notes, etc.) should each appear on a separate line.

      Show
      1. Log in as admin 2. Navigate to Site Administration -> Appearance -> Theme -> Theme selector. 3. Click the button labelled "Select theme" in the default row 4. Choose either Standard, Afterburner or Anomaly 5. Navigate to Navigation -> Site pages -> Participants 6. On the right, next to User list, choose User details The links on the right (to Blog, Notes, etc.) should each appear on a separate line.
    • Workaround:
      Hide

      For the theme in use, add the included CSS snippet to core.css.

      Be sure to purge caches afterwards.

      Show
      For the theme in use, add the included CSS snippet to core.css. Be sure to purge caches afterwards.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
    • Rank:
      18336

      Description

      When using some themes, such as Standard, Afterburner and Anomaly, the list of user links for each participant as a single continuous line of text, whereas with other themes, such as Arialist, the list is formatted nicely with one link per line. This happens when viewing the participants list with user details shown.

      I found that some themes control the display as "block" and some do not. The following CSS should probably be present in all themes...

      core.css
      .userinfobox .links a {
          display: block;
      }
      

      Replication instructions:

      1. Log in as admin
      2. Navigate to Site Administration -> Appearance -> Theme -> Theme selector.
      3. Click the button labelled "Select theme" in the default row
      4. Choose either Standard, Afterburner or Anomaly
      5. Navigate to Navigation -> Site pages -> Participants
      6. On the right, next to User list, choose User details

      There are other ways to get to this view. It is used in courses.

      1. Afterburner.png
        111 kB
      2. Anomaly.png
        107 kB
      3. Arialist.png
        120 kB
      4. Standard.png
        120 kB

        Activity

        Hide
        Martin Dougiamas added a comment -

        I heard a report from Jerome recently that all of the new themes are NOT inheriting properly from base and canvas. Could this be the problem? Surely it makes sense to have basic CSS like this in the base theme so that it's fixed in all themes.

        Show
        Martin Dougiamas added a comment - I heard a report from Jerome recently that all of the new themes are NOT inheriting properly from base and canvas. Could this be the problem? Surely it makes sense to have basic CSS like this in the base theme so that it's fixed in all themes.
        Hide
        Mary Evans added a comment -

        That was easy!

        Show
        Mary Evans added a comment - That was easy!
        Hide
        Michael de Raadt added a comment -

        Thanks Mary.

        Show
        Michael de Raadt added a comment - Thanks Mary.
        Hide
        Sam Hemelryk added a comment -

        Thanks Mary this has been integrated now

        Show
        Sam Hemelryk added a comment - Thanks Mary this has been integrated now
        Hide
        Sam Hemelryk added a comment -

        Nearly forgot to mention - in future Mary please don't add comments referencing the MDL issue number into the changes.
        We can always get that information from tracker, git, or web interfaces like cvs.moodle.org, git.moodle.org etc - mostly they are just adding content that needs to be removed and will likely be outdated next time someone changes that line again or revises code.

        Cheers
        Sam

        Show
        Sam Hemelryk added a comment - Nearly forgot to mention - in future Mary please don't add comments referencing the MDL issue number into the changes. We can always get that information from tracker, git, or web interfaces like cvs.moodle.org, git.moodle.org etc - mostly they are just adding content that needs to be removed and will likely be outdated next time someone changes that line again or revises code. Cheers Sam
        Hide
        Michael de Raadt added a comment -

        Test results: works a treat.

        Show
        Michael de Raadt added a comment - Test results: works a treat.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        git repositories have been updated with your awesome changes, thanks! Closing.

        Show
        Eloy Lafuente (stronk7) added a comment - git repositories have been updated with your awesome changes, thanks! Closing.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: