Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28567

Unnecessary redirect in calendar when changing current course

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.5.5, 2.6.2
    • Component/s: Calendar
    • Labels:
    • Testing Instructions:
      Hide
      1. Log in as an admin on a site with two courses at least
      2. Turn on calendar_adminseesall
      3. Turn on editing and edit the calendar block and set it to show throughout the entire site
      4. Browse two courses and in each add a course event to the calendar.
      5. On the front page calendar click on the Month link (February)
      6. You should see both events you created.
      7. Select one of the two courses in the course drop down.
      8. You should see only the event you created in the selected course.
      9. Select the other course in the course drop down.
      10. You should no longer see the event for the first course, and instead see the event for the second course.

      Also try changing current course in calendar day view and in upcoming events (link available in "upcoming events" block)

      Show
      Log in as an admin on a site with two courses at least Turn on calendar_adminseesall Turn on editing and edit the calendar block and set it to show throughout the entire site Browse two courses and in each add a course event to the calendar. On the front page calendar click on the Month link (February) You should see both events you created. Select one of the two courses in the course drop down. You should see only the event you created in the selected course. Select the other course in the course drop down. You should no longer see the event for the first course, and instead see the event for the second course. Also try changing current course in calendar day view and in upcoming events (link available in "upcoming events" block)
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_25_STABLE, MOODLE_26_STABLE
    • Pull Master Branch:
      28567-27
    • Pull Master Diff URL:

      Description

      while reviewing MDL-28407, I figured that calendar for course can't be selected.

      calendar/renderer.php

      $select = new single_select(new moodle_url(CALENDAR_URL.'set.php', array('return' => $returnurl, 'var' => 'setcourse')), 'id', $courseoptions, $selected, null);
      

      should actualy point to view.php

      calendar/renderer.php

      $select = new single_select(new moodle_url(CALENDAR_URL.'view.php', array('return' => $returnurl, 'view' => 'month')), 'course', $courseoptions, $selected, null);
      

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              samhemelryk Sam Hemelryk
              Reporter:
              rajeshtaneja Rajesh Taneja
              Peer reviewer:
              Ankit Agarwal Ankit Agarwal
              Integrator:
              Marina Glancy Marina Glancy
              Tester:
              Jérôme Mouneyrac Jérôme Mouneyrac
              Participants:
              Component watchers:
              Andrew Lyons, Dongsheng Cai, Huong Nguyen, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
              Votes:
              4 Vote for this issue
              Watchers:
              4 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Mar/14