Moodle

warning needed when sending message to non-contact but have 'do not receive messages from non-contacts' setting on.

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1
  • Fix Version/s: 2.2.5, 2.3.2
  • Component/s: Messages
  • Labels:
  • Testing Instructions:
    Hide

    For this test you'll need two users, user A and user B.

    1) User A should have 'Prevent non-contacts from messaging me' ticked in their messaging preferences.
    2) Go to user A's messages.
    3) If user B is a contact just click on their name to display their message history. If user B is not a contact, search for them and add them as a contact.
    4) There should be no warning above the new message box.
    5) Remove user B as a contact.
    6) You should now get a warning above the new message box telling you that the other user will not be able to reply.

    7) Log in as user B.
    8) View the message history with user A.
    9) You should get a warning saying that you cannot message user A and no new message box.

    Show
    For this test you'll need two users, user A and user B. 1) User A should have 'Prevent non-contacts from messaging me' ticked in their messaging preferences. 2) Go to user A's messages. 3) If user B is a contact just click on their name to display their message history. If user B is not a contact, search for them and add them as a contact. 4) There should be no warning above the new message box. 5) Remove user B as a contact. 6) You should now get a warning above the new message box telling you that the other user will not be able to reply. 7) Log in as user B. 8) View the message history with user A. 9) You should get a warning saying that you cannot message user A and no new message box.
  • Affected Branches:
    MOODLE_21_STABLE
  • Fixed Branches:
    MOODLE_22_STABLE, MOODLE_23_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-28568_noncontact_warning
  • Pull Master Diff URL:

Description

on moodle.org , i've received a msg from someone who obviously isn't very sure of whats going on in moodle.

He seems to have set his settings to no receive messages from non contacts.
He in turn has also sent me some messages a few times.

There should be a warning that explains there is no way for the messages recipient to reply. also how to turn it off if needed.

Issue Links

testing discovered

Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-34406 Does messaging need to check a capbility before displaying user full name's?

  • Major - Major loss of function, incorrect output
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Michael de Raadt added a comment -

A message such as...

'''Recipient unable to reply'''
The recipient of this message will not be able to reply because you have blocked messages from users who are not in your contact list".

...or perhaps just "You are a numbskull"

Show
Michael de Raadt added a comment - A message such as... '''Recipient unable to reply''' The recipient of this message will not be able to reply because you have blocked messages from users who are not in your contact list". ...or perhaps just "You are a numbskull"
Hide
Permalink
Aparup Banerjee added a comment -

lol, something along those lines Michael!

but we should never allow this state - it can be so confusing to a user.

Or perhaps we should simply deny (with a kinder 'numbskull' message) sending of message if any side (from or to ) has the other blocked.

Show
Aparup Banerjee added a comment - lol, something along those lines Michael! but we should never allow this state - it can be so confusing to a user. Or perhaps we should simply deny (with a kinder 'numbskull' message) sending of message if any side (from or to ) has the other blocked.
Hide
Permalink
Andrew Davis added a comment -

Adding a branch with a possible solution. It also includes a little bit of an enhancement to another warning the message page can display.

Show
Andrew Davis added a comment - Adding a branch with a possible solution. It also includes a little bit of an enhancement to another warning the message page can display.
Hide
Permalink
Andrew Davis added a comment -

Adding testing instructions and putting this up for peer review.

Show
Andrew Davis added a comment - Adding testing instructions and putting this up for peer review.
Hide
Permalink
Ankit Agarwal added a comment -

Hi Andrew,
The patch looks good. I have a few small queries:-

  1. fullname($user2), don't we need to make sure if the user has permission to view full names before doing that?
  2. array('id'=>'messagewarning') should be array('id' => 'messagewarning') (spaces)
  3. I am not sure but is $user1blocknoncontacts, okay as per our naming guidelines?
  4. you missed a "y" in "they" in the comment 'Otherwise they may wonder why the never get a reply'

Rest looks great.
Thanks

Show
Ankit Agarwal added a comment - Hi Andrew, The patch looks good. I have a few small queries:- fullname($user2), don't we need to make sure if the user has permission to view full names before doing that? array('id'=>'messagewarning') should be array('id' => 'messagewarning') (spaces) I am not sure but is $user1blocknoncontacts, okay as per our naming guidelines? you missed a "y" in "they" in the comment 'Otherwise they may wonder why the never get a reply' Rest looks great. Thanks
Hide
Permalink
Andrew Davis added a comment -

Ive fixed all of that with the exception of #1. Ive raised MDL-34406 to look into that. We use fullname(), possibly incorrectly, in a few places around the messaging system.

Show
Andrew Davis added a comment - Ive fixed all of that with the exception of #1. Ive raised MDL-34406 to look into that. We use fullname(), possibly incorrectly, in a few places around the messaging system.
Hide
Permalink
Andrew Davis added a comment -

Adding branches. I've put that new MDL in the next sprint. Putting this up for peer review again.

Show
Andrew Davis added a comment - Adding branches. I've put that new MDL in the next sprint. Putting this up for peer review again.
Hide
Permalink
Ankit Agarwal added a comment -

Hi Andrew,
Looks good to me.
Thanks

Show
Ankit Agarwal added a comment - Hi Andrew, Looks good to me. Thanks
Hide
Permalink
Andrew Davis added a comment -

Submitting for integration.

Show
Andrew Davis added a comment - Submitting for integration.
Hide
Permalink
Aparup Banerjee added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Aparup Banerjee added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Andrew, all looked spot on and has been integrated now

Show
Sam Hemelryk added a comment - Thanks Andrew, all looked spot on and has been integrated now
Hide
Permalink
Rajesh Taneja added a comment -

Works Great,

Thanks for fixing this Andrew.

Show
Rajesh Taneja added a comment - Works Great, Thanks for fixing this Andrew.
Hide
Permalink
Dan Poltawski added a comment -

asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ!

Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

Show
Dan Poltawski added a comment - asko, Дзякуй, ধন্যবাদ, Благодаря, Gràcies, 感谢, 謝謝, Hvala, Díky, Tak, Bedankt, Tänan, متشکریم, Salamat, Kiitokset, Merci, Grazas, Danke, Ευχαριστώ, આભાર, תודה, धन्यवाद, Köszönjük, Takk fyrir, Terima Kasih, Grazie, ありがとうございます, Рахмет, សូមអរគុណ, 감사합니다, gratiās, Pateicamies, Ačiū, Благодарам, Tēnā koa, Kia Ora Rawa Atu, आभारी आहोत, Талархал, Takk, Dziękuję, Obrigado, Mulţumesc, Engraziel, Спасибо, Fa'afetai, Хвала, Hvala, ස්තූතියි, Vďaka, Hvala, Mahadsanid, Thanks, Gracias, Tack, Salamat, நன்றி, నెనరులు, ขอบคุณค่ะ! Your work has made it into this weeks Moodle release! There are no gold medals available this week - but millions around the world will benefit. Thank you!

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: