Moodle
  1. Moodle
  2. MDL-28573

Checking an RSS feed updates my lastaccess and keeps my name on the Online Users block.

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.1
    • Fix Version/s: STABLE backlog
    • Component/s: RSS
    • Labels:
    • Testing Instructions:
      Hide

      Forum with RSS enabled. Discussions only.
      Any RSS reader using the Forum RSS link.

      Show
      Forum with RSS enabled. Discussions only. Any RSS reader using the Forum RSS link.
    • Affected Branches:
      MOODLE_21_STABLE
    • Rank:
      18256

      Description

      Setup: I have a forum on the site level of Moodle that is giving out an RSS feed of the discussion updates. I use it like a blog. On Facebook, I used the RSS feed link to setup an auto update feed check. So when I update the forum, it updates Facebook. The problem is that since the RSS link includes my user token, everytime Facebook checks for an update to the RSS feed, it updates my lastaccess (since it is using my token). This means I am ALWAYS showing in the Online Users block.

        Issue Links

          Activity

          Matthew Davidson created issue -
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting this.

          I've put it on our backlog and we'll try to get to it as soon as we can.

          Show
          Michael de Raadt added a comment - Thanks for reporting this. I've put it on our backlog and we'll try to get to it as soon as we can.
          Michael de Raadt made changes -
          Field Original Value New Value
          Fix Version/s STABLE backlog [ 10463 ]
          Labels triaged
          Hide
          Dan Poltawski added a comment -

          Hi Matthew,

          I think this is a forum specific problem, correct me if i'm wrong - so i'm going to assign to forum component

          Show
          Dan Poltawski added a comment - Hi Matthew, I think this is a forum specific problem, correct me if i'm wrong - so i'm going to assign to forum component
          Dan Poltawski made changes -
          Assignee Dan Poltawski [ poltawski ] moodle.com [ moodle.com ]
          Component/s Forum [ 10051 ]
          Hide
          Matthew Davidson added a comment -

          you are correct. I tested RSS in forum, database, and glossary.

          The problem with the lastaccess being updated happens with the forum. Another problem in forum RSS is that the RSS feed link doesn't show up. To get the RSS link I had to use other means of finding it.

          In glossary the RSS seems to be broken. It always gives me an RSS Error, no matter how many or what user adds terms into the glossary. The xml generated on this error doesn't update the lastaccess time, but an issue it does have is that it updates the publish date/time. This will cause it to always show up as a new feed item. Since this error occurs, I can't be 100% sure it doesn't update the lastaccess if it were to get past this error.

          The database RSS seems to be working as expected.

          Show
          Matthew Davidson added a comment - you are correct. I tested RSS in forum, database, and glossary. The problem with the lastaccess being updated happens with the forum. Another problem in forum RSS is that the RSS feed link doesn't show up. To get the RSS link I had to use other means of finding it. In glossary the RSS seems to be broken. It always gives me an RSS Error, no matter how many or what user adds terms into the glossary. The xml generated on this error doesn't update the lastaccess time, but an issue it does have is that it updates the publish date/time. This will cause it to always show up as a new feed item. Since this error occurs, I can't be 100% sure it doesn't update the lastaccess if it were to get past this error. The database RSS seems to be working as expected.
          Hide
          Andrew Davis added a comment -

          Since this issue was raised the RSS system has been heavily reworked. In particular, feeds are retrieved by a common system which calls require_login() meaning that accessing an RSS feed will now update the user's lastaccess regardless of which module is involved.

          That said, I'm not sure that this is really a problem. I understand how it is annoying in this particular situation but Facebook accessing the site as you is essentially you accessing the site...

          If we do add the ability to turn off the updating of lastaccess we need to make sure that the access is still logged. Otherwise, someone who has obtained an RSS URL could continue to quietly access that URL for ever after.

          Show
          Andrew Davis added a comment - Since this issue was raised the RSS system has been heavily reworked. In particular, feeds are retrieved by a common system which calls require_login() meaning that accessing an RSS feed will now update the user's lastaccess regardless of which module is involved. That said, I'm not sure that this is really a problem. I understand how it is annoying in this particular situation but Facebook accessing the site as you is essentially you accessing the site... If we do add the ability to turn off the updating of lastaccess we need to make sure that the access is still logged. Otherwise, someone who has obtained an RSS URL could continue to quietly access that URL for ever after.
          Andrew Davis made changes -
          Component/s Forum [ 10051 ]
          Andrew Davis made changes -
          Link This issue has a non-specific relationship to MDL-12223 [ MDL-12223 ]

            People

            • Votes:
              6 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

              • Created:
                Updated: