Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28575

formal_white does not highlight hardcoded (in config.php) $CFG settings

          Details

          • Type: Bug
          • Status: Closed
          • Priority: Minor
          • Resolution: Fixed
          • Affects Version/s: 2.0.4, 2.1.1, 2.2
          • Fix Version/s: 2.0.5, 2.1.2
          • Component/s: Themes
          • Labels:
          • Testing Instructions:
            Hide

            add, for instance,
            $CFG->themedesignermode = '1';
            and go to Site administration -> Appearance -> Themes -> Theme settings
            You should find "Defined in config.php" close to "Theme designer mode" written with a yellow background

            Show
            add, for instance, $CFG->themedesignermode = '1'; and go to Site administration -> Appearance -> Themes -> Theme settings You should find "Defined in config.php" close to "Theme designer mode" written with a yellow background
          • Affected Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
          • Fixed Branches:
            MOODLE_20_STABLE, MOODLE_21_STABLE
          • Pull from Repository:
          • Pull Master Branch:
            MDL-28575_master
          • Pull Master Diff URL:

            Gliffy Diagrams

              Attachments

                Issue Links

                has been marked as being related by

                Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28692 Some themes do not highlight forced-settings in the admin UI

                • Minor - Minor loss of function where workaround is possible
                • Closed

                  Activity

                  Ascending order - Click to sort in descending order
                  Hide
                  Permalink
                  lazydaisy Mary Evans added a comment -

                  Ciao Daniele,
                  Ho corretto un piccolo errore negli BRANCH URLs
                  Spero che questo è OK con voi?

                  Show
                  lazydaisy Mary Evans added a comment - Ciao Daniele, Ho corretto un piccolo errore negli BRANCH URLs Spero che questo è OK con voi?
                  Hide
                  Permalink
                  daniss Daniele Cordella added a comment - - edited

                  God bless you Mary. I am on the beach playing with my children and each submit is ALWAYS a problem.
                  Thanks, really thanks!

                  And thanks for your Italian too!

                  Show
                  daniss Daniele Cordella added a comment - - edited God bless you Mary. I am on the beach playing with my children and each submit is ALWAYS a problem. Thanks, really thanks! And thanks for your Italian too!
                  Hide
                  Permalink
                  samhemelryk Sam Hemelryk added a comment -

                  Thanks Daniele, this has been integrated now

                  Show
                  samhemelryk Sam Hemelryk added a comment - Thanks Daniele, this has been integrated now
                  Hide
                  Permalink
                  andyjdavis Andrew Davis added a comment -

                  Works as described.

                  Should "Defined in config.php" be highlighted in all of our themes? Its not highlighted in "Brick" at least so should I raise a new MDL to check all the themes?

                  Show
                  andyjdavis Andrew Davis added a comment - Works as described. Should "Defined in config.php" be highlighted in all of our themes? Its not highlighted in "Brick" at least so should I raise a new MDL to check all the themes?
                  Hide
                  Permalink
                  andyjdavis Andrew Davis added a comment -

                  Ive gone ahead and raised MDL-28692 to have the other themes checked.

                  Show
                  andyjdavis Andrew Davis added a comment - Ive gone ahead and raised MDL-28692 to have the other themes checked.
                  Hide
                  Permalink
                  stronk7 Eloy Lafuente (stronk7) added a comment -

                  Sent upstream and closing, many thanks!

                  Show
                  stronk7 Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!

                    People

                    • Votes:
                      0 Vote for this issue
                      Watchers:
                      0 Start watching this issue

                      Dates

                      • Created:
                        Updated:
                        Resolved:
                        Fix Release Date:
                        10/Oct/11