Moodle

Outline and complete reports dont work when accessed from system context so probably shouldnt be in the navigation tree

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.0.5, 2.1.2, 2.2
  • Fix Version/s: 2.0.6, 2.1.3
  • Component/s: Navigation
  • Labels:
  • Database:
    Any
  • Testing Instructions:
    Hide

    1. Log in as an admin
    2. Add a main menu block to the front page if there isn't already one.
    3. Make sure that there is nothing in the main menu block.
    4. Browse to Navigation > My profile > Activity reports > Outline report
    5. Make sure that you get a notification about nothing to display
    6. Add something to the main menu block
    7. Browse back to Navigation > My profile > Activity reports > Outline report
    8. Make sure you now get content in the report.

    Show
    1. Log in as an admin 2. Add a main menu block to the front page if there isn't already one. 3. Make sure that there is nothing in the main menu block. 4. Browse to Navigation > My profile > Activity reports > Outline report 5. Make sure that you get a notification about nothing to display 6. Add something to the main menu block 7. Browse back to Navigation > My profile > Activity reports > Outline report 8. Make sure you now get content in the report.
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    wip-MDL-28582-master
  • Pull Master Diff URL:

Description

When I access the outline report via My profile -> Activity reports -> Outline report I get taken to http://andrew.moodle.local/integrationmaster/course/user.php?user=2&id=1&mode=outline This displays a blank page. id 1 == system context I believe. The outline report is a course report so understandably doesnt work at system level.

We can either remove it from the nav tree or have the report provide a list of the user's courses for them to select from.

Issue Links

has a non-specific relationship to

Improvement - An enhancement to an existing Moodle feature. MDL-23626 Student activity report location in nav block is weird

  • Minor - Minor loss of function where workaround is possible
  • Closed - The issue is considered finished, the resolution is correct. Issues which are closed should not be reopened.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Andrew Davis added a comment -

Discovered while testing MDL-23626

Show
Andrew Davis added a comment - Discovered while testing MDL-23626
Hide
Permalink
Sam Hemelryk added a comment -

Hi Andrew,

Thanks for the report, after a bit of investigation I found that those reports may contain information if you have added any activities to the front page topic section or the main menu for the front page.
Because of this I haven't removed them from the navigation however I have added a nothing to display notice to the page now.

This is up for peer-review.

Cheers
Sam

Show
Sam Hemelryk added a comment - Hi Andrew, Thanks for the report, after a bit of investigation I found that those reports may contain information if you have added any activities to the front page topic section or the main menu for the front page. Because of this I haven't removed them from the navigation however I have added a nothing to display notice to the page now. This is up for peer-review. Cheers Sam
Hide
Permalink
Sam Hemelryk added a comment -

Putting this up for integration now

Show
Sam Hemelryk added a comment - Putting this up for integration now
Hide
Permalink
Aparup Banerjee added a comment -

Integrated and up for testing

Show
Aparup Banerjee added a comment - Integrated and up for testing
Hide
Permalink
Rossiani Wijaya added a comment -

This is working great.

Test passed.

Show
Rossiani Wijaya added a comment - This is working great. Test passed.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories.

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work developing and testing this. It has been spread to cvs and git upstream repositories. Closing, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: