Moodle
  1. Moodle
  2. MDL-28593

Unlocking a grade items is causing Moodle to die

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Backup, Gradebook
    • Labels:
    • Environment:
      PHP Version 5.3.6, MySQL 5.1.57
    • Database:
      MySQL
    • Testing Instructions:
      Hide

      Try locking, then unlocking a quiz grade item when viewing grade categories.

      Show
      Try locking, then unlocking a quiz grade item when viewing grade categories.
    • Workaround:
      Hide

      After getting the problem, log back into the course and go back into grade category items. The item really does get unlocked. But having to log back in for each item takes very long.

      I did try using the the browser's back button, refreshed the page, and it shows the item unlocked. This is a little faster.

      Show
      After getting the problem, log back into the course and go back into grade category items. The item really does get unlocked. But having to log back in for each item takes very long. I did try using the the browser's back button, refreshed the page, and it shows the item unlocked. This is a little faster.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
    • Rank:
      18364

      Description

      I imported a 1.9.12 course into 2.1. I was going through the grade book categories and items and started to unlock some of the grade book items. In Safari, after clicking the unlock icon, a blank screen appears. Refreshing the browser doesn't help. I am attaching a picture of how my gradebook looks and a "locked" item.

      When I re-enter the course and go to the grade book categories, I notice that the item that I tried to unlock is indeed unlocked. (This is a very slow workaround).

      I tried in Chrome, and got a message back (see attachment). Maybe this will help someone solve this problem.

      Firefox does the same thing as Safari, Moodle just dies with a blank screen.

      By the way, this never happens in my 1.9.12 Moodle installation on the same server.

        Issue Links

          Activity

          Hide
          Michael de Raadt added a comment -

          Hi, Rick.

          Thanks for reporting this.

          Have you tried to create new Gradebook items and locking them? It would be good to know if this is a problem with the Gradebook or the result of the restore not functioning properly. If you do encounter the problem in new grade items, please supply replication steps. If it seems to be a problem in the restore, bump the Security level of this bug up to Minor and attach your backup so we can try to see what's going wrong there.

          Show
          Michael de Raadt added a comment - Hi, Rick. Thanks for reporting this. Have you tried to create new Gradebook items and locking them? It would be good to know if this is a problem with the Gradebook or the result of the restore not functioning properly. If you do encounter the problem in new grade items, please supply replication steps. If it seems to be a problem in the restore, bump the Security level of this bug up to Minor and attach your backup so we can try to see what's going wrong there.
          Hide
          Andrew Davis added a comment - - edited

          Hello Rick. Is it practical for you to turn on error reporting on this site? Here are the instructions on how to do that. http://docs.moodle.org/20/en/Debugging#How_to_turn_on_debugging

          That would be great if you're able to do that and see if you get a more informative error message.

          Show
          Andrew Davis added a comment - - edited Hello Rick. Is it practical for you to turn on error reporting on this site? Here are the instructions on how to do that. http://docs.moodle.org/20/en/Debugging#How_to_turn_on_debugging That would be great if you're able to do that and see if you get a more informative error message.
          Hide
          Rick Jerz added a comment -

          Hi Michael and Andrew, I have more information to share with you.

          By experimenting, I discovered that this problem only occurs with "Quiz" grade items, not with Forum, Assignment or general grade items (items added directly, such as an Attendance item. The problem occurs in newly created courses, or imported courses.

          I did turn on debugging, and here's the message:

          Fatal error: Class 'mod_quiz_display_options' not found in /home/rjerz-vs/public_html/moodle2/mod/quiz/lib.php on line 615

          Along the way, I discovered that when a quiz is created, there is no dialog box that allows me to put this into a specific category. I don't know why. I will look around and maybe post another "bug" tracker item.

          Show
          Rick Jerz added a comment - Hi Michael and Andrew, I have more information to share with you. By experimenting, I discovered that this problem only occurs with "Quiz" grade items, not with Forum, Assignment or general grade items (items added directly, such as an Attendance item. The problem occurs in newly created courses, or imported courses. I did turn on debugging, and here's the message: Fatal error: Class 'mod_quiz_display_options' not found in /home/rjerz-vs/public_html/moodle2/mod/quiz/lib.php on line 615 Along the way, I discovered that when a quiz is created, there is no dialog box that allows me to put this into a specific category. I don't know why. I will look around and maybe post another "bug" tracker item.
          Hide
          Andrew Davis added a comment -

          I've added Tim Hunt as he is the master of all things quiz just in case he has any thoughts.

          Show
          Andrew Davis added a comment - I've added Tim Hunt as he is the master of all things quiz just in case he has any thoughts.
          Hide
          Tim Hunt added a comment -

          The missing 'Grade category' option on the quiz settings form is already reported as a separate bug.

          I guess there is just a missing include here. I'll fix it.

          Show
          Tim Hunt added a comment - The missing 'Grade category' option on the quiz settings form is already reported as a separate bug. I guess there is just a missing include here. I'll fix it.
          Hide
          Rick Jerz added a comment -

          I just installed the latest 2.1 (Moodle 2.1.1+ (Build: 20110803)), and this problem is still present.

          In debug mode, here is the error.
          Fatal error: Class 'mod_quiz_display_options' not found in /home/rjerz-vs/public_html/moodle2/mod/quiz/lib.php on line 615

          I made a short video to show you this problem.
          http://www.rjerz.com/v/misc/moodle_2_unlock_problem/moodle_2_unlock_problem.html

          Remember, this problem only happens to "Quiz" items in the grade book.

          Show
          Rick Jerz added a comment - I just installed the latest 2.1 (Moodle 2.1.1+ (Build: 20110803)), and this problem is still present. In debug mode, here is the error. Fatal error: Class 'mod_quiz_display_options' not found in /home/rjerz-vs/public_html/moodle2/mod/quiz/lib.php on line 615 I made a short video to show you this problem. http://www.rjerz.com/v/misc/moodle_2_unlock_problem/moodle_2_unlock_problem.html Remember, this problem only happens to "Quiz" items in the grade book.
          Hide
          Tim Hunt added a comment -

          Rick, that is not surprising. Look at the status of this issue: Status: Waiting for integration review. Resolution: Unresolved.

          Next week the issue will go through integration review and testing, and then, all being well, the fix will be included in the Moodle 2.1.1+ weekly build.

          Show
          Tim Hunt added a comment - Rick, that is not surprising. Look at the status of this issue: Status: Waiting for integration review. Resolution: Unresolved. Next week the issue will go through integration review and testing, and then, all being well, the fix will be included in the Moodle 2.1.1+ weekly build.
          Hide
          Rick Jerz added a comment -

          Tim, thanks. I am still getting used to the tracking system. I'll wait.

          Show
          Rick Jerz added a comment - Tim, thanks. I am still getting used to the tracking system. I'll wait.
          Hide
          Sam Hemelryk added a comment -

          Thanks Tim, this has been integrated now

          Show
          Sam Hemelryk added a comment - Thanks Tim, this has been integrated now
          Hide
          Andrew Davis added a comment -

          Locking and unlocking quiz grade items now seems to work as expected.

          Show
          Andrew Davis added a comment - Locking and unlocking quiz grade items now seems to work as expected.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Sent upstream and closing, many thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!
          Hide
          Rick Jerz added a comment -

          Eloy (and others),

          I hate to bother you with an administrative question, but I was the one who started this tracker item.

          I am trying to find the "road map" of how tracker items are tracked, but I can't seem to find it. For example, I have watch the "Status" progress on this item, but was never sure how many more steps were involved. I notice that this item has been fixed, and its status is "Closed". Does this mean that it is now in the current download of Moodle 2.1+?

          I really have appreciated everyone's attention to this issue, and am very impressed with the overall tracker system. Keep up the good work. This is what makes Moodle better than the other LMSs.

          Show
          Rick Jerz added a comment - Eloy (and others), I hate to bother you with an administrative question, but I was the one who started this tracker item. I am trying to find the "road map" of how tracker items are tracked, but I can't seem to find it. For example, I have watch the "Status" progress on this item, but was never sure how many more steps were involved. I notice that this item has been fixed, and its status is "Closed". Does this mean that it is now in the current download of Moodle 2.1+? I really have appreciated everyone's attention to this issue, and am very impressed with the overall tracker system. Keep up the good work. This is what makes Moodle better than the other LMSs.
          Hide
          Tim Hunt added a comment -

          http://docs.moodle.org/dev/Process should explain.

          Closed means it that it is now in 2.1.1+ (and also in the development version that will become 2.2)

          Show
          Tim Hunt added a comment - http://docs.moodle.org/dev/Process should explain. Closed means it that it is now in 2.1.1+ (and also in the development version that will become 2.2)

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: