Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28596

Improve and modernise the production of module editing icons

    Details

    • Type: Task
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: Navigation
    • Labels:

      Description

      Title says it all

        Gliffy Diagrams

          Activity

          Hide
          salvetore Michael de Raadt added a comment -

          I'm sure more details wouldn't hurt.

          Show
          salvetore Michael de Raadt added a comment - I'm sure more details wouldn't hurt.
          Hide
          samhemelryk Sam Hemelryk added a comment -

          I've attached a branch that does the following two things:

          1. Improves and modernises the production of module editing icons
          2. Added support for renderable objects as the content of action_link components.

          This code doesn't at all change the look or feel of the module editing icons however it will aid in future issues to improve the layout and positioning of these icons and aid any future efforts to convert to course renderers.

          Cheers
          Sam

          Show
          samhemelryk Sam Hemelryk added a comment - I've attached a branch that does the following two things: Improves and modernises the production of module editing icons Added support for renderable objects as the content of action_link components. This code doesn't at all change the look or feel of the module editing icons however it will aid in future issues to improve the layout and positioning of these icons and aid any future efforts to convert to course renderers. Cheers Sam
          Hide
          samhemelryk Sam Hemelryk added a comment -

          Peer-reviewer if you are happy with this please put it up for integration.

          Integrator feel free to cherry-pick, squash, whatever you want.

          Cheers fella's

          Show
          samhemelryk Sam Hemelryk added a comment - Peer-reviewer if you are happy with this please put it up for integration. Integrator feel free to cherry-pick, squash, whatever you want. Cheers fella's
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          I got a bit lost with the changes-diff, but everything seems to be in place. Nice one. Integrated, thanks!

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - I got a bit lost with the changes-diff, but everything seems to be in place. Nice one. Integrated, thanks!
          Hide
          rajeshtaneja Rajesh Taneja added a comment -

          Works Great
          Thanks for fixing this Sam.

          Show
          rajeshtaneja Rajesh Taneja added a comment - Works Great Thanks for fixing this Sam.
          Hide
          stronk7 Eloy Lafuente (stronk7) added a comment -

          git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay!

          Closing, ciao

          Show
          stronk7 Eloy Lafuente (stronk7) added a comment - git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay! Closing, ciao

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                5/Dec/11