Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28604

Question bank display forgets sort order

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Questions, Quiz
    • Labels:
      None
    • Testing Instructions:
      Hide

      Test both the stand-alone question bank UI, and the question bank UI embedded in the quiz editing.

      Perform various editing actions, e.g.
      a. create question
      b. edit question
      c. delete question
      d. add question to quiz

      both before and after setting a manual sort-order on the question bank, and ensure the system correctly tracks the sort order.

      Show
      Test both the stand-alone question bank UI, and the question bank UI embedded in the quiz editing. Perform various editing actions, e.g. a. create question b. edit question c. delete question d. add question to quiz both before and after setting a manual sort-order on the question bank, and ensure the system correctly tracks the sort order.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:

      Description

      The URL params used to track the sort order changed in Moodle 2.0, but the question_edit_setup function was not updated.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            colchambers Colin Chambers added a comment -

            all seems fine. Just wondering what the deprecated variables ($sortorder, $sortorderdecoded) were required for? they don't seem to be replaced in the new design. So are they handling a use case that is still required? is that use case catered for.

            Show
            colchambers Colin Chambers added a comment - all seems fine. Just wondering what the deprecated variables ($sortorder, $sortorderdecoded) were required for? they don't seem to be replaced in the new design. So are they handling a use case that is still required? is that use case catered for.
            Hide
            timhunt Tim Hunt added a comment -

            Thanks for the review Colin.

            Those old variables are what was used in Moodle 1.9. They should have been removed long ago.

            Show
            timhunt Tim Hunt added a comment - Thanks for the review Colin. Those old variables are what was used in Moodle 1.9. They should have been removed long ago.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            That way to get sorting params surprised me a bit but I'm sure what/how you are handling them.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks! That way to get sorting params surprised me a bit but I'm sure what/how you are handling them.
            Hide
            timhunt Tim Hunt added a comment -

            Yes. it is a big ugly, but I decided that now was not the time to try to sort out that bit of the code.

            Show
            timhunt Tim Hunt added a comment - Yes. it is a big ugly, but I decided that now was not the time to try to sort out that bit of the code.
            Hide
            andyjdavis Andrew Davis added a comment -

            I've raised MDL-28693. I encountered it while trying to sort my questions. Couldn't find another open issue with that error message.

            Show
            andyjdavis Andrew Davis added a comment - I've raised MDL-28693 . I encountered it while trying to sort my questions. Couldn't find another open issue with that error message.
            Hide
            andyjdavis Andrew Davis added a comment -

            Sort order now seems to work reliably

            Show
            andyjdavis Andrew Davis added a comment - Sort order now seems to work reliably
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Sent upstream and closing, many thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Sent upstream and closing, many thanks!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Oct/11