Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.1, 2.2
-
Fix Version/s: 2.1.2
-
Component/s: Unit tests
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
Description
I have a little script that runs all of the simple tests in moodle from the command line.
There is an issue in a few of the simple tests where admin/generator.php is included (but not used). When admin/generator.php is included and the simple test is run from the command line the admin/generator.php script takes control and asks the user for input, then die()'s because it wasn't passed any params or args.
I have fixed this by removing the include of admin/generator.php from the following simple tests
lib/simpletest/portfolio_testclass.php
lib/simpletest/testrepositorylib.php
mod/assignment/simpletest/test_assignment_portfolio_callers.php
mod/chat/simpletest/test_chat_portfolio_callers.php
mod/data/simpletest/test_data_portfolio_callers.php
mod/forum/simpletest/test_forum_portfolio_callers.php
mod/glossary/simpletest/test_glossary_portfolio_callers.php
portfolio/boxnet/simpletest/testportfoliopluginboxnet.php
To test that this fix hasn't broken anything I removed the include from the simple tests and made sure that the same number of tests where run and all of tests still passed.