Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28655

Incorrect type of return value in qtype_calculated_qe2_attempt_updater

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Questions
    • Labels:

      Description

      Hello Tim

      while debugging my 1.9 -> 2.1 data migration, I noticed that under certain circumstances, qtype_calculated_qe2_attempt_updater::parse_response() returns an incorrect datatype (empty string, where an array of two strings is expected).

      This probably has no functional impact, however in debug mode it leads to numerous warning messages being triggered in the first line of response_summary() (same class). I found that a bit annoying, so I though I'd share it.

      The fix is trivial, see patch.

        Attachments

          Activity

            People

            Assignee:
            timhunt Tim Hunt
            Reporter:
            bostelm Henning Bostelmann
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Rajesh Taneja
            Participants:
            Component watchers:
            Tim Hunt, Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Oct/11