Details
-
Type:
Bug
-
Status: Closed
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: 2.1.1, 2.2
-
Fix Version/s: 2.1.2
-
Component/s: Questions
-
Labels:
-
Testing Instructions:
-
Affected Branches:MOODLE_21_STABLE, MOODLE_22_STABLE
-
Fixed Branches:MOODLE_21_STABLE
-
Pull from Repository:
-
Pull Master Branch:
-
Pull Master Diff URL:
-
Rank:18475
Description
Sorry, I need to file another question-related problem. Not sure whether this is only related to data migration.
When a quiz attempt contains a deleted question, viewing the quiz attempt (mod/quiz/review.php) fails with an error message as below. The remainder of the page is not shown.
Category ID is invalid
More information about this error
Stack trace:
- line 429 of /lib/setuplib.php: moodle_exception thrown
- line 1349 of /lib/questionlib.php: call to print_error()
- line 696 of /mod/quiz/attemptlib.php: call to question_has_capability_on()
- line 951 of /mod/quiz/attemptlib.php: call to quiz_attempt->get_display_options_with_edit_link()
- line 182 of /mod/quiz/renderer.php: call to quiz_attempt->render_question()
- line 54 of /mod/quiz/renderer.php: call to mod_quiz_renderer->questions()
- line 259 of /mod/quiz/review.php: call to mod_quiz_renderer->review_page()
This comes about as follows. In qtype_missingtype::make_deleted_instance(), the category id of the "fake" question is set to NULL. However, in lib/questionlib.php, function question_has_capability_on(), the question is tested on having a valid category. None is found, so an error is encountered.
So far, I was able to reproduce this with migrated data only. Is Moodle 2.1 expected to deal with "deleted questions" or is this a problem of the migration process?
Activity
This modification fixes it for me. Users will not have any capabilities on deleted questions, which seems consistent.
Thanks Rossi for starting the review of this. I will take it from here.
No worries Tim.
All yours. 
Hi Henning,
Thanks for providing the patch to address the issue.
Could you also provide some testing instructions to test this issue?
Two problems with the patch:
1. You get simpler code by inserting the new code after the existing if (!is_object($question)) { block.
2. In general, don't pollute the code with references to bug numbers. All that information is automatically tracked by git. On the other hand, the situation that makes this new code necessary is quite obscure, so a comment that explains why it is needed is a good idea.
I am about to submit a revised fix for integration.
Henning, if you could test my revised fix, that would be helpful. Thanks.
Thanks Tim. I have now tested this with my "real life" data on the MOODLE_21_STABLE branch (or rather your branch MDL-28687_21). It fixes the problem for me.
Great! Thanks for the confirmation. And I am impressed by the speed!
The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.
TIA and ciao
just checking: is this to be fixed in 2.0.x as well?
No, it's related to the new Question Engine only, which was introduced in 2.1.
Thanks! This has been integrated!
works great.
Test passed
Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.
It is probably a migration only issues - or at least a 'result of an earlier bug'-only issue.
I suggest we add an if (!emtpy($question->categoryid) somewhere. If this is a fake placeholder for a deleted question, there is no point offering an edit link.