Moodle
  1. Moodle
  2. MDL-28708

Performance: Add support for 304 response in filelib

    Details

    • Rank:
      18498

      Description

      Currently there is not possiblity for a browser sending If-Modified-Since requests based on the expires / cache-control headers to receive a 304 Not Modified response from the server, so we must wait for this data transfer even if the intention was just to validate cache.

      This patch allows Moodle to return a 304 response when the If-Modified-Since check passes.

      This reduces traffic for e.g pages with many uploaded images (pluginfile.php) displayed.

      (github links incoming)

        Issue Links

          Activity

          Show
          Tony Levi added a comment - MOODLE_20_STABLE: https://github.com/tlevi/moodle/tree/mdl28708_20STABLE MOODLE_21_STABLE: https://github.com/tlevi/moodle/tree/mdl28708_21STABLE
          Hide
          Michael de Raadt added a comment -

          Thanks for reporting that, also.

          Show
          Michael de Raadt added a comment - Thanks for reporting that, also.
          Hide
          Tony Levi added a comment -

          Also affects 2.2/dev

          Show
          Tony Levi added a comment - Also affects 2.2/dev
          Hide
          Petr Škoda added a comment -

          I have done a bit cleanup of unrelated minor issues in master because it would create problems with merges, thanks a lot!

          Show
          Petr Škoda added a comment - I have done a bit cleanup of unrelated minor issues in master because it would create problems with merges, thanks a lot!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Hide
          Rajesh Taneja added a comment -

          Works Great, Tony and Petr
          Thanks for improving moodle...

          Show
          Rajesh Taneja added a comment - Works Great, Tony and Petr Thanks for improving moodle...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: