Moodle

Add some css class names for rating div/span elements

Details

  • Type: Improvement Improvement
  • Status: Closed Closed
  • Priority: Minor Minor
  • Resolution: Fixed
  • Affects Version/s: 2.1.3, 2.2, 2.3
  • Fix Version/s: 2.1.4, 2.2.1
  • Component/s: Ratings
  • Labels:
  • Environment:
    Mooch
  • Testing Instructions:
    Hide

    View an activity that uses ratings. Either use Firebug or right click one of the rating UI elements and select "Inspect element" or do whatever you have to do in your browser to view the html.

    Check that the various UI elements have a class attribute.

    Show
    View an activity that uses ratings. Either use Firebug or right click one of the rating UI elements and select "Inspect element" or do whatever you have to do in your browser to view the html. Check that the various UI elements have a class attribute.
  • Affected Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE, MOODLE_23_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE, MOODLE_22_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-28710_rating_classes
  • Pull Master Diff URL:

Description

At the moment divs/spans of rating UI are not customisable. They miss some class names.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jérôme Mouneyrac added a comment -

MDL-14421 is probable the same issue.

Show
Jérôme Mouneyrac added a comment - MDL-14421 is probable the same issue.
Hide
Permalink
Andrew Davis added a comment -

I've added some more classes. I think we now have this pretty well covered. I'll add the branches for 2.1 and 2.0 after peer review.

Show
Andrew Davis added a comment - I've added some more classes. I think we now have this pretty well covered. I'll add the branches for 2.1 and 2.0 after peer review.
Hide
Permalink
Sam Hemelryk added a comment -

Thanks Andrew, looks spot on

Show
Sam Hemelryk added a comment - Thanks Andrew, looks spot on
Hide
Permalink
Sam Hemelryk added a comment -

Should add that master only changes will likely be delayed from integration for a couple of weeks.
We try to keep the latest branch master as close as possible for the first few weeks after release.

Show
Sam Hemelryk added a comment - Should add that master only changes will likely be delayed from integration for a couple of weeks. We try to keep the latest branch master as close as possible for the first few weeks after release.
Hide
Permalink
Aparup Banerjee added a comment -

Thanks for the fix, integrated and ready for testing!

Show
Aparup Banerjee added a comment - Thanks for the fix, integrated and ready for testing!
Hide
Permalink
Michael de Raadt added a comment -

Test result: Passed! Using forum post rating, classes spotted:

{forum-post-rating, postratingform, ratingform, ratinginput, rating-aggregate-label, select postratingmenu ratinginput, ratingsubmit, postratingmenusubmit}

.

Show
Michael de Raadt added a comment - Test result: Passed! Using forum post rating, classes spotted: {forum-post-rating, postratingform, ratingform, ratinginput, rating-aggregate-label, select postratingmenu ratinginput, ratingsubmit, postratingmenusubmit} .
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Yes, you did it!

Now your code is part of the best weeklies released ever, many thanks!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - Yes, you did it! Now your code is part of the best weeklies released ever, many thanks! Closing, ciao

People

Vote (0)
Watch (2)

Dates

  • Created:
    Updated:
    Resolved: