Moodle
  1. Moodle
  2. MDL-28713

Improve the English help files for Workshop

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: 1.9.13
    • Fix Version/s: None
    • Component/s: Language, Unknown, Workshop
    • Labels:
    • Testing Instructions:
      Hide

      1. Ensure that the workshop module is enabled (in Admin > Modules > Activities > Manage activities.
      2. Add a workshop activity to a course and check that the help popup for Grade for Assessments has wording as in https://github.com/thepurpleblob/gumoodle/compare/MOODLE_19_STABLE...MDL-28713#diff-2

      Show
      1. Ensure that the workshop module is enabled (in Admin > Modules > Activities > Manage activities. 2. Add a workshop activity to a course and check that the help popup for Grade for Assessments has wording as in https://github.com/thepurpleblob/gumoodle/compare/MOODLE_19_STABLE...MDL-28713#diff-2
    • Affected Branches:
      MOODLE_19_STABLE
    • Rank:
      18376

      Description

      The help files for Workshop are poorly translated into English. We had one of our trainers produce a new set which are, hopefully, much clearer. I am not expecting them to get added to 1.9 particularly, but am adding them in case they are of use to anyone else.

        Activity

        Hide
        Dan Marsden added a comment -

        Hi Howard - saw your post in the forum so thought I'd review it... I guess asking for a English as second lang dev to review english lang files might not make sense... although I'm sure David would have been able to do it....

        I think this looks good!

        Now you need to hit the "submit for integration" button up the top! - good work!

        Show
        Dan Marsden added a comment - Hi Howard - saw your post in the forum so thought I'd review it... I guess asking for a English as second lang dev to review english lang files might not make sense... although I'm sure David would have been able to do it.... I think this looks good! Now you need to hit the "submit for integration" button up the top! - good work!
        Hide
        Michael de Raadt added a comment -

        Sorry if I'm confusing people with the changes I'm making. Howard cannot push issues through to integration as he is not a component lead. I've been trying to see if I can do that for him. I'll come back to this shortly.

        Show
        Michael de Raadt added a comment - Sorry if I'm confusing people with the changes I'm making. Howard cannot push issues through to integration as he is not a component lead. I've been trying to see if I can do that for him. I'll come back to this shortly.
        Hide
        Michael de Raadt added a comment -

        Hi, David.

        I thought you should have a chance to look at this before we push it to integration.

        Show
        Michael de Raadt added a comment - Hi, David. I thought you should have a chance to look at this before we push it to integration.
        Hide
        Howard Miller added a comment -

        I am not worthy

        Show
        Howard Miller added a comment - I am not worthy
        Hide
        Helen Foster added a comment -

        Although David's English is excellent, he's currently on holiday, so I thought I'd take a look at this issue.

        Howard, thanks for sharing your help file improvements. Looks perfect to me, so I'm submitting for integration review. (Hope I'm not abusing my tracker powers too much!)

        Show
        Helen Foster added a comment - Although David's English is excellent, he's currently on holiday, so I thought I'd take a look at this issue. Howard, thanks for sharing your help file improvements. Looks perfect to me, so I'm submitting for integration review. (Hope I'm not abusing my tracker powers too much!)
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Ho,

        I'm rejecting this because:

        • There are some tabs and trailing whitespace in the files.
        • There are some unclosed (and incorrect) <Li> elements.
        • There are some <p><p> tags too.

        It needs to be proper html before landing. Easy to fix. Ciao

        Show
        Eloy Lafuente (stronk7) added a comment - Ho, I'm rejecting this because: There are some tabs and trailing whitespace in the files. There are some unclosed (and incorrect) <Li> elements. There are some <p><p> tags too. It needs to be proper html before landing. Easy to fix. Ciao
        Hide
        Howard Miller added a comment -

        Boo... that's what happens when I don't check myself. Back soon

        Show
        Howard Miller added a comment - Boo... that's what happens when I don't check myself. Back soon
        Hide
        David Mudrak added a comment -

        Re-assigning to Howard as per his recent activity on this.

        Howard, if you feel you are not interested in this issues any more, feel free to close it as "won't fix". My personal attitude toward Workshop 1.x is that I do not work on it unless there is a real security issue.

        Thanks for all your hard work on this.

        Show
        David Mudrak added a comment - Re-assigning to Howard as per his recent activity on this. Howard, if you feel you are not interested in this issues any more, feel free to close it as "won't fix". My personal attitude toward Workshop 1.x is that I do not work on it unless there is a real security issue. Thanks for all your hard work on this.
        Hide
        David Mudrak added a comment -

        No activity for a year. Closing.

        Show
        David Mudrak added a comment - No activity for a year. Closing.

          People

          • Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: