Moodle
  1. Moodle
  2. MDL-28721

hidenav setting in SCORM not working right

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: SCORM
    • Labels:
      None
    • Testing Instructions:
      Hide

      Create a new SCORM
      set "Display course structure in playerAdvanced element" -> "to the side"

      • check other settings and make sure they disable the element "hidenav" below it.
        set hidenav to "yes"
        load player, make sure navigation buttons are hidden
      Show
      Create a new SCORM set "Display course structure in playerAdvanced element" -> "to the side" check other settings and make sure they disable the element "hidenav" below it. set hidenav to "yes" load player, make sure navigation buttons are hidden
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull Master Branch:
      master_MDL-28721
    • Rank:
      18513

      Description

      hidenav setting isn't being respected and it's only used when TOC is always displayed anyway.

      need to disable the form option in the editing settings page to disable the element if any toc display is not set to the side.

      need to fix code to respect the setting.

      reported here:
      http://moodle.org/mod/forum/discuss.php?d=182320

        Activity

        Hide
        Dan Marsden added a comment -

        NOTE FOR INTEGRATOR:
        The patch for 2.0 is deliberately different - the only thing that needs changing in the 2.0 branch is to disable the toc setting in the form.

        Show
        Dan Marsden added a comment - NOTE FOR INTEGRATOR: The patch for 2.0 is deliberately different - the only thing that needs changing in the 2.0 branch is to disable the toc setting in the form.
        Hide
        Dan Marsden added a comment -

        note to integrator - have rebased against todays stable release

        Show
        Dan Marsden added a comment - note to integrator - have rebased against todays stable release
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
        Hide
        Rossiani Wijaya added a comment -

        Thanks Dan for reporting and fixing the bug.

        Test passed.

        Show
        Rossiani Wijaya added a comment - Thanks Dan for reporting and fixing the bug. Test passed.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        This has been sent upstream and is now available in all git & cvs servers. Many thanks for the hard work!

        Show
        Eloy Lafuente (stronk7) added a comment - This has been sent upstream and is now available in all git & cvs servers. Many thanks for the hard work!

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: