Moodle
  1. Moodle
  2. MDL-28728

allow student to clear SCORM attempt

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2, 2.3
    • Fix Version/s: 2.2.1
    • Component/s: SCORM
    • Labels:
    • Testing Instructions:
      Hide

      Add a SCORM - set Display attempt status == yes
      Log in as student - enter the SCORM and get it to return some data in reports.
      check the main "entry" view.php page to make sure that the button "delete all SCORM attempts" isn't shown.
      Log in as Admin - give student role the new capability "deleteownresponses"
      Log back in as student - check to see if the button shows and works as expected by deleting responses.

      (it might be easier to test as admin user because the student can't "see" results in the reports page to see if the data has been deleted.

      Show
      Add a SCORM - set Display attempt status == yes Log in as student - enter the SCORM and get it to return some data in reports. check the main "entry" view.php page to make sure that the button "delete all SCORM attempts" isn't shown. Log in as Admin - give student role the new capability "deleteownresponses" Log back in as student - check to see if the button shows and works as expected by deleting responses. (it might be easier to test as admin user because the student can't "see" results in the reports page to see if the data has been deleted.
    • Affected Branches:
      MOODLE_22_STABLE, MOODLE_23_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-28728
    • Rank:
      18391

      Description

      I want this for ADL tests - it makes it easier if the student can clear their own attempts when running the ADL tests - that way we can automate it a bit better. Must be disabled by default.

        Issue Links

          Activity

          Hide
          Dan Marsden added a comment -

          NOTE - this adds a new capability that is deliberately not given to any roles.

          Show
          Dan Marsden added a comment - NOTE - this adds a new capability that is deliberately not given to any roles.
          Hide
          Dan Marsden added a comment -

          note - the Delete response button is only shown if user has the capability and if display attempt status == yes.

          Show
          Dan Marsden added a comment - note - the Delete response button is only shown if user has the capability and if display attempt status == yes.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

          TIA and ciao

          Show
          Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
          Hide
          Dan Marsden added a comment -

          rebased - happy for this to be applied to 22Stable as well if you are still keeping in sync.

          Show
          Dan Marsden added a comment - rebased - happy for this to be applied to 22Stable as well if you are still keeping in sync.
          Hide
          Aparup Banerjee added a comment -

          Thanks Dan, thats been integrated .

          ps: i wonder though if we should document this somewhere with regards to its use for ADL.

          Show
          Aparup Banerjee added a comment - Thanks Dan, thats been integrated . ps: i wonder though if we should document this somewhere with regards to its use for ADL.
          Hide
          Ankit Agarwal added a comment -

          Hi Dan,
          Altough the functionality is working great and as expected, but there is a missing string which is generating the following stack

          Invalid get_string() identifier: 'scorm:deleteownresponses' or component 'mod_scorm'. Perhaps you are missing $string['scorm:deleteownresponses'] = ''; in mod/scorm/lang/en/scorm.php?
          
              line 6313 of \lib\moodlelib.php: call to debugging()
              line 6905 of \lib\moodlelib.php: call to core_string_manager->get_string()
              line 2719 of \lib\accesslib.php: call to get_string()
              line 161 of \admin\tool\capability\index.php: call to get_capability_string()
          

          I can pass this once the string is added
          Thanks

          Show
          Ankit Agarwal added a comment - Hi Dan, Altough the functionality is working great and as expected, but there is a missing string which is generating the following stack Invalid get_string() identifier: 'scorm:deleteownresponses' or component 'mod_scorm'. Perhaps you are missing $string['scorm:deleteownresponses'] = ''; in mod/scorm/lang/en/scorm.php? line 6313 of \lib\moodlelib.php: call to debugging() line 6905 of \lib\moodlelib.php: call to core_string_manager->get_string() line 2719 of \lib\accesslib.php: call to get_string() line 161 of \admin\tool\capability\index.php: call to get_capability_string() I can pass this once the string is added Thanks
          Hide
          Dan Marsden added a comment -

          doh! - I thought I'd pushed that through, fixed now thanks Ankit!

          Apu - good point, I have plans to do some work on the SCORM docs sometime pretty soon.

          Show
          Dan Marsden added a comment - doh! - I thought I'd pushed that through, fixed now thanks Ankit! Apu - good point, I have plans to do some work on the SCORM docs sometime pretty soon.
          Hide
          Aparup Banerjee added a comment -

          Thanks, i've pulled that string in now. integrated and up for testing.

          Show
          Aparup Banerjee added a comment - Thanks, i've pulled that string in now. integrated and up for testing.
          Hide
          Ankit Agarwal added a comment -

          all good now
          Thanks

          Show
          Ankit Agarwal added a comment - all good now Thanks
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks!

          Now... disconnect, relax and enjoy the next days, yay!

          Closing...ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Whoever decided one week was worth 14 days had really one bad idea. Anyway, the nightmare is over, so thanks for your, once again, amazing contributions. Many, many thanks! Now... disconnect, relax and enjoy the next days, yay! Closing...ciao
          Hide
          Helen Foster added a comment -

          Documentation for this new capability is now available (better late than never!):

          http://docs.moodle.org/22/en/Capabilities/mod/scorm:deleteownresponses

          Show
          Helen Foster added a comment - Documentation for this new capability is now available (better late than never!): http://docs.moodle.org/22/en/Capabilities/mod/scorm:deleteownresponses

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: