Moodle
  1. Moodle
  2. MDL-28729

META: Assess and centralise multilang issues affecting Moodle 2.1+

    Details

    • Type: Task Task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: None
    • Component/s: Filters, Language
    • Labels:
    • Affected Branches:
      MOODLE_21_STABLE
    • Rank:
      18394

      Description

      This issue is just going to be a meta issue for us to centralise multilang issues that exist within Moodle 2.1+

        Issue Links

          Activity

          Hide
          Sam Hemelryk added a comment -

          Hi guys,

          This issues is about centralising the multilang bugs that many of us seem to be working on so that we can sort overall see what is happening and discuss the edge cases.

          Order 1 - course shortname.
          There are a couple of bugs already fixing up the course shortname however it appears we are undecided whether or not it should support multilang or not.
          There are (I think) places within Moodle where it is, and places where it is not.
          It has been raised that the field length is 100 chars which is too short to support multilang properly, however it seems to be widely wanted given people are creating bugs for it.
          What other aspects need to be taken into account for this?

          Cheers
          Sam

          Show
          Sam Hemelryk added a comment - Hi guys, This issues is about centralising the multilang bugs that many of us seem to be working on so that we can sort overall see what is happening and discuss the edge cases. Order 1 - course shortname. There are a couple of bugs already fixing up the course shortname however it appears we are undecided whether or not it should support multilang or not. There are (I think) places within Moodle where it is, and places where it is not. It has been raised that the field length is 100 chars which is too short to support multilang properly, however it seems to be widely wanted given people are creating bugs for it. What other aspects need to be taken into account for this? Cheers Sam
          Hide
          Andrew Davis added a comment -

          Course short name is displayed in the user interface. Thus it has to support multilang. course.idnumber is there to provide a means to identify courses between systems.

          Show
          Andrew Davis added a comment - Course short name is displayed in the user interface. Thus it has to support multilang. course.idnumber is there to provide a means to identify courses between systems.
          Hide
          Petr Škoda added a comment -

          shortname is still considered to be a unique course identifier that can be used in import/export/sync - it should not be modified in any way. Remember the shortname existed before the idnumber.

          If we decide that the shortname is only a general short name of course (it does not have to be unique in fact) and idnumber is the external identifier than my +1 to format_string($shortname), if not then +2 for using only s($shortname).

          Show
          Petr Škoda added a comment - shortname is still considered to be a unique course identifier that can be used in import/export/sync - it should not be modified in any way. Remember the shortname existed before the idnumber. If we decide that the shortname is only a general short name of course (it does not have to be unique in fact) and idnumber is the external identifier than my +1 to format_string($shortname), if not then +2 for using only s($shortname).
          Hide
          Sam Hemelryk added a comment -

          Eloy, Martin, Michael - comments please!

          Show
          Sam Hemelryk added a comment - Eloy, Martin, Michael - comments please!
          Hide
          Sam Hemelryk added a comment -

          Shortname gets my +1 for format_string and no longer being considered an identifier.
          Of course the question will be then however it is permissable to backport this or should we only fix things in master? (my +1 to backport anyway )

          Show
          Sam Hemelryk added a comment - Shortname gets my +1 for format_string and no longer being considered an identifier. Of course the question will be then however it is permissable to backport this or should we only fix things in master? (my +1 to backport anyway )
          Hide
          Sam Hemelryk added a comment - - edited

          Purposed solution:

          Area Current formatting Purposed formatting Additional work Issue
          course short name inconsistent filtered consistently increase db field length to 255 to make it useful MDL-29189
          course fullname inconsistant filtered consistently   MDL-29186
          course section name inconsistent filtered consistently   MDL-29188
          activity name inconsistent filtered consistently    
          category name inconsistent filtered consistently   MDL-29187
          block_html title inconsistent filtered consistently   MDL-29006

          Note: In 20 and 21 filtering on course shortname will be fixed consistently however the field size will not be increased. The field size increase will only occur in master.

          How does this sound to everyone?

          Show
          Sam Hemelryk added a comment - - edited Purposed solution: Area Current formatting Purposed formatting Additional work Issue course short name inconsistent filtered consistently increase db field length to 255 to make it useful MDL-29189 course fullname inconsistant filtered consistently   MDL-29186 course section name inconsistent filtered consistently   MDL-29188 activity name inconsistent filtered consistently     category name inconsistent filtered consistently   MDL-29187 block_html title inconsistent filtered consistently   MDL-29006 Note: In 20 and 21 filtering on course shortname will be fixed consistently however the field size will not be increased. The field size increase will only occur in master. How does this sound to everyone?
          Hide
          Sam Hemelryk added a comment -

          All subtasks complete...hoorah

          Show
          Sam Hemelryk added a comment - All subtasks complete...hoorah

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: