Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28737

advcheckboxes toggle their value every form submit in the presence of a checkbox_controller

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Forms Library
    • Labels:

      Description

      Try the attached file. Keep clicking the button and see the checkbox state toggle.

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              I don't get why the change does that but... testing will reveal if really works, lol. Integrated!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - I don't get why the change does that but... testing will reveal if really works, lol. Integrated!
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Works Great on FF, chrome and Opera.
              On ie8 state of checkbox doesn't change (Hence passing), but get JS error when click on "select all/none"

              Message: Object doesn't support this property or method
              Line: 14
              Char: 5
              Code: 0
              URI: http://rajesh.moodle.local/moodle/test.php

              As ie doesn't support getElementsByClassName, it will be nice to open a bug to fix this for ie. Probably change the function to use YUI

              Show
              rajeshtaneja Rajesh Taneja added a comment - Works Great on FF, chrome and Opera. On ie8 state of checkbox doesn't change (Hence passing), but get JS error when click on "select all/none" Message: Object doesn't support this property or method Line: 14 Char: 5 Code: 0 URI: http://rajesh.moodle.local/moodle/test.php As ie doesn't support getElementsByClassName, it will be nice to open a bug to fix this for ie. Probably change the function to use YUI
              Hide
              timhunt Tim Hunt added a comment -

              Oh drat! and I did change that line of code. I made the change because I was getting errors in Firefox. Please open a bug for the new IE issue.

              Show
              timhunt Tim Hunt added a comment - Oh drat! and I did change that line of code. I made the change because I was getting errors in Firefox. Please open a bug for the new IE issue.
              Hide
              rajeshtaneja Rajesh Taneja added a comment -

              Done Tim
              MDL-28972

              Show
              rajeshtaneja Rajesh Taneja added a comment - Done Tim MDL-28972
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              This has been sent upstream and is now available in all git & cvs servers. Many thanks for the hard work!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - This has been sent upstream and is now available in all git & cvs servers. Many thanks for the hard work!
              Hide
              albert.gasset Albert Gasset added a comment - - edited

              This bug also affects Moodle 1.9.13+.

              Show
              albert.gasset Albert Gasset added a comment - - edited This bug also affects Moodle 1.9.13+.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Oct/11