Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.4
    • Component/s: SCORM
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE

      Description

      Bug to track compliance with named ADL test for SCORM 2004
      Currently FAILING DUE TO:
      UI Tests -

      In Activity 1 - the continue navigation event is not disabled.
      In Activity 1 - Activity 2 is selectable in Table of contents.

      Activty 3 - Unable to launch activity 3.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Dan Marsden added a comment -

            Note - CM -01 is still failing as next activity isn't launched after first activity is complete.

            Show
            Dan Marsden added a comment - Note - CM -01 is still failing as next activity isn't launched after first activity is complete.
            Hide
            Dan Marsden added a comment -

            this could do with a peer review too - I'll try to look at this a bit closer unless another dev beats me to it!

            Show
            Dan Marsden added a comment - this could do with a peer review too - I'll try to look at this a bit closer unless another dev beats me to it!
            Hide
            Rossiani Wijaya added a comment -

            Hi Dan,

            Could you add testing instruction for this issue?

            Thanks

            Show
            Rossiani Wijaya added a comment - Hi Dan, Could you add testing instruction for this issue? Thanks
            Hide
            Rossiani Wijaya added a comment -

            While reviewing this issue, I couldn't get it to passed the first page. I'm using the 'LMSTestPackage_CM-01.zip'

            Am I missing any setting?

            Show
            Rossiani Wijaya added a comment - While reviewing this issue, I couldn't get it to passed the first page. I'm using the 'LMSTestPackage_CM-01.zip' Am I missing any setting?
            Hide
            Dan Marsden added a comment -

            Hi Rosie - I probably need to write a decent set of testing info for SCORM 2004 packages - it only works in certain browsers, you are supposed to have the adl test engine running etc etc. If you wouldn't mind doing an initial look at the code around coding guidelines/structure etc that would be really useful at this stage.

            I'll try to throw a decent test doc explaining how to test a single package later this week

            thanks!

            Show
            Dan Marsden added a comment - Hi Rosie - I probably need to write a decent set of testing info for SCORM 2004 packages - it only works in certain browsers, you are supposed to have the adl test engine running etc etc. If you wouldn't mind doing an initial look at the code around coding guidelines/structure etc that would be really useful at this stage. I'll try to throw a decent test doc explaining how to test a single package later this week thanks!
            Hide
            Rossiani Wijaya added a comment -

            Hi Dan,

            I tried to setup adl test engine on my machine but it kept killing my machine.

            So I follow your suggestion to review the code itself.

            On mod/scorm/locallib.php, add break line between if statement.

            Then, on line 1703, is there any reason for re-set $scoes as $sco. If it is necessary, it should probably assigned as clone($scoes).

            On mod/scorm/module.js line 297 to 308, the conditional for "var scorm_skipprev = function(node) {}" could be simplified to:

            if (node.previousSibling && typeof scoes_nav[mod_scorm_launch_sco].prevscoid != 'undefined') {
                ...
            } else if (node.depth > 0 && typeof scoes_nav[mod_scorm_launch_sco].prevscoid != 'undefined') {
                ....
            }    
            

            or

            if (typeof scoes_nav[mod_scorm_launch_sco].prevscoid != 'undefined') {
                var prevscoid = scoes_nav[mod_scorm_launch_sco].prevscoid;
                
                if (node.previousSibling) {
                    node.previousSibling.title = scoes_nav[prevscoid].url;
                    return node.previousSibling;
                }else if (node.depth > 0) {
                    node.parent.title = scoes_nav[prevscoid].url;
                    return node.parent;
                }                 
            }
            

            On mod/scorm/module.js line 325, the conditional for "var scorm_skipnext = function(node) {}", should the elseif statement check for "typeof scoes_nav[mod_scorm_launch_sco].nextscoid != 'undefined'"?

            Let me know if you have any question.

            Show
            Rossiani Wijaya added a comment - Hi Dan, I tried to setup adl test engine on my machine but it kept killing my machine. So I follow your suggestion to review the code itself. On mod/scorm/locallib.php, add break line between if statement. Then, on line 1703, is there any reason for re-set $scoes as $sco. If it is necessary, it should probably assigned as clone($scoes). On mod/scorm/module.js line 297 to 308, the conditional for "var scorm_skipprev = function(node) {}" could be simplified to: if (node.previousSibling && typeof scoes_nav[mod_scorm_launch_sco].prevscoid != 'undefined') { ... } else if (node.depth > 0 && typeof scoes_nav[mod_scorm_launch_sco].prevscoid != 'undefined') { .... } or if (typeof scoes_nav[mod_scorm_launch_sco].prevscoid != 'undefined') { var prevscoid = scoes_nav[mod_scorm_launch_sco].prevscoid; if (node.previousSibling) { node.previousSibling.title = scoes_nav[prevscoid].url; return node.previousSibling; }else if (node.depth > 0) { node.parent.title = scoes_nav[prevscoid].url; return node.parent; } } On mod/scorm/module.js line 325, the conditional for "var scorm_skipnext = function(node) {}", should the elseif statement check for "typeof scoes_nav [mod_scorm_launch_sco] .nextscoid != 'undefined'"? Let me know if you have any question.
            Hide
            Dan Marsden added a comment -

            Thanks! - that's helpful feedback - Mayank can you please take a look at Rossiani's comments and make changes as required?

            Show
            Dan Marsden added a comment - Thanks! - that's helpful feedback - Mayank can you please take a look at Rossiani's comments and make changes as required?
            Hide
            Dan Marsden added a comment -

            Mayanks patch contains fixes for more than just this test - have reabased and moved his patch into MDL-35418 - will link all the tests that his patch fixes after testing it. Thanks Mayank.

            Show
            Dan Marsden added a comment - Mayanks patch contains fixes for more than just this test - have reabased and moved his patch into MDL-35418 - will link all the tests that his patch fixes after testing it. Thanks Mayank.
            Hide
            Dan Marsden added a comment -

            Moodle 2.4 now passes the CM-01 test due to the work in MDL-35418

            Show
            Dan Marsden added a comment - Moodle 2.4 now passes the CM-01 test due to the work in MDL-35418

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: