Moodle
  1. Moodle
  2. MDL-28932

Type hinting used in 1.9 version of tags/lib.php

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.13
    • Fix Version/s: 1.9.14
    • Component/s: Tags
    • Labels:
    • Rank:
      18600

      Description

      Line 845 in tags/lib.php us

      function tag_process_computed_correlation(stdClass $tagcorrelation) {

      As 1.9 is supposed to be compatible with PHP4 this is not valid syntax. Type hinting appeared in PHP5.

        Activity

        Hide
        Michael de Raadt added a comment -

        Wrist - slapped.

        Show
        Michael de Raadt added a comment - Wrist - slapped.
        Hide
        Petr Škoda added a comment -

        Thanks for the report!!

        Show
        Petr Škoda added a comment - Thanks for the report!!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Grrr, my fault (MDL-24355). Thanks for spotting and reporting it. Integrated, thanks!

        Show
        Eloy Lafuente (stronk7) added a comment - Grrr, my fault ( MDL-24355 ). Thanks for spotting and reporting it. Integrated, thanks!
        Hide
        Eloy Lafuente (stronk7) added a comment -

        No test required

        Show
        Eloy Lafuente (stronk7) added a comment - No test required
        Hide
        Aparup Banerjee added a comment -

        'Nobody' was testing this but i thought i better pass it then.

        Show
        Aparup Banerjee added a comment - 'Nobody' was testing this but i thought i better pass it then.
        Hide
        Eloy Lafuente (stronk7) added a comment -

        Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

        Show
        Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

          People

          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: