Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28932

Type hinting used in 1.9 version of tags/lib.php

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.9.13
    • Fix Version/s: 1.9.14
    • Component/s: Tags
    • Labels:

      Description

      Line 845 in tags/lib.php us

      function tag_process_computed_correlation(stdClass $tagcorrelation) {

      As 1.9 is supposed to be compatible with PHP4 this is not valid syntax. Type hinting appeared in PHP5.

        Gliffy Diagrams

          Attachments

            Activity

            Hide
            salvetore Michael de Raadt added a comment -

            Wrist - slapped.

            Show
            salvetore Michael de Raadt added a comment - Wrist - slapped.
            Hide
            skodak Petr Skoda added a comment -

            Thanks for the report!!

            Show
            skodak Petr Skoda added a comment - Thanks for the report!!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Grrr, my fault (MDL-24355). Thanks for spotting and reporting it. Integrated, thanks!

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Grrr, my fault ( MDL-24355 ). Thanks for spotting and reporting it. Integrated, thanks!
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            No test required

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - No test required
            Hide
            nebgor Aparup Banerjee added a comment -

            'Nobody' was testing this but i thought i better pass it then.

            Show
            nebgor Aparup Banerjee added a comment - 'Nobody' was testing this but i thought i better pass it then.
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                1 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:
                  Fix Release Date:
                  10/Oct/11