Moodle
  1. Moodle
  2. MDL-28933

inconsistent checking of SCORM version

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.2
    • Fix Version/s: 2.2
    • Component/s: SCORM
    • Testing Instructions:
      Hide

      as with many SCORM issues this one is a pain to test.

      really a developer should review the function and the changes to make sure they look right.

      If you really want to test it - grab a SCORM package that works - maybe the fruit quiz:
      http://moodle.org/mod/data/view.php?d=50&rid=1655
      make sure it works as expected.

      This is only going in HEAD.

      thanks!

      Show
      as with many SCORM issues this one is a pain to test. really a developer should review the function and the changes to make sure they look right. If you really want to test it - grab a SCORM package that works - maybe the fruit quiz: http://moodle.org/mod/data/view.php?d=50&rid=1655 make sure it works as expected. This is only going in HEAD. thanks!
    • Affected Branches:
      MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_22_STABLE
    • Pull Master Branch:
      master_MDL-28933

      Description

      checking of SCORM version is a bit problematic - sometimes it checks lowercase, other times it checks higher case, sometimes it uses . syntax other times it uses _

      this is mainly an issue with checking for SCORM 1.3 but it makes sense to do this check in a global function.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Dan Marsden added a comment -

            NOTE TO INTEGRATOR - This branch also includes the commit for MDL-28541 - you should merge MDL-28541 before this bug. - thanks!

            Show
            Dan Marsden added a comment - NOTE TO INTEGRATOR - This branch also includes the commit for MDL-28541 - you should merge MDL-28541 before this bug. - thanks!
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
            Hide
            Aparup Banerjee added a comment -

            The fruits scorm worked fine for me - no problems seen.

            The code looks fine to me.

            don't know much about scorm but hoping there's no security issues like a nasty scorm file with a version that is a hacky script.

            Show
            Aparup Banerjee added a comment - The fruits scorm worked fine for me - no problems seen. The code looks fine to me. don't know much about scorm but hoping there's no security issues like a nasty scorm file with a version that is a hacky script.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            This has been sent upstream and is now available in all git & cvs servers. Many thanks for the hard work!

            Show
            Eloy Lafuente (stronk7) added a comment - This has been sent upstream and is now available in all git & cvs servers. Many thanks for the hard work!

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                0 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: