Moodle
  1. Moodle
  2. MDL-28935

Add days of week to monthly calendar view

    Details

      Description

      When viewing the monthly calendar as a full page, it does not display the days relative to the dates shown. This can be confusing, especially if the first day of week has been changed from Sunday to another day which makes it harder to determine which date sits under which day of the week.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            Jason Ilicic added a comment -

            Committed a patch to: https://github.com/jasonilicic/moodle/commit/f5546e6364e38e59f9b562f4191dda28153f59d4

            This adds in the week days including rotation of the days based on the first day of week.

            Show
            Jason Ilicic added a comment - Committed a patch to: https://github.com/jasonilicic/moodle/commit/f5546e6364e38e59f9b562f4191dda28153f59d4 This adds in the week days including rotation of the days based on the first day of week.
            Hide
            Michael de Raadt added a comment -

            Nice solution.

            Show
            Michael de Raadt added a comment - Nice solution.
            Hide
            Petr Skoda added a comment -

            There are two minor problems:
            1/ the row width in standard theme seems to be too big
            2/ accessibility - I am not sure here, but I suppose the week days should be table headings, right?

            Show
            Petr Skoda added a comment - There are two minor problems: 1/ the row width in standard theme seems to be too big 2/ accessibility - I am not sure here, but I suppose the week days should be table headings, right?
            Hide
            Petr Skoda added a comment -

            To integrators: please consider cherry picking to all 2.x branches

            Show
            Petr Skoda added a comment - To integrators: please consider cherry picking to all 2.x branches
            Hide
            Petr Skoda added a comment -

            I just verified the calendar block, it is using th element too...

            Show
            Petr Skoda added a comment - I just verified the calendar block, it is using th element too...
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Plz complete the testing instructions, seems you applied textlib::substr() to them. LOL.

            Show
            Eloy Lafuente (stronk7) added a comment - Plz complete the testing instructions, seems you applied textlib::substr() to them. LOL.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Note for integration: backport by cherry-pick to 20 and 21.

            Show
            Eloy Lafuente (stronk7) added a comment - Note for integration: backport by cherry-pick to 20 and 21.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Integrated and backported to 20 and 21 stable, thanks!

            Show
            Eloy Lafuente (stronk7) added a comment - Integrated and backported to 20 and 21 stable, thanks!
            Hide
            Rossiani Wijaya added a comment -

            Tested and works great.

            Thank you for fixing this.

            Test passed.

            Show
            Rossiani Wijaya added a comment - Tested and works great. Thank you for fixing this. Test passed.
            Hide
            Eloy Lafuente (stronk7) added a comment -

            Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

            Show
            Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

              People

              • Votes:
                4 Vote for this issue
                Watchers:
                3 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: