Moodle
  1. Moodle
  2. MDL-26979 custom menu :: IEs overwrite theme CSS with YUI CSS
  3. MDL-28941

custom menu :: IEs overwrite theme CSS with YUI CSS (backport of MDL-26979)

    Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1
    • Fix Version/s: 2.1.6
    • Component/s: Themes
    • Labels:
    • Testing Instructions:
      Hide

      (copied from MDL-26979)

      1. Log in as an admin
      2. Browse to Settings > Appearance > Theme settings
      3. Enable theme change on URL
      4. Add a custom menu (just copy paste the example)
      5. Test each core theme (but Anomaly!) in Firefox, Chrome + IE.
      6. Check that in each the custommenu looks consistent. It doesn't have to be perfect the aim of these changes is to simplify CSS and improve consistency.
      Show
      (copied from MDL-26979 ) Log in as an admin Browse to Settings > Appearance > Theme settings Enable theme change on URL Add a custom menu (just copy paste the example) Test each core theme (but Anomaly!) in Firefox, Chrome + IE. Check that in each the custommenu looks consistent. It doesn't have to be perfect the aim of these changes is to simplify CSS and improve consistency.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Rank:
      16610

      Description

      Originaly MDL-26979 was targeted for 20_STABLE, 21_STABLE and master, but due to the nature and size of the change I didn't feel confident pushing that to stable branches.

      So I decided to move the backporting task to this issue instead. Note I added one extra commit in master performing some whitespace cleanup (it should be backported too).

        Issue Links

          Activity

          Hide
          Eloy Lafuente (stronk7) added a comment -

          My personal +1 goes to backport this to 21_STABLE only. For your consideration.

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - My personal +1 goes to backport this to 21_STABLE only. For your consideration. Ciao
          Hide
          Richard Oelmann added a comment -

          Eloy,
          Although there may be advantages in only backporting this to 21_stable, unfortunately many users are still limited by webhosts and php requirements so that they are unable to upgrade to 2.1 from 2.0, so I hope serious consideration would also be given to porting it to 20_stable, please.
          Thanks
          Richard

          Show
          Richard Oelmann added a comment - Eloy, Although there may be advantages in only backporting this to 21_stable, unfortunately many users are still limited by webhosts and php requirements so that they are unable to upgrade to 2.1 from 2.0, so I hope serious consideration would also be given to porting it to 20_stable, please. Thanks Richard
          Hide
          Sam Hemelryk added a comment -

          This got lost sorry, I've created a 2.1 branch now however as 2.0 is now only receiving security fixes this has unfortunately missed to 20 boat.
          Putting this up for peer-review now.

          Show
          Sam Hemelryk added a comment - This got lost sorry, I've created a 2.1 branch now however as 2.0 is now only receiving security fixes this has unfortunately missed to 20 boat. Putting this up for peer-review now.
          Hide
          Dan Poltawski added a comment -

          +1 from me Sam

          Show
          Dan Poltawski added a comment - +1 from me Sam
          Hide
          Sam Hemelryk added a comment -

          Thanks Dan, submitting for integration now.

          There is one thing I forgot to point out, the custom menu in the Anomaly theme has since being restyled and as such this change no longer touches it. All other changes backported cleanly.

          Show
          Sam Hemelryk added a comment - Thanks Dan, submitting for integration now. There is one thing I forgot to point out, the custom menu in the Anomaly theme has since being restyled and as such this change no longer touches it. All other changes backported cleanly.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated (21_STABLE) and added testing instructions from the original issue. Thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated (21_STABLE) and added testing instructions from the original issue. Thanks!
          Hide
          Michael de Raadt added a comment -

          Test result: Success.

          Tested on 2.1 in Firefox, Chrome and IE8.

          The following theme values were used:

          afterburner, arialist, binarius, boxxie, brick, formal_white, formfactor, fusion, leatherbound, magazine, nimble, nonzero, overlay, serenity, sky_high, splash, standard

          Show
          Michael de Raadt added a comment - Test result: Success. Tested on 2.1 in Firefox, Chrome and IE8. The following theme values were used: afterburner, arialist, binarius, boxxie, brick, formal_white, formfactor, fusion, leatherbound, magazine, nimble, nonzero, overlay, serenity, sky_high, splash, standard
          Hide
          Eloy Lafuente (stronk7) added a comment -

          This has been near becoming rejected, because it's not the best code you are able to produce.

          But, luckily, at the end, it has landed and has been spread to all repos out there.

          Many thanks and, don't forget it, keep improving your skills, you can!

          Closing, ciao

          Show
          Eloy Lafuente (stronk7) added a comment - This has been near becoming rejected, because it's not the best code you are able to produce. But, luckily, at the end, it has landed and has been spread to all repos out there. Many thanks and, don't forget it, keep improving your skills, you can! Closing, ciao

            People

            • Votes:
              1 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: