Moodle

Activity and course completion reports links are inconsistent

Details

  • Testing Instructions:
    Hide

    1. On a course with activity completion and course completion enabled, add a large number of students (more than 25). All the students should have the first name or last name beginning with the same letter, e.g. A. Add at least one other student whose first name or last name belongs with a different letter.

    (NOTE: As an alternative to this tedious process, you could add just 3 students and temporarily hack the constant in the code from 25 to 2.)

    2. Go to the activity completion report. Click on the appropriate letter to filter the report.

    3. Go to page 2 of the report.

    • Verify that it is still filtered and that, together, the two pages show all the students without overlaps (and do not show the student whose name begins with something else).

    4. Repeat with course completion report.

    • Verify that it is still filtered by letter on page 2.
    Show
    1. On a course with activity completion and course completion enabled, add a large number of students (more than 25). All the students should have the first name or last name beginning with the same letter, e.g. A. Add at least one other student whose first name or last name belongs with a different letter. (NOTE: As an alternative to this tedious process, you could add just 3 students and temporarily hack the constant in the code from 25 to 2.) 2. Go to the activity completion report. Click on the appropriate letter to filter the report. 3. Go to page 2 of the report. Verify that it is still filtered and that, together, the two pages show all the students without overlaps (and do not show the student whose name begins with something else). 4. Repeat with course completion report. Verify that it is still filtered by letter on page 2.
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Fixed Branches:
    MOODLE_21_STABLE
  • Pull from Repository:
  • Pull Master Branch:
    MDL-28945-master
  • Pull Master Diff URL:

Description

When using the activity or course completion reports, only one initial can be selected at a time (ie, first or last, not both).
If you select a first initial, selecting a last initial removes the first.

Also, when moving between pages of a narrowed report with initials selected, the setting is lost, so you are sent to the nth page of the unfiltered report.
Sorting links also lose the filter settings.

Appending the initial selection arguments to the URL manually allows the function to be performed, so just the outputted links need correcting.

Patch incoming via github...

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Tony Levi added a comment -

20_STABLE: https://github.com/tlevi/moodle/tree/mdl28945

Show
Tony Levi added a comment - 20_STABLE: https://github.com/tlevi/moodle/tree/mdl28945
Hide
Permalink
Michael de Raadt added a comment -

Hi, Sam.

It would be good if you could look at this.

Show
Michael de Raadt added a comment - Hi, Sam. It would be good if you could look at this.
Hide
Permalink
Sam Marshall added a comment -

Sorry this one got lost (like everything that happened during a period when I was away). The change still cherry-picks OK to both current branches so I put it on my server and submitting for integration now.

Show
Sam Marshall added a comment - Sorry this one got lost (like everything that happened during a period when I was away). The change still cherry-picks OK to both current branches so I put it on my server and submitting for integration now.
Hide
Permalink
Sam Hemelryk added a comment -

Hi guys, integrated now thanks

Show
Sam Hemelryk added a comment - Hi guys, integrated now thanks
Hide
Permalink
Ankit Agarwal added a comment -

Hi,
The links are in the format

master/moodle/course/report/progress/?course=3&start=25sifirst=A&

Shouldn't that be

master/moodle/course/report/progress/?course=3&start=25&sifirst=A
Show
Ankit Agarwal added a comment - Hi, The links are in the format master/moodle/course/report/progress/?course=3&start=25sifirst=A& Shouldn't that be master/moodle/course/report/progress/?course=3&start=25&sifirst=A
Hide
Permalink
Ankit Agarwal added a comment -

Sorry failing this until the typo is fixed

Show
Ankit Agarwal added a comment - Sorry failing this until the typo is fixed
Hide
Permalink
Sam Hemelryk added a comment -

Thanks for picking that up Ankit.
I've pushed up a fix for this now and am putting it back up for testing.

Cheers
Sam

Show
Sam Hemelryk added a comment - Thanks for picking that up Ankit. I've pushed up a fix for this now and am putting it back up for testing. Cheers Sam
Hide
Permalink
Ankit Agarwal added a comment -

Everything works now.
Test passed!
Thanks

Show
Ankit Agarwal added a comment - Everything works now. Test passed! Thanks
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

Many thanks for all the hard work. This is now part of Moodle, your favorite LMS.

Closing as fixed, ciao

Show
Eloy Lafuente (stronk7) added a comment - Many thanks for all the hard work. This is now part of Moodle, your favorite LMS. Closing as fixed, ciao

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: