Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28945

Activity and course completion reports links are inconsistent

    XMLWordPrintable

    Details

    • Testing Instructions:
      Hide

      1. On a course with activity completion and course completion enabled, add a large number of students (more than 25). All the students should have the first name or last name beginning with the same letter, e.g. A. Add at least one other student whose first name or last name belongs with a different letter.

      (NOTE: As an alternative to this tedious process, you could add just 3 students and temporarily hack the constant in the code from 25 to 2.)

      2. Go to the activity completion report. Click on the appropriate letter to filter the report.

      3. Go to page 2 of the report.

      • Verify that it is still filtered and that, together, the two pages show all the students without overlaps (and do not show the student whose name begins with something else).

      4. Repeat with course completion report.

      • Verify that it is still filtered by letter on page 2.
      Show
      1. On a course with activity completion and course completion enabled, add a large number of students (more than 25). All the students should have the first name or last name beginning with the same letter, e.g. A. Add at least one other student whose first name or last name belongs with a different letter. (NOTE: As an alternative to this tedious process, you could add just 3 students and temporarily hack the constant in the code from 25 to 2.) 2. Go to the activity completion report. Click on the appropriate letter to filter the report. 3. Go to page 2 of the report. Verify that it is still filtered and that, together, the two pages show all the students without overlaps (and do not show the student whose name begins with something else). 4. Repeat with course completion report. Verify that it is still filtered by letter on page 2.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-28945-master
    • Pull Master Diff URL:

      Description

      When using the activity or course completion reports, only one initial can be selected at a time (ie, first or last, not both).
      If you select a first initial, selecting a last initial removes the first.

      Also, when moving between pages of a narrowed report with initials selected, the setting is lost, so you are sent to the nth page of the unfiltered report.
      Sorting links also lose the filter settings.

      Appending the initial selection arguments to the URL manually allows the function to be performed, so just the outputted links need correcting.

      Patch incoming via github...

        Attachments

          Issue Links

          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31470 Completion report - filtering users breaks pagination

          • Major - Major loss of function, incorrect output
          • Closed

            Activity

              People

              Assignee:
              quen Sam Marshall
              Reporter:
              tlevi Tony Levi
              Integrator:
              Sam Hemelryk
              Tester:
              Ankit Agarwal
              Participants:
              Component watchers:
              Sam Marshall, Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona), Amaia Anabitarte, Carlos Escobedo, Ferran Recio, Ilya Tregubov, Sara Arjona (@sarjona)
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                28/Nov/11