Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28954

Editing cohort description does not allow images of media to be uploaded

    Details

    • Type: Bug
    • Status: Waiting for integration review
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.1.1
    • Fix Version/s: STABLE backlog
    • Component/s: Cohorts
    • Labels:
    • Environment:
      XAMPP, Win 7

      Description

      When editing the description of a cohort with the HTML editor, it is not possible to upload images or media.

      This may be because of the context not being set for cohorts (or being set to zero), so there is no temporary editing area for attached files.

      Replication steps:

      1. Log in as admin
      2. Navigate to Site Administration -> Users -> Accounts -> Cohorts
      3. Click on the "Insert/edit image" button or the "Moodle media" button.

        Gliffy Diagrams

          Issue Links

            Activity

            Hide
            rajeshtaneja Rajesh Taneja added a comment -

            Hello. I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue.

            For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment

            If you have any information about this issue or a possible fix please post it here

            Show
            rajeshtaneja Rajesh Taneja added a comment - Hello. I will not be able to work on this issue in the immediate future. In order to create a truer sense of the state of this issue and to allow other developers to have chance to become involved, I am removing myself as the assignee of this issue. For more information, see http://docs.moodle.org/dev/Changes_to_issue_assignment If you have any information about this issue or a possible fix please post it here
            Hide
            marina Marina Glancy added a comment -

            Up for peer review. Note that this branch is based on MDL-50191

            Show
            marina Marina Glancy added a comment - Up for peer review. Note that this branch is based on MDL-50191
            Hide
            cibot CiBoT added a comment -

            Fails against automated checks.

            Checked MDL-28954 using repository: https://github.com/marinaglancy/moodle

            More information about this report

            Show
            cibot CiBoT added a comment - Fails against automated checks. Checked MDL-28954 using repository: https://github.com/marinaglancy/moodle MOODLE_29_STABLE (2 errors / 2 warnings) [branch: wip-MDL-28954-m29 | CI Job ] phplint (0/0) , php (1/2) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (1/0) , savepoint (0/0) , thirdparty (0/0) , More information about this report
            Hide
            lameze Simey Lameze added a comment -

            Hi Marina, thanks for work on this.

            1. I've noticed the you've added the same changes to the cohort/index.php here, is there any reason for that?
              I know this issue is blocked by the MDL-50191, but I think the patch should be rebased on top of those changes.
            2. Another point is few calls like this:

              cohort_update_cohort((object)array('id' => $data->id, 'description' => $data->description, 'contextid' => $context->id)); 
              

              Not against declare and pass an array as parameter, I'm not a great fan of forcing it as (object) there. Up to you.

            Rest looks good. Feel free to push for integration.

            Thanks.

            Show
            lameze Simey Lameze added a comment - Hi Marina, thanks for work on this. I've noticed the you've added the same changes to the cohort/index.php here, is there any reason for that? I know this issue is blocked by the MDL-50191 , but I think the patch should be rebased on top of those changes. Another point is few calls like this: cohort_update_cohort((object)array('id' => $data->id, 'description' => $data->description, 'contextid' => $context->id)); Not against declare and pass an array as parameter, I'm not a great fan of forcing it as (object) there. Up to you. Rest looks good. Feel free to push for integration. Thanks.
            Hide
            marina Marina Glancy added a comment -

            Thanks Simey, I change the (object)

            TO INTEGRATOR: please note that the first commit in the branches is from another issue that is blocking this

            Show
            marina Marina Glancy added a comment - Thanks Simey, I change the (object) TO INTEGRATOR: please note that the first commit in the branches is from another issue that is blocking this
            Show
            cibot CiBoT added a comment - Fails against automated checks. Checked MDL-28954 using repository: https://github.com/marinaglancy/moodle MOODLE_28_STABLE (2 errors / 2 warnings) [branch: wip-MDL-28954-m28 | CI Job ] phplint (0/0) , php (1/2) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (1/0) , savepoint (0/0) , thirdparty (0/0) , MOODLE_29_STABLE (2 errors / 2 warnings) [branch: wip-MDL-28954-m29 | CI Job ] phplint (0/0) , php (1/2) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (1/0) , savepoint (0/0) , thirdparty (0/0) , master (2 errors / 2 warnings) [branch: wip-MDL-28954-master | CI Job ] phplint (0/0) , php (1/2) , js (0/0) , css (0/0) , phpdoc (0/0) , commit (1/0) , savepoint (0/0) , thirdparty (0/0) , More information about this report
            Hide
            stronk7 Eloy Lafuente (stronk7) added a comment -

            The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

            TIA and ciao

            Show
            stronk7 Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao

              People

              • Votes:
                0 Vote for this issue
                Watchers:
                4 Start watching this issue

                Dates

                • Created:
                  Updated: