Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28957

Excessive logging overloads firebug logs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Libraries
    • Labels:
    • Testing Instructions:
      Hide

      already in bug. basically use firebug console on pretty much any moodle page. Before fix you'll see a constant stream of logs. After they'll stop after page load. Add a yui or console log some where in the js and see if you can find it in the console after the page has loaded. After the fix you should be able to. Before it just got pushed out of view by the new logs.

      Show
      already in bug. basically use firebug console on pretty much any moodle page. Before fix you'll see a constant stream of logs. After they'll stop after page load. Add a yui or console log some where in the js and see if you can find it in the console after the page has loaded. After the fix you should be able to. Before it just got pushed out of view by the new logs.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:

      Description

      The yui log call in yui/3.2.0/build/dom/dom-debug.js query() method

      Y.log('query: ' + selector + ' returning: ' + ret.length, 'info', 'Selector');

      Is called every time a dom query is made.This is a continual process while a moodle page is available and continually fills the firebug and chrome console logs.

      It's also a small memory leak if you leave a moodle page open for long enough or have many open.
      Any debugging using these consoles becomes impossible. Please comment out the line.

      Replication instructions:

      1. Open firebug on a course homepage.
      2. View the console with the 'all' log entries option selected. normally the console fills up and then states 'firebugs log limit has been reached xxxx entries not shown' This doesn't require you to do anything on the page.

      when fixed you'll see a lot of console entries on page load but then they'll stop. No more will appear until you do something on the page.

        Attachments

          Activity

            People

            • Assignee:
              colchambers Colin Chambers
              Reporter:
              colchambers Colin Chambers
              Peer reviewer:
              Tim Hunt
              Integrator:
              Eloy Lafuente (stronk7)
              Tester:
              Michael de Raadt
              Participants:
              Component watchers:
              Amaia Anabitarte, Bas Brands, Carlos Escobedo, Sara Arjona (@sarjona), Víctor Déniz Falcón
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:
                Fix Release Date:
                10/Oct/11