[MDL-28972] html_quickform_toggle_checkboxes use getElementsByClassName which is not supported by ie - Moodle Tracker

XML

Word

Printable

Testing Instructions:
Hide

Test needs to be done on IE, FF, chrome, Safari and any other browser you may have.
Test 1:
Use the attached test script.
When you click "select all/none", the checkbox state should toggle.
Disable JS, reload page and click "Select all/none"
Test 2:

Go to a course

Click on Settings > Grades

Click on Settings > Grade Administration > Export > Excel

In the Grade items to be included fieldset at the bottom, click Select all/none

checkbox should toggle

Try above with JS disabled.
Show
Test needs to be done on IE, FF, chrome, Safari and any other browser you may have. Test 1: Use the attached test script. When you click "select all/none", the checkbox state should toggle. Disable JS, reload page and click "Select all/none" Test 2: Go to a course Click on Settings > Grades Click on Settings > Grade Administration > Export > Excel In the Grade items to be included fieldset at the bottom, click Select all/none checkbox should toggle Try above with JS disabled.
Affected Branches:
MOODLE_20_STABLE, MOODLE_21_STABLE
Fixed Branches:
MOODLE_21_STABLE, MOODLE_22_STABLE
Pull from Repository:
git://github.com/rajeshtaneja/moodle.git
Pull Master Branch:
wip-mdl-28972
Pull Master Diff URL:
https://github.com/rajeshtaneja/moodle/compare/master...wip-mdl-28972

While testing ~~MDL-28737~~, it was observed that html_quickform_toggle_checkboxes is using getElementsByClassName. This is not supported in ie.

Message: Object doesn't support this property or method

Line: 14

Char: 5

Code: 0

URI: http://rajesh.moodle.local/moodle/test.php

has been marked as being related by

MDL-28737 advcheckboxes toggle their value every form submit in the presence of a checkbox_controller

is duplicated by

MDL-31467 Select All Checkboxes does not work in IE8