Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28972

html_quickform_toggle_checkboxes use getElementsByClassName which is not supported by ie

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1
    • Fix Version/s: 2.1.6, 2.2.3
    • Component/s: Forms Library
    • Labels:
    • Testing Instructions:
      Hide

      Test needs to be done on IE, FF, chrome, Safari and any other browser you may have.
      Test 1:
      Use the attached test script.
      When you click "select all/none", the checkbox state should toggle.
      Disable JS, reload page and click "Select all/none"
      Test 2:

      1. Go to a course
      2. Click on Settings > Grades
      3. Click on Settings > Grade Administration > Export > Excel
      4. In the Grade items to be included fieldset at the bottom, click Select all/none
      5. checkbox should toggle
      6. Try above with JS disabled.
      Show
      Test needs to be done on IE, FF, chrome, Safari and any other browser you may have. Test 1: Use the attached test script. When you click "select all/none", the checkbox state should toggle. Disable JS, reload page and click "Select all/none" Test 2: Go to a course Click on Settings > Grades Click on Settings > Grade Administration > Export > Excel In the Grade items to be included fieldset at the bottom, click Select all/none checkbox should toggle Try above with JS disabled.
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      wip-mdl-28972
    • Pull Master Diff URL:

      Description

      While testing MDL-28737, it was observed that html_quickform_toggle_checkboxes is using getElementsByClassName. This is not supported in ie.

      Message: Object doesn't support this property or method
      		 
      Line: 14
      		 
      Char: 5
      		 
      Code: 0
      		 
      URI: http://rajesh.moodle.local/moodle/test.php

        Attachments

          Issue Links

          has been marked as being related by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-28737 advcheckboxes toggle their value every form submit in the presence of a checkbox_controller

          • Minor - Minor loss of function where workaround is possible
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents Moodle from functioning correctly. MDL-31467 Select All Checkboxes does not work in IE8

          • Minor - Minor loss of function where workaround is possible
          • Closed

            Activity

              People

              Assignee:
              rajeshtaneja Rajesh Taneja
              Reporter:
              rajeshtaneja Rajesh Taneja
              Peer reviewer:
              Jason Fowler
              Integrator:
              Sam Hemelryk
              Tester:
              Adrian Greeve
              Participants:
              Component watchers:
              Adrian Greeve, Jake Dallimore, Mathew May, Mihail Geshoski, Peter Dias, Sujith Haridasan
              Votes:
              2 Vote for this issue
              Watchers:
              0 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:
                Fix Release Date:
                14/May/12