Moodle
  1. Moodle
  2. MDL-34696 enrol improvements 2.4 META
  3. MDL-28980

Students should be notified about manual enrolment expiration in advance

    Details

    • Testing Instructions:
      Hide

      1/ setup up a few courses with manually enrolled users with different expiration dates
      2/ set up expiration notification hour in enrol_manual settings and in course instances enable notification and set up thresholds
      3/ execute cron or enrol/manual/cli/sync.php script
      4/ verify mails and messages

      Note: you may want to modify value of last execution flag instead of waiting the whole day, such as by executing:

      set_config('notifylast', time()-(60*60*24), 'enrol_manual');
      
      Show
      1/ setup up a few courses with manually enrolled users with different expiration dates 2/ set up expiration notification hour in enrol_manual settings and in course instances enable notification and set up thresholds 3/ execute cron or enrol/manual/cli/sync.php script 4/ verify mails and messages Note: you may want to modify value of last execution flag instead of waiting the whole day, such as by executing: set_config('notifylast', time()-(60*60*24), 'enrol_manual');
    • Affected Branches:
      MOODLE_20_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w41_MDL-28980_m24_expirywarning
    • Rank:
      18534

      Description

      A highlighted in the discussion http://moodle.org/mod/forum/discuss.php?d=183354 and described by Tim in the dev chat:

      There is a feature where students get locked out of the course if they do not log in for X days. ('Unenrol inactive after' in self enrolment settings.) There used to be a feature where they got a warning email before that happened. (Enrolment expiry notification in 1.9.) That was a good feature. It should still be there in 2.x

        Issue Links

          Activity

          Helen Foster created issue -
          Petr Škoda made changes -
          Field Original Value New Value
          Assignee moodle.com [ moodle.com ] Petr Škoda (skodak) [ skodak ]
          Petr Škoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Michael de Raadt made changes -
          Issue Type Bug [ 1 ] New Feature [ 2 ]
          Fix Version/s DEV backlog [ 10464 ]
          Labels triaged
          Hide
          Chad Outten added a comment -

          just to clarify requirement - this expiry notification function should be present for manual and self-enrolment plugins.

          Show
          Chad Outten added a comment - just to clarify requirement - this expiry notification function should be present for manual and self-enrolment plugins.
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Open [ 1 ]
          Hide
          Stuart R Mealor added a comment - - edited

          Why is this designated as a New Feature type - when it has been core for a long time?
          I'm worried this will be pushed lower down the priority list because of this
          Suggest this should be higher than a "Minor" priority
          DevBacklog: "Issues confirmed by triage to be resolved for the next major release"
          So this means it is fixed for 2.2, so not available until end of year?
          Anyone confirm my thinking is correct???

          Show
          Stuart R Mealor added a comment - - edited Why is this designated as a New Feature type - when it has been core for a long time? I'm worried this will be pushed lower down the priority list because of this Suggest this should be higher than a "Minor" priority DevBacklog: "Issues confirmed by triage to be resolved for the next major release" So this means it is fixed for 2.2, so not available until end of year? Anyone confirm my thinking is correct???
          Hide
          Natalie Denmeade added a comment -

          Is it possible to have the expiry notification as a seperate feature rather than being linked to the number of days inactive?

          If a student has paid for a six month enrolment due to expire on say Nov 2, an email a month before on Oct 2nd to both teacher and student would be helpful in meeting dealines. Whether they had been active or not is irrelevant.

          Show
          Natalie Denmeade added a comment - Is it possible to have the expiry notification as a seperate feature rather than being linked to the number of days inactive? If a student has paid for a six month enrolment due to expire on say Nov 2, an email a month before on Oct 2nd to both teacher and student would be helpful in meeting dealines. Whether they had been active or not is irrelevant.
          Hide
          Helen Foster added a comment -

          Adding a link to a discussion about the missing enrolment expiry settings which mentions that emails are still being sent!
          http://moodle.org/mod/forum/discuss.php?d=197733

          Show
          Helen Foster added a comment - Adding a link to a discussion about the missing enrolment expiry settings which mentions that emails are still being sent! http://moodle.org/mod/forum/discuss.php?d=197733
          Hide
          Micah Meisburg added a comment -

          I second Natalie's comment, and Stuart's that this should be higher than minor priority. Could this possibly receive attention to be fixed in 2.3? It is a "new feature" but is also somewhat of a bug fix for us because expiry notifications are still being sent out to our students since upgrading from 1.9, yet we are now unable to control the threshold of days that these emails are sent out.

          We are needing some ability to control this feature that was previously available in 1.9.

          Thanks very much

          Show
          Micah Meisburg added a comment - I second Natalie's comment, and Stuart's that this should be higher than minor priority. Could this possibly receive attention to be fixed in 2.3? It is a "new feature" but is also somewhat of a bug fix for us because expiry notifications are still being sent out to our students since upgrading from 1.9, yet we are now unable to control the threshold of days that these emails are sent out. We are needing some ability to control this feature that was previously available in 1.9. Thanks very much
          Hide
          Petr Škoda added a comment -

          Hello, my current priorities are:
          1/ phpunit support
          2/ full enrolment restore support
          3/ the rest of enrol+auth issues if I manage 1/ and 2/ before the 2.3 freeze

          Show
          Petr Škoda added a comment - Hello, my current priorities are: 1/ phpunit support 2/ full enrolment restore support 3/ the rest of enrol+auth issues if I manage 1/ and 2/ before the 2.3 freeze
          Helen Foster made changes -
          Labels triaged lost_functionality triaged
          Martin Dougiamas made changes -
          Labels lost_functionality triaged lost_functionality partner triaged
          Hide
          Martin Dougiamas added a comment -

          Switching it to "task" rather than "new feature" as it's actually a regression from the refactor in 2.x.

          Show
          Martin Dougiamas added a comment - Switching it to "task" rather than "new feature" as it's actually a regression from the refactor in 2.x.
          Martin Dougiamas made changes -
          Issue Type New Feature [ 2 ] Task [ 3 ]
          Priority Minor [ 4 ] Major [ 3 ]
          Adam Olley made changes -
          Labels lost_functionality partner triaged lost_functionality netspot partner triaged
          Petr Škoda made changes -
          Parent MDL-34696 [ 57979 ]
          Rank (Obsolete) 170980000000
          Issue Type Task [ 3 ] Sub-task [ 5 ]
          Hide
          Ray Lawrence added a comment -

          Hi,

          This will be an issue for us with some upcoming 1.9 > 2.2/3 migrations. Petr where does it sit with your current priorities?

          Show
          Ray Lawrence added a comment - Hi, This will be an issue for us with some upcoming 1.9 > 2.2/3 migrations. Petr where does it sit with your current priorities?
          Ray Lawrence made changes -
          Labels lost_functionality netspot partner triaged howtomoodle lost_functionality netspot partner triaged
          Hide
          Petr Škoda added a comment -

          Hi, yes, this is my priority for 2.4, it will be implemented this or the next week.

          Show
          Petr Škoda added a comment - Hi, yes, this is my priority for 2.4, it will be implemented this or the next week.
          Hide
          Ray Lawrence added a comment -

          Thanks. Are you planing to address this for 2.2 and 2.3? Owing to the current speed issues in 2.3 the upgrades are likely to be to 2.2 initially and then 2.3 as soon as it's sensible to do so. A fix for 2.4 only effectively pushes resolution for clients into 2013.

          Show
          Ray Lawrence added a comment - Thanks. Are you planing to address this for 2.2 and 2.3? Owing to the current speed issues in 2.3 the upgrades are likely to be to 2.2 initially and then 2.3 as soon as it's sensible to do so. A fix for 2.4 only effectively pushes resolution for clients into 2013.
          Hide
          Petr Škoda added a comment -

          I do not know yet how it will be implemented, so I can not tell if it will be suitable for backporting or not, sorry.

          Show
          Petr Škoda added a comment - I do not know yet how it will be implemented, so I can not tell if it will be suitable for backporting or not, sorry.
          Hide
          Ray Lawrence added a comment -

          Ok, thanks for the update.

          Show
          Ray Lawrence added a comment - Ok, thanks for the update.
          Petr Škoda made changes -
          Status Open [ 1 ] Development in progress [ 3 ]
          Petr Škoda made changes -
          Pull Master Diff URL https://github.com/skodak/moodle/compare/master...w41_MDL-28980_m24_expirywarning
          Summary Students should receive email notification before being automatically unenrolled Students should be notified about manual enrolment expiration in advance
          Pull Master Branch w41_MDL-28980_m24_expirywarning
          Fix Version/s 2.4 [ 12255 ]
          Fix Version/s DEV backlog [ 10464 ]
          Testing Instructions 1/ setup up a few courses with manually enrolled users with expiration dates
          2/ set up expiration notification in enrol_manual settings and in course instances
          3/ execute cron or enrol/manual/cli/sync.php script
          4/ verify mails and messages

          Note: you may way to modify value last execution flag instead of waiting the whole day, such as by executing set_config('notifylast', time()-(60*60*24), 'enrol_manual');
          Pull from Repository git://github.com/skodak/moodle.git
          Hide
          Petr Škoda added a comment -

          Helen: could you please review the new lang strings? Thanks.

          Show
          Petr Škoda added a comment - Helen: could you please review the new lang strings? Thanks.
          Petr Škoda made changes -
          Status Development in progress [ 3 ] Waiting for integration review [ 10010 ]
          Petr Škoda made changes -
          Link This issue has been marked as being related by MDL-35843 [ MDL-35843 ]
          Sam Hemelryk made changes -
          Currently in integration Yes [ 10041 ]
          Hide
          Helen Foster added a comment -

          Petr, thanks for asking me to review the new language strings in enrol/manual/lang/en/enrol_manual.php. My suggested improvements are as follows:

          $string['expirymessageenrollerbody'] = 'Enrolment in the course \'{$a->course}\' will expire within the next {$a->threshold} for the following users:

          {$a->users}

          To extend their enrolment, go to {$a->extendurl}';

          $string['expirymessageenrolledbody'] = 'Dear {$a->user},

          This is a notification that your enrolment in the course \'{$a->course}\' is due to expire on {$a->timeend}.

          If you need help, please contact {$a->enroller}.';

          $string['expirynotify'] = 'Notify before enrolment expires';

          $string['expirynotify_help'] = 'This setting determines whether enrolment expiry notification messages are sent.';

          +$string['expirythreshold_help'] = 'This setting specifies the number of days before enrolment expiry that a notification message is sent.';

          $string['messageprovider:expiry_notification'] = 'Manual enrolment expiry notifications';

          $string['notifyhour'] = 'Hour to send enrolment expiry notifications';

          I don't think we need the strings notifyhour_desc, expirynotify_desc and expirythreshold_desc, since the strings notifyhour, expirynotify and expirythreshold seem self-explanatory, also settings appear under the heading 'Enrolment instance defaults' so no need to mention that they are default settings.

          Show
          Helen Foster added a comment - Petr, thanks for asking me to review the new language strings in enrol/manual/lang/en/enrol_manual.php. My suggested improvements are as follows: $string ['expirymessageenrollerbody'] = 'Enrolment in the course \'{$a->course}\' will expire within the next {$a->threshold} for the following users: {$a->users} To extend their enrolment, go to {$a->extendurl}'; $string ['expirymessageenrolledbody'] = 'Dear {$a->user}, This is a notification that your enrolment in the course \'{$a->course}\' is due to expire on {$a->timeend}. If you need help, please contact {$a->enroller}.'; $string ['expirynotify'] = 'Notify before enrolment expires'; $string ['expirynotify_help'] = 'This setting determines whether enrolment expiry notification messages are sent.'; +$string ['expirythreshold_help'] = 'This setting specifies the number of days before enrolment expiry that a notification message is sent.'; $string ['messageprovider:expiry_notification'] = 'Manual enrolment expiry notifications'; $string ['notifyhour'] = 'Hour to send enrolment expiry notifications'; I don't think we need the strings notifyhour_desc, expirynotify_desc and expirythreshold_desc, since the strings notifyhour, expirynotify and expirythreshold seem self-explanatory, also settings appear under the heading 'Enrolment instance defaults' so no need to mention that they are default settings.
          Hide
          Helen Foster added a comment -

          Notes from a chat with Petr about how the enroller is set:

          It looks at enrolled users with the enrolment manage capability and selects the one with highest "authority" (logic taken from 1.9), usually the first editing teacher.

          A possible improvement (for another issue) would be to be able to select a user as enroller.

          Show
          Helen Foster added a comment - Notes from a chat with Petr about how the enroller is set: It looks at enrolled users with the enrolment manage capability and selects the one with highest "authority" (logic taken from 1.9), usually the first editing teacher. A possible improvement (for another issue) would be to be able to select a user as enroller.
          Hide
          Petr Škoda added a comment -

          I have updated the strings, thanks a lot.

          Show
          Petr Škoda added a comment - I have updated the strings, thanks a lot.
          Petr Škoda made changes -
          Testing Instructions 1/ setup up a few courses with manually enrolled users with expiration dates
          2/ set up expiration notification in enrol_manual settings and in course instances
          3/ execute cron or enrol/manual/cli/sync.php script
          4/ verify mails and messages

          Note: you may way to modify value last execution flag instead of waiting the whole day, such as by executing set_config('notifylast', time()-(60*60*24), 'enrol_manual');
          1/ setup up a few courses with manually enrolled users with different expiration dates
          2/ set up expiration notification hour in enrol_manual settings and in course instances enable notification and set up thresholds
          3/ execute cron or enrol/manual/cli/sync.php script
          4/ verify mails and messages

          Note: you may want to modify value of last execution flag instead of waiting the whole day, such as by executing:
          {code}
          set_config('notifylast', time()-(60*60*24), 'enrol_manual');
          {code}
          Eloy Lafuente (stronk7) made changes -
          Labels howtomoodle lost_functionality netspot partner triaged docs_required howtomoodle lost_functionality netspot partner triaged ui_change
          Eloy Lafuente (stronk7) made changes -
          Labels docs_required howtomoodle lost_functionality netspot partner triaged ui_change docs_required howtomoodle lost_functionality netspot partner qa_test_required triaged ui_change
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Please could you specify a bit more:

          • The meaning of some params in the notify_xxx() methods.
          • Who is going to receive notifications, when and with which frequency (per enrolid, per course, per user...)...

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Please could you specify a bit more: The meaning of some params in the notify_xxx() methods. Who is going to receive notifications, when and with which frequency (per enrolid, per course, per user...)... Ciao
          Hide
          Petr Škoda added a comment -

          done, thanks Eloy.

          Show
          Petr Škoda added a comment - done, thanks Eloy.
          Hide
          Doug added a comment -

          One question. Will this also apply to people using PayPal to enroll? It should.

          Doug

          Show
          Doug added a comment - One question. Will this also apply to people using PayPal to enroll? It should. Doug
          Hide
          Petr Škoda added a comment -

          This code is not related to PayPal enrolment plugin at all, sorry.

          Show
          Petr Škoda added a comment - This code is not related to PayPal enrolment plugin at all, sorry.
          Hide
          Doug added a comment -

          Hello,

          Thanks for the update. One question, I keep seeing folks refer to PayPal as a plugin. Is it a plugin? In moodle 2.0 and newer I believe it is part of the core. I am I wrong?

          Doug

          Show
          Doug added a comment - Hello, Thanks for the update. One question, I keep seeing folks refer to PayPal as a plugin. Is it a plugin? In moodle 2.0 and newer I believe it is part of the core. I am I wrong? Doug
          Hide
          Petr Škoda added a comment -

          PayPal enrolment plugin code is located in /enrol/paypal/*, it is completely separate from all other enrolment plugins. Changes in other enrolment plugins do not affect it at all.

          Show
          Petr Škoda added a comment - PayPal enrolment plugin code is located in /enrol/paypal/*, it is completely separate from all other enrolment plugins. Changes in other enrolment plugins do not affect it at all.
          Eloy Lafuente (stronk7) made changes -
          Status Waiting for integration review [ 10010 ] Integration review in progress [ 10004 ]
          Integrator stronk7
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Integrated, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
          Eloy Lafuente (stronk7) made changes -
          Status Integration review in progress [ 10004 ] Waiting for testing [ 10005 ]
          Tim Barker made changes -
          Tester timb
          Tim Barker made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Tim Barker made changes -
          Tester timb markn86
          Tim Barker made changes -
          Status Testing in progress [ 10011 ] Waiting for testing [ 10005 ]
          Mark Nelson made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          Mark Nelson added a comment -

          The output when running the test was as follows -

          notifying user 3 that enrolment in course 6 expires on Wednesday, 10 October 2012, 3:05 PM
          notifying user 4 that enrolment in course 6 expires on Wednesday, 10 October 2012, 4:05 PM
          notifying user 2 about all expiring manual enrolments in course 7
          notifying user 5 that enrolment in course 7 expires on Wednesday, 10 October 2012, 3:05 PM
          notifying user 6 that enrolment in course 7 expires on Wednesday, 10 October 2012, 4:10 PM
          notifying user 2 about all expiring manual enrolments in course 7

          It repeats the message about notifying user 2 (the Admin user) about course 7, which I do receive. However, I never receive an email regarding course 6.

          Show
          Mark Nelson added a comment - The output when running the test was as follows - notifying user 3 that enrolment in course 6 expires on Wednesday, 10 October 2012, 3:05 PM notifying user 4 that enrolment in course 6 expires on Wednesday, 10 October 2012, 4:05 PM notifying user 2 about all expiring manual enrolments in course 7 notifying user 5 that enrolment in course 7 expires on Wednesday, 10 October 2012, 3:05 PM notifying user 6 that enrolment in course 7 expires on Wednesday, 10 October 2012, 4:10 PM notifying user 2 about all expiring manual enrolments in course 7 It repeats the message about notifying user 2 (the Admin user) about course 7, which I do receive. However, I never receive an email regarding course 6.
          Mark Nelson made changes -
          Status Testing in progress [ 10011 ] Problem during testing [ 10007 ]
          Hide
          Petr Škoda added a comment -

          Strange, the debug messages are printed correct after verifying result of sending of message - that means if there is any problem it is not in my code, it can be a bug in messaging layer, spam filtering, etc.

          I am afraid I can not do anything about this, sorry.

          Show
          Petr Škoda added a comment - Strange, the debug messages are printed correct after verifying result of sending of message - that means if there is any problem it is not in my code, it can be a bug in messaging layer, spam filtering, etc. I am afraid I can not do anything about this, sorry.
          Hide
          Petr Škoda added a comment -

          Oh, the repeated 2-7 is a bug of course, fixing...

          Show
          Petr Škoda added a comment - Oh, the repeated 2-7 is a bug of course, fixing...
          Hide
          Petr Škoda added a comment -

          arrrgh, I found the other bug with different course id too, testing patch, sorrrry.

          Show
          Petr Škoda added a comment - arrrgh, I found the other bug with different course id too, testing patch, sorrrry.
          Hide
          Petr Škoda added a comment -

          two extra commits submitted, thanks a lot for spotting this!

          Show
          Petr Škoda added a comment - two extra commits submitted, thanks a lot for spotting this!
          Hide
          Eloy Lafuente (stronk7) added a comment -

          new 2 commits added. Sending back to testing, thanks!

          Show
          Eloy Lafuente (stronk7) added a comment - new 2 commits added. Sending back to testing, thanks!
          Eloy Lafuente (stronk7) made changes -
          Status Problem during testing [ 10007 ] Waiting for testing [ 10005 ]
          Mark Nelson made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          Mark Nelson added a comment -

          Passed. The latest commits fixed the issue found earlier.

          Show
          Mark Nelson added a comment - Passed. The latest commits fixed the issue found earlier.
          Mark Nelson made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Aparup Banerjee added a comment -

          setting back to testing for Mark

          Show
          Aparup Banerjee added a comment - setting back to testing for Mark
          Aparup Banerjee made changes -
          Status Tested [ 10006 ] Problem during testing [ 10007 ]
          Hide
          Mark Nelson added a comment -

          Sorry Petr, I wanted to test with more than 2 courses just to make sure and decided to re-test and found an issue. I added a new course and enrolled a user setting their expiry to happen in roughly an hour. I then ran the cron and received. (Note, this is with set_config('notifylast', time()-(60*60*24), 'enrol_manual') being executed after every cron)

          notifying user 3 that enrolment in course 6 expires on Wednesday, 10 October 2012, 5:00 PM
          notifying user 4 that enrolment in course 6 expires on Wednesday, 10 October 2012, 5:05 PM
          notifying user 2 about all expiring manual enrolments in course 6
          notifying user 5 that enrolment in course 7 expires on Wednesday, 10 October 2012, 5:00 PM
          notifying user 6 that enrolment in course 7 expires on Wednesday, 10 October 2012, 5:10 PM
          notifying user 2 about all expiring manual enrolments in course 7
          notifying user 7 that enrolment in course 8 expires on Wednesday, 10 October 2012, 6:30 PM
          notifying user 2 about all expiring manual enrolments in course 8
          notifying user 2 about all expiring manual enrolments in course 9

          The user in course 9 never receives an email, only the administrator saying that the user will expire. I then went into the course settings for the manual enrolment plugin (enrol/manual/edit.php?courseid=9) and saw that the 'Enroller and enrolled user' was set to receive the message. I then confirmed that '2' was the value for expirynotify for this enrolment instance in the enrol table. I then clicked 'saved' and viewed the expirynotify column again to confirm and saw that it changed to '1'! I then ran the cron and received the email for that student, see below -

          notifying user 3 that enrolment in course 6 expires on Wednesday, 10 October 2012, 5:00 PM
          notifying user 4 that enrolment in course 6 expires on Wednesday, 10 October 2012, 5:05 PM
          notifying user 2 about all expiring manual enrolments in course 6
          notifying user 5 that enrolment in course 7 expires on Wednesday, 10 October 2012, 5:00 PM
          notifying user 6 that enrolment in course 7 expires on Wednesday, 10 October 2012, 5:10 PM
          notifying user 2 about all expiring manual enrolments in course 7
          notifying user 7 that enrolment in course 8 expires on Wednesday, 10 October 2012, 6:30 PM
          notifying user 2 about all expiring manual enrolments in course 8
          notifying user 7 that enrolment in course 9 expires on Wednesday, 10 October 2012, 5:50 PM
          notifying user 2 about all expiring manual enrolments in course 9

          Show
          Mark Nelson added a comment - Sorry Petr, I wanted to test with more than 2 courses just to make sure and decided to re-test and found an issue. I added a new course and enrolled a user setting their expiry to happen in roughly an hour. I then ran the cron and received. (Note, this is with set_config('notifylast', time()-(60*60*24), 'enrol_manual') being executed after every cron) notifying user 3 that enrolment in course 6 expires on Wednesday, 10 October 2012, 5:00 PM notifying user 4 that enrolment in course 6 expires on Wednesday, 10 October 2012, 5:05 PM notifying user 2 about all expiring manual enrolments in course 6 notifying user 5 that enrolment in course 7 expires on Wednesday, 10 October 2012, 5:00 PM notifying user 6 that enrolment in course 7 expires on Wednesday, 10 October 2012, 5:10 PM notifying user 2 about all expiring manual enrolments in course 7 notifying user 7 that enrolment in course 8 expires on Wednesday, 10 October 2012, 6:30 PM notifying user 2 about all expiring manual enrolments in course 8 notifying user 2 about all expiring manual enrolments in course 9 The user in course 9 never receives an email, only the administrator saying that the user will expire. I then went into the course settings for the manual enrolment plugin (enrol/manual/edit.php?courseid=9) and saw that the 'Enroller and enrolled user' was set to receive the message. I then confirmed that '2' was the value for expirynotify for this enrolment instance in the enrol table. I then clicked 'saved' and viewed the expirynotify column again to confirm and saw that it changed to '1'! I then ran the cron and received the email for that student, see below - notifying user 3 that enrolment in course 6 expires on Wednesday, 10 October 2012, 5:00 PM notifying user 4 that enrolment in course 6 expires on Wednesday, 10 October 2012, 5:05 PM notifying user 2 about all expiring manual enrolments in course 6 notifying user 5 that enrolment in course 7 expires on Wednesday, 10 October 2012, 5:00 PM notifying user 6 that enrolment in course 7 expires on Wednesday, 10 October 2012, 5:10 PM notifying user 2 about all expiring manual enrolments in course 7 notifying user 7 that enrolment in course 8 expires on Wednesday, 10 October 2012, 6:30 PM notifying user 2 about all expiring manual enrolments in course 8 notifying user 7 that enrolment in course 9 expires on Wednesday, 10 October 2012, 5:50 PM notifying user 2 about all expiring manual enrolments in course 9
          Hide
          Petr Škoda added a comment -

          there are two columns in enrol table controlled by one form select element - the database value should be always 1 or 0 for both fields.

          reviewing and testing...

          Show
          Petr Škoda added a comment - there are two columns in enrol table controlled by one form select element - the database value should be always 1 or 0 for both fields. reviewing and testing...
          Hide
          Petr Škoda added a comment -

          found it! the problem is in adding of default instance, fixing...

          Show
          Petr Škoda added a comment - found it! the problem is in adding of default instance, fixing...
          Hide
          Petr Škoda added a comment -

          push fixed to my repo, sorry for all these problems...

          Show
          Petr Škoda added a comment - push fixed to my repo, sorry for all these problems...
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Back to testing (thanks Petr and Mark).

          Show
          Eloy Lafuente (stronk7) added a comment - Back to testing (thanks Petr and Mark).
          Eloy Lafuente (stronk7) made changes -
          Status Problem during testing [ 10007 ] Waiting for testing [ 10005 ]
          Mark Nelson made changes -
          Status Waiting for testing [ 10005 ] Testing in progress [ 10011 ]
          Hide
          Mark Nelson added a comment -

          Issue now resolved. Passed.

          Show
          Mark Nelson added a comment - Issue now resolved. Passed.
          Mark Nelson made changes -
          Status Testing in progress [ 10011 ] Tested [ 10006 ]
          Hide
          Eloy Lafuente (stronk7) added a comment -

          From somewhere within the clouds...

          Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration!

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - From somewhere within the clouds... Congrats, this has been sent upstream and is now part of Moodle (your favorite LMS platform). Many thanks for your awesome collaboration! Ciao
          Eloy Lafuente (stronk7) made changes -
          Status Tested [ 10006 ] Closed [ 6 ]
          Resolution Fixed [ 1 ]
          Currently in integration Yes [ 10041 ]
          Integration date 14/Oct/12
          Hide
          Ben Sommerville added a comment -

          Is this likely to be backported to 2.3?

          thanks

          Show
          Ben Sommerville added a comment - Is this likely to be backported to 2.3? thanks
          Mary Cooch made changes -
          Labels docs_required howtomoodle lost_functionality netspot partner qa_test_required triaged ui_change howtomoodle lost_functionality netspot partner qa_test_required triaged ui_change
          Hide
          Mary Cooch added a comment -

          Removing docs_required label as this has been documented by Petr here http://docs.moodle.org/24/en/Manual_enrolment

          Show
          Mary Cooch added a comment - Removing docs_required label as this has been documented by Petr here http://docs.moodle.org/24/en/Manual_enrolment
          Hide
          Rok Lenardic added a comment -

          The link to the changeset above is broken (https://github.com/skodak/moodle/compare/master...w41_MDL-28980_m24_expirywarning)

          any chance of getting a full list of changesets that implemented this fix so we can try to backport to 2.2?

          Show
          Rok Lenardic added a comment - The link to the changeset above is broken ( https://github.com/skodak/moodle/compare/master...w41_MDL-28980_m24_expirywarning ) any chance of getting a full list of changesets that implemented this fix so we can try to backport to 2.2?
          Hide
          Petr Škoda added a comment -

          The links above were intended for integration only, please use git to find commits relevant to any closed "MDL-xxxxx" issue.

          Show
          Petr Škoda added a comment - The links above were intended for integration only, please use git to find commits relevant to any closed "MDL-xxxxx" issue.
          Hide
          Mark Nelson added a comment -

          Rok, to find commits related to this issue type "git log --grep=MDL-28980" in command line, then "git show #commithash" to view the commit of your choice.

          Show
          Mark Nelson added a comment - Rok, to find commits related to this issue type "git log --grep= MDL-28980 " in command line, then "git show #commithash" to view the commit of your choice.

            People

            • Votes:
              42 Vote for this issue
              Watchers:
              22 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: