Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28981

Forum's forum_make_mail_html() doesn't call forum_user_can_post() properly

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Trivial
    • Resolution: Fixed
    • Affects Version/s: 2.0.4, 2.1.1, 2.2
    • Fix Version/s: 2.0.5, 2.1.2
    • Component/s: Forum
    • Labels:
    • Testing Instructions:
      Hide

      1/ create a custom script that does calls forum_make_mail_html() with and without the extra parameters
      2/ verify the result is the same

      Show
      1/ create a custom script that does calls forum_make_mail_html() with and without the extra parameters 2/ verify the result is the same
    • Difficulty:
      Easy
    • Affected Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_20_STABLE, MOODLE_21_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      w33_MDL-28981_m22_canpost

      Description

      I was doing some testing with messaging and when I called forum_make_mail_html() then forum_user_can_post() complained about the $cm and $course not being passed (debug messages). Easy fix, just pass both of those from forum_make_mail_html(), should also help with performance (big win here since these are called on the cron).

        Attachments

          Activity

            People

            Assignee:
            skodak Petr Skoda
            Reporter:
            bushido Mark Nielsen
            Integrator:
            Eloy Lafuente (stronk7)
            Tester:
            Eloy Lafuente (stronk7)
            Participants:
            Component watchers:
            Andrew Nicols, Jun Pataleta, Michael Hawkins, Shamim Rezaie, Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:
              Fix Release Date:
              10/Oct/11