Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-28981

Forum's forum_make_mail_html() doesn't call forum_user_can_post() properly

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Trivial
    • 2.0.5, 2.1.2
    • 2.0.4, 2.1.1, 2.2
    • Forum
    • MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
    • MOODLE_20_STABLE, MOODLE_21_STABLE
    • w33_MDL-28981_m22_canpost
    • Easy
    • Hide

      1/ create a custom script that does calls forum_make_mail_html() with and without the extra parameters
      2/ verify the result is the same

      Show
      1/ create a custom script that does calls forum_make_mail_html() with and without the extra parameters 2/ verify the result is the same

    Description

      I was doing some testing with messaging and when I called forum_make_mail_html() then forum_user_can_post() complained about the $cm and $course not being passed (debug messages). Easy fix, just pass both of those from forum_make_mail_html(), should also help with performance (big win here since these are called on the cron).

      Attachments

        Activity

          People

            skodak Petr Skoda (Inactive)
            bushido Mark Nielsen
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Clockify

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.