Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1, 2.2
    • Fix Version/s: 2.1.2
    • Component/s: Web Services
    • Labels:
    • Testing Instructions:
      Hide

      Please, test this under 21_STABLE:

      Go to Admin block > Plugins > Web services > Overview
      Check there is a mobile section explaining how to activate the web service for mobile.
      The status should match the one in Admin block > Plugins > Web services > Manage services. Check for when the mobile service is enabled and disabled.

      Show
      Please, test this under 21_STABLE: Go to Admin block > Plugins > Web services > Overview Check there is a mobile section explaining how to activate the web service for mobile. The status should match the one in Admin block > Plugins > Web services > Manage services. Check for when the mobile service is enabled and disabled.
    • Affected Branches:
      MOODLE_21_STABLE, MOODLE_22_STABLE
    • Fixed Branches:
      MOODLE_21_STABLE
    • Pull Master Branch:
    • Rank:
      18680

      Description

      Add a mobile section to the "web service overview" admin page.

        Issue Links

          Activity

          Hide
          Dongsheng Cai added a comment -

          1 minor thing:
          We don't use
          new object()

          we use

          new stdClass();

          from coding style doc page:

          Before Moodle 2.0, we used to define a class object extending stdClass, and use new object(); This has now been deprecated. Please use stdClass instead.

          Show
          Dongsheng Cai added a comment - 1 minor thing: We don't use new object() we use new stdClass(); from coding style doc page: Before Moodle 2.0, we used to define a class object extending stdClass, and use new object(); This has now been deprecated. Please use stdClass instead.
          Hide
          Jérôme Mouneyrac added a comment -

          Thanks Dongsheng. Submitting for integration now.

          Show
          Jérôme Mouneyrac added a comment - Thanks Dongsheng. Submitting for integration now.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Not sure why this is backported to 21_STABLE when was in the DEV backlog, but I've assumed you have decided about that there.

          Also, the "mobilewsdisabled/enabled" strings surprised me a bit. Why cannot be simple disabled/enabled, can be missunderstood in any language? Note we have already active/inactive in moodle.php. For your consideration (in a separate issue).

          Ciao

          Show
          Eloy Lafuente (stronk7) added a comment - Not sure why this is backported to 21_STABLE when was in the DEV backlog, but I've assumed you have decided about that there. Also, the "mobilewsdisabled/enabled" strings surprised me a bit. Why cannot be simple disabled/enabled, can be missunderstood in any language? Note we have already active/inactive in moodle.php. For your consideration (in a separate issue). Ciao
          Hide
          Andrew Davis added a comment -

          Ive raised MDL-29103 to fix up some strings.

          Show
          Andrew Davis added a comment - Ive raised MDL-29103 to fix up some strings.
          Hide
          Andrew Davis added a comment -

          Test passed fine in both 2.1 stable and master aside from the string issues in the linked issue.

          Show
          Andrew Davis added a comment - Test passed fine in both 2.1 stable and master aside from the string issues in the linked issue.
          Hide
          Eloy Lafuente (stronk7) added a comment -

          Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

          Show
          Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

            People

            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: