Thanks for raising this.

I tested this and I was able to enter a value that was not unique when a unique value was expected (which was bad), but that was the only sort of validation that I could think to test. What kind of validation are you expecting?

In our case we also validate for uniqueness, which we cannot get to work (non-unique entries are accepted and stored).

OK. I've updated the summary of this issue and bumped the priority.

Obviously the code to validate uniqueness of the field exists, but it is not being applied correctly.

In the meantime feel free to help us work on this issue.

Hi,
The signup form was missing the call to function that is responsible for validating customisable profile fields. Besides that the signup validation function handels submitted data as an array where is its handeled as an object at other places (profile edit), so I had to convert and use the submitted data. It might be a good idea to make this consistent in another improvment MDL.
submitting for review.
Thanks

Sorry for the delay in peer review..

Looks good to me. I would have just cast the object in the function but that is not important - please submit for integration!

Thanks Dan for the review.
Submitting for integration
Thanks

Some hours ago...

the main moodle.git repository has been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Thanks Ankit - this has been integrated now

Did you test it with debug mode enabled? The user->id does not exist yet during signup validation, but the code tries to use it.

Hi Petr,
Thanks for pointing that out, not sure how it passed my testing. Anyways had a chat with Dan about this and I have set user->id to 0 since thats the default value used in profile_base_class as well.

Submitting again.
Thanks

Thanks for spotting that Petr and thanks Ankit for getting a fix up for it.
I was two minds about whether it should be using 0 or -1 however when looking through code I see that it won't actually make any difference. (Was looking at -1 as that is what other uses of profile_validation are using).

Up for testing again

Cheers
Sam

Thanks Ankit, Works great

Few things noticed, while testing this:

1. profile_field_base::edit_validate_field has one argument but when called from profile_validation it pass two arguments.
2. profile_field_base::edit_validate_field for loop seems redundant, same logic can be used in sql to get unique values which current not entered by this user.

Let me know if you want me to open issues for same.

FCT (fixed, closing, thanks). Ciao

"I feel a very unusual sensation - if it is not indigestion, I think it must be gratitude!"
~ Benjamin Disraeli