Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29001

Remove timezone test fixtures which depend on setting date_default_timezone_set('Australia/Perth');

    Details

    • Testing Instructions:
      Hide

      1. Update timezones (site admin -> location -> Update timezones)
      2. Navigate to unit test (Reports -> unit test)
      3. enter "lib/simpletest/testmoodlelib.php" in textbox.
      4. click "Run test"
      5. Make sure all test pass

      Show
      1. Update timezones (site admin -> location -> Update timezones) 2. Navigate to unit test (Reports -> unit test) 3. enter "lib/simpletest/testmoodlelib.php" in textbox. 4. click "Run test" 5. Make sure all test pass
    • Affected Branches:
      MOODLE_19_STABLE
    • Fixed Branches:
      MOODLE_19_STABLE

      Description

      In MDL-27863, we can't use date_default_timezone_set('Australia/Perth'); for 1.9 as this api was introduced in 5.1.0
      So please remove all text fixtures which require default timezone to be Australia/Perth

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

              Hide
              rwijaya Rossiani Wijaya added a comment -

              Patch looks great Raj.

              Show
              rwijaya Rossiani Wijaya added a comment - Patch looks great Raj.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Integrated, thanks!

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Integrated, thanks!
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              1/1 test cases complete: 117 passes, 0 fails and 0 exceptions.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - 1/1 test cases complete: 117 passes, 0 fails and 0 exceptions.
              Hide
              stronk7 Eloy Lafuente (stronk7) added a comment -

              Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

              Show
              stronk7 Eloy Lafuente (stronk7) added a comment - Many thanks for the hard work, this has been sent upstream and is available in all the git and cvs repositories.

                People

                • Votes:
                  0 Vote for this issue
                  Watchers:
                  1 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    10/Oct/11