Moodle

In hub directory listings, remove "Sites/Courses" counts and replace with "Courses for download: X" and "Courses for enrolling: Y"

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 2.0.4, 2.1.1, 2.2
  • Fix Version/s: 2.0.5, 2.1.2
  • Component/s: Hub
  • Labels:
  • Testing Instructions:
    Hide

    1. Add community finder block
    2. Click on Search link
    3. Check that Mooch does display correct enrollable+downloadable numbers. (Note: if a hub hasn't been updated, the enrollable+downloadable numbers should display 0. All other hubs most likely will display 0)

    Show
    1. Add community finder block 2. Click on Search link 3. Check that Mooch does display correct enrollable+downloadable numbers. (Note: if a hub hasn't been updated, the enrollable+downloadable numbers should display 0. All other hubs most likely will display 0)
  • Affected Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE, MOODLE_22_STABLE
  • Fixed Branches:
    MOODLE_20_STABLE, MOODLE_21_STABLE
  • Pull from Repository:
  • Pull Master Branch:
  • Pull Master Diff URL:

Description

In hub directory listings, remove "Sites" count and replace with "Courses for download: X" and "Courses for enrolling: Y"

Also need to be fixed for hub listing in community finder. Test that not updated 2.0 site still work even though hub directory and hub ws code get modified.

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Jérôme Mouneyrac added a comment -

Changes on the hub directory: https://github.com/moodlehq/moodle-local_hubdirectory/commit/351046b43193da3f734f129b79fa7176d8ac76e3

Show
Jérôme Mouneyrac added a comment - Changes on the hub directory: https://github.com/moodlehq/moodle-local_hubdirectory/commit/351046b43193da3f734f129b79fa7176d8ac76e3
Hide
Permalink
Jérôme Mouneyrac added a comment -

How this is going to be tested then implemented online:
1- Make change on hub directory => check that hub , and site are still working
2- Make change on hub => check that sites are still working with the updated hubs
3- Make change on the sites => check that sites are still working with not updated hubs

Show
Jérôme Mouneyrac added a comment - How this is going to be tested then implemented online: 1- Make change on hub directory => check that hub , and site are still working 2- Make change on hub => check that sites are still working with the updated hubs 3- Make change on the sites => check that sites are still working with not updated hubs
Hide
Permalink
Jérôme Mouneyrac added a comment - - edited

These are all the points to checks:
Hub directory:

  • cron (get hub info)
  • manage hub => list should now also displayed enrollable courses + downloadable courses (courses and sites number are still displayed for the admin)
  • index.php should now displayed enrollable courses + downloadable courses

Hub server:

  • register on the hub directory
  • update registration on the hub directory

Site:

  • community search => hub listing should displayed the number of enrollable courses + downloadable courses for each hubs comming from the hub directory. (private hub information are at this moment incomplete and required more database fields)
Show
Jérôme Mouneyrac added a comment - - edited These are all the points to checks: Hub directory: cron (get hub info) manage hub => list should now also displayed enrollable courses + downloadable courses (courses and sites number are still displayed for the admin) index.php should now displayed enrollable courses + downloadable courses Hub server: register on the hub directory update registration on the hub directory Site: community search => hub listing should displayed the number of enrollable courses + downloadable courses for each hubs comming from the hub directory. (private hub information are at this moment incomplete and required more database fields)
Hide
Permalink
Jérôme Mouneyrac added a comment -

Note: Hub directory and hub server changes have been implemented and push into their respective repo. They work with current 2.0/2.1 STABLE and current HEAD.

Show
Jérôme Mouneyrac added a comment - Note: Hub directory and hub server changes have been implemented and push into their respective repo. They work with current 2.0/2.1 STABLE and current HEAD.
Hide
Permalink
Dongsheng Cai added a comment -

Looks good to me

Show
Dongsheng Cai added a comment - Looks good to me
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week.

TIA and ciao

Show
Eloy Lafuente (stronk7) added a comment - The main moodle.git repository has just been updated with latest weekly modifications. You may wish to rebase your PULL branches to simplify history and avoid any possible merge conflicts. This would also make integrator's life easier next week. TIA and ciao
Hide
Permalink
Jérôme Mouneyrac added a comment -

You can reject if you wish the time I rebase. Cheers.

Show
Jérôme Mouneyrac added a comment - You can reject if you wish the time I rebase. Cheers.
Hide
Permalink
Aparup Banerjee added a comment -

Hi Jerome,
just one minor point - the comment could use a little clarification/rephrasing.
cheers,
Aparup

Show
Aparup Banerjee added a comment - Hi Jerome, just one minor point - the comment could use a little clarification/rephrasing. cheers, Aparup
Hide
Permalink
Aparup Banerjee added a comment -

Hi guys,
I've just integrated this and also added a quick commit to clarify the comment after chatting to Jerome.

Show
Aparup Banerjee added a comment - Hi guys, I've just integrated this and also added a quick commit to clarify the comment after chatting to Jerome.
Hide
Permalink
Jérôme Mouneyrac added a comment -

Super, thanks Apu

Show
Jérôme Mouneyrac added a comment - Super, thanks Apu
Hide
Permalink
Michael de Raadt added a comment -

Test result: Enrolable and downloadable course numbers matched those on Mooch.

Show
Michael de Raadt added a comment - Test result: Enrolable and downloadable course numbers matched those on Mooch.
Hide
Permalink
Eloy Lafuente (stronk7) added a comment -

git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay!

Closing, ciao

Show
Eloy Lafuente (stronk7) added a comment - git & cvs repositories have been populated with this solution. Many thanks for your collaboration, yay! Closing, ciao

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: