Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-29007

YUI: moodle-enrol-notification should be generalised as its already being used widely outside of enrol

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 2.1.1
    • Fix Version/s: 2.4
    • Component/s: JavaScript, Messages
    • Labels:
    • Testing Instructions:
      Hide
      • Open a course page
      • Turn Editing on
      • Ensure that the dialogues work (e.g. modchooser)
      • Open the filepicker from somewhere
      • Ensure that it opens

      For brownie points:

      • open lib/yui/chooserdialogue/chooserdialogue.js in your editor
      • change the line 'moodle-core-notification' to 'moodle-enrol-notification'
      • open the course page
      • open your js console
      • turn editing on
      • confirm that a warning message is shown suggesting that the enrol module has been deprecated
      Show
      Open a course page Turn Editing on Ensure that the dialogues work (e.g. modchooser) Open the filepicker from somewhere Ensure that it opens For brownie points: open lib/yui/chooserdialogue/chooserdialogue.js in your editor change the line 'moodle-core-notification' to 'moodle-enrol-notification' open the course page open your js console turn editing on confirm that a warning message is shown suggesting that the enrol module has been deprecated
    • Affected Branches:
      MOODLE_21_STABLE
    • Fixed Branches:
      MOODLE_24_STABLE
    • Pull from Repository:
    • Pull Master Branch:
      MDL-29007-master-3

      Description

      In fact I create this bug because we are using it in our private plugins as its so useful

      $ git grep moodle-enrol-notification
      backup/util/ui/yui/confirmcancel/confirmcancel.js:}, '@VERSION@', {'requires':['base','node','node-event-simulate','moodle-enrol-notification']});
      blocks/community/yui/comments/comments.js:    requires:['base','overlay', 'moodle-enrol-notification']
      blocks/community/yui/imagegallery/imagegallery.js:    requires:['base','node','overlay', 'moodle-enrol-notification']
      enrol/cohort/yui/quickenrolment/quickenrolment.js:}, '@VERSION@', {requires:['base','node', 'overlay', 'io', 'test', 'json-parse', 'event-delegate', 'dd-plugin', 'event-key', 'moodle-enrol-notification']});
      enrol/manual/yui/quickenrolment/quickenrolment.js:}, '@VERSION@', {requires:['base','node', 'overlay', 'io', 'test', 'json-parse', 'event-delegate', 'dd-plugin', 'event-key', 'moodle-enrol-notification']});
      enrol/yui/notification/notification.js:YUI.add('moodle-enrol-notification', function(Y) {
      enrol/yui/notification/notification.js:}, '@VERSION@', {requires:['base','node','overlay','event-key', 'moodle-enrol-notification-skin']});
      enrol/yui/otherusersmanager/otherusersmanager.js:}, '@VERSION@', {requires:['base','node', 'overlay', 'io', 'test', 'json-parse', 'event-delegate', 'dd-plugin', 'event-key', 'moodle-enrol-notification']});
      enrol/yui/rolemanager/rolemanager.js:}, '@VERSION@', {requires:['base','node','io','json-parse','test','moodle-enrol-notification']});
      mod/glossary/yui/autolinker/autolinker.js:}, '@VERSION@', {requires:['base','node','event-delegate','overlay','moodle-enrol-notification']});

        Gliffy Diagrams

          Attachments

            Issue Links

              Activity

                People

                • Votes:
                  1 Vote for this issue
                  Watchers:
                  2 Start watching this issue

                  Dates

                  • Created:
                    Updated:
                    Resolved:
                    Fix Release Date:
                    3/Dec/12